[Bug 41457] New: Hold history table does not deal with column visibility correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Bug ID: 41457 Summary: Hold history table does not deal with column visibility correctly Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Depends on: 41456 The "Item type" column is displayed/hidden depending on the syspref AllowHoldItemTypeSelection. If DT's state is saved and the pref modified, the state will be lost. We MUST use bKohaColumnsUseNames (columns' name) to make it work correctly. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 [Bug 41456] Item type filter on the hold history view does not work correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190538&action=edit Bug 41457: Fix column visibility on the holds history table We must use bKohaColumnsUseNames to correctly deal with the column visibility if some columns are shown/hidden depending on sysprefs. On the holds history table we have "item type" that is hidden if AllowHoldItemTypeSelection is disabled. Test plan: 1. Create a hold and select an item type Note: I think there is a bug if you select it from "Hold next available item", use "Hold details". Please confirm? 2. Go to the holds history view 3. Hide some columns 4. Modify the value of AllowHoldItemTypeSelection 5. Reload the page and notice that the state of the table is restored correctly, however the "item type" column is shown or hidden depending on the syspref's value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- This seems to work correctly for me, however no value is shown in the rows for the "Requested item type" column. (Selecting from the dropdown list or using the filters works as expected/) For step 1, if I select "Request specific item type" (Books): - from under the "Hold next available item" section, it shows in the patron's holds history as "Any item type" (doesn't matter what I select here) - from under "Hold details" section, it shows in the patron's holds history as "Book" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190538|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190612&action=edit Bug 41457: Fix column visibility on the holds history table We must use bKohaColumnsUseNames to correctly deal with the column visibility if some columns are shown/hidden depending on sysprefs. On the holds history table we have "item type" that is hidden if AllowHoldItemTypeSelection is disabled. Test plan: 1. Create a hold and select an item type Note: I think there is a bug if you select it from "Hold next available item", use "Hold details". Please confirm? 2. Go to the holds history view 3. Hide some columns 4. Modify the value of AllowHoldItemTypeSelection 5. Reload the page and notice that the state of the table is restored correctly, however the "item type" column is shown or hidden depending on the syspref's value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Nind from comment #2)
This seems to work correctly for me, however no value is shown in the rows for the "Requested item type" column. (Selecting from the dropdown list or using the filters works as expected/)
Oops yes, last minute change, again! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190612|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 190656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190656&action=edit Bug 41457: Fix column visibility on the holds history table We must use bKohaColumnsUseNames to correctly deal with the column visibility if some columns are shown/hidden depending on sysprefs. On the holds history table we have "item type" that is hidden if AllowHoldItemTypeSelection is disabled. Test plan: 1. Create a hold and select an item type Note: I think there is a bug if you select it from "Hold next available item", use "Hold details". Please confirm? 2. Go to the holds history view 3. Hide some columns 4. Modify the value of AllowHoldItemTypeSelection 5. Reload the page and notice that the state of the table is restored correctly, however the "item type" column is shown or hidden depending on the syspref's value. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 --- Comment #6 from David Nind <david@davidnind.com> --- I've signed off, and I think it is working correctly. However: 1. If I apply the patch and set AllowHoldItemTypeSelection = Allow. 2. If I try and hide the "Requested item type" column either by using the table configuration settings or the columns option, it works for that one time. 3. When I go to another page, and then go back to the patron's holds history page, it is then shown again. 4. I'm assuming this is to do with either of the "Save configuration state on page change" and "Save search state on page change" configuration settings, but I've never spent any time trying to figure out what they mean. 5. If I set AllowHoldItemTypeSelection = Don't allow, the column "Requested item type" is not shown in either the columns dropdown list, and whatever is set with the table configuration does not have any effect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #4)
(In reply to David Nind from comment #2)
This seems to work correctly for me, however no value is shown in the rows for the "Requested item type" column. (Selecting from the dropdown list or using the filters works as expected/)
Oops yes, last minute change, again!
A value is now shown in the "Requested item type" column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- QA script complains: missing_filter at line 178 ( const show_itemtype_column = [% Koha.Preference('AllowHoldItemTypeSelection') ? 1 : 0 %];) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190704&action=edit Bug 41457: Add missing html filter Patch from commit c750270 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190656|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190704|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 --- Comment #10 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192276&action=edit Bug 41457: Fix column visibility on the holds history table We must use bKohaColumnsUseNames to correctly deal with the column visibility if some columns are shown/hidden depending on sysprefs. On the holds history table we have "item type" that is hidden if AllowHoldItemTypeSelection is disabled. Test plan: 1. Create a hold and select an item type Note: I think there is a bug if you select it from "Hold next available item", use "Hold details". Please confirm? 2. Go to the holds history view 3. Hide some columns 4. Modify the value of AllowHoldItemTypeSelection 5. Reload the page and notice that the state of the table is restored correctly, however the "item type" column is shown or hidden depending on the syspref's value. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 --- Comment #11 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192277&action=edit Bug 41457: Add missing html filter Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 --- Comment #13 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to stable |Needs documenting --- Comment #14 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Depends on 41456 which was not backported to 25.05.x. This will not be backported either. I'm happy to revisit if necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #15 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org