[Bug 41120] New: Click on New data provider breaks functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 Bug ID: 41120 Summary: Click on New data provider breaks functionality Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: bibliothek@th-wildau.de QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@openfifth.co.uk, martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, pedro.amorim@openfifth.co.uk This seems to be a regression bug as in 24.11. this feature is still working. To recreate: - in ERM add a data provider (/cgi-bin/koha/erm/eusage/usage_data_providers) - dummy data should be sufficient - on the new data provider overview click Close on the bottom to return to the data providers list. - open web development tools (F12 on Firefox) - click New data provider and see the error on the console. The reasons seems to be, that the add form gathers an erm_usage_data_provider_id from an older route in from.value.params.erm_usage_data_provider_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 --- Comment #1 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 188506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188506&action=edit Bug 41120: Fix broken Add data provider functionality Clicking on New data provider in the ERM eUsage section will not work, when a data provider was shown before. Test plan: prequisites: - activate the ERM module system preference. - this is for ktd a) go to /cgi-bin/koha/erm/eusage/usage_data_providers b) add a new data provider, dummy data is sufficient c) submit the new provider and on the following screen click close to return to the provider list d) click on 'Add data provider' (open web dev tools will display an error) e) apply patch f) run 'yarn js:build' f) do a hard refresh in the browser g) on provider list click your created provider h) close it via 'close' to return to the provider list d) click on 'Add data provider' should work now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |bibliothek@th-wildau.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 --- Comment #2 from Jan Kissig <bibliothek@th-wildau.de> --- alternatively this fix: in koha3/koha-tmpl/intranet-tmpl/prog/js/vue/modules/erm.ts The call of navigationStore.$patch includes 'from' but if you log the state of 'from' after the call of $patch it remained as before. So the following changes the state of from in an extra call. navigationStore.$patch({ current: to.matched, params: to.params || {}, }); navigationStore.from = from; What remains is a warning in Firefox console: [Vue Router warn]: Discarded invalid param(s) "erm_usage_data_provider_id" when navigating. See https://github.com/vuejs/router/blob/main/packages/router/CHANGELOG.md#414-2... for more details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188506|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190708&action=edit Bug 41120: Fix broken Add data provider functionality Clicking on New data provider in the ERM eUsage section will not work, when a data provider was shown before. Test plan: prequisites: - activate the ERM module system preference. - this is for ktd a) go to /cgi-bin/koha/erm/eusage/usage_data_providers b) add a new data provider, dummy data is sufficient c) submit the new provider and on the following screen click close to return to the provider list d) click on 'Add data provider' (open web dev tools will display an error) e) apply patch f) run 'yarn js:build' f) do a hard refresh in the browser g) on provider list click your created provider h) close it via 'close' to return to the provider list d) click on 'Add data provider' should work now Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes adding a new release notes| |data provider after | |creating a new data | |provider (ERM > eUsage > | |Data providers > New data | |provider). | | | |If you created a new data | |provider, clicked close | |after the information about | |the provider was shown, | |then went to add another | |new data provider - nothing | |happened: you got an empty | |page, and there was an | |error in the browser | |developer tools console. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 --- Comment #4 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192278&action=edit Bug 41120: Fix broken Add data provider functionality Clicking on New data provider in the ERM eUsage section will not work, when a data provider was shown before. Test plan: prequisites: - activate the ERM module system preference. - this is for ktd a) go to /cgi-bin/koha/erm/eusage/usage_data_providers b) add a new data provider, dummy data is sufficient c) submit the new provider and on the following screen click close to return to the provider list d) click on 'Add data provider' (open web dev tools will display an error) e) apply patch f) run 'yarn js:build' f) do a hard refresh in the browser g) on provider list click your created provider h) close it via 'close' to return to the provider list d) click on 'Add data provider' should work now Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 --- Comment #6 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to stable |Needs documenting --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This patch doesn’t apply cleanly to 25.05, so I’m not planning to backport it at this time. If you’re able to update it for 25.05 compatibility, I’d be happy to take another look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41120 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #8 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org