[Bug 25673] New: Access logging of borrower's personal information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 Bug ID: 25673 Summary: Access logging of borrower's personal information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@helsinki.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Blocks: 18081 I don't know if this is directly related to GDPR but at least this seems like a good practice: create a log if a librarian has accessed a Koha page in intranet that contains borrower's personal information. This way the library can make sure by auditing the logs that nobody has for example downloaded all the borrowers' info en masse with screen scraping. Currently this is a bit hard to implement in Koha since borrower's personal info is displayed on many many pages, but to ease this we should think if displaying borrower's real name is necessary or would a cardnumber or borrowernumber be better. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it really depends on the type of library, country, use cases etc. I think we'd definitely see some push back if we replaced the name by the cardnumber in general as this is seen as a feature. Libraries often know their patrons and want to see the names in a lot of cases. (think small company libraries, professors at universities etc.) But: we already have HidePatronName which makes this configurable in a lot of places that we could extend further. I think logging every page could get a lot pretty fast. Maybe we could start with viewing a patron record? (accessing the detail page) We should also make sure that patron batch edits are logged correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com, | |slavashishkin@gmail.com, | |stalkernoid@gmail.com Assignee|koha-bugs@lists.koha-commun |nugged@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673
Lari Taskula <lari.taskula@hypernova.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lari.taskula@hypernova.fi
--- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> ---
(In reply to Katrin Fischer from comment #1)
> I think logging every page could get a lot pretty fast.
Indeed. This is to be expected. Larger Koha instances are probably talking
about millions to tens of millions of log records of the access/view-event
annually. Not to forget their action_log could already be bloated.
One option would be to clear these logs periodically. The libraries that worry
about action_log size but still want to store it long-term, could consider
other means of storage. They could achieve that with Koha plugins.
There's even real world cases where Koha libraries enabled the "view" event
logging, and some of them regularly move this data into a separate database.
They were also the source to my log row count estimation in the first paragraph
of this comment.
> Maybe we could start with viewing a patron record? (accessing the detail page)
Splitting this into smaller parts is probably smart since it's going to affect
many pages.
> We should also make sure that patron batch edits are logged correctly.
+ REST API + other APIs. Figuring out all the places as well as making sure
that this policy applies to future changes - it's going to be a lot of careful
work :)
--
You are receiving this mail because:
You are watching all bug changes.
I don't know if this is directly related to GDPR By the way it looks like this is not required by GDPR. The Finnish libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 --- Comment #3 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Joonas Kylmälä from comment #0) that use it in their custom Koha fork were inspired by the laws for health care sector, and decided to implement such functionality when there was still a lot of confusion regarding GDPR. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 --- Comment #4 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- There was some confusion regarding this indeed. Koha and the webserver running in front of it provides already logs of similar content albeit in slightly harder to parse format. I feel like we can close this bug and re-open it later if somebody else is interested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Joonas Kylmälä from comment #4)
There was some confusion regarding this indeed. Koha and the webserver running in front of it provides already logs of similar content albeit in slightly harder to parse format. I feel like we can close this bug and re-open it later if somebody else is interested.
I don't know about Koha, but I imagine those web server logs are rotated and old ones are deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 --- Comment #6 from Lari Taskula <lari.taskula@hypernova.fi> --- I think Koha-Suomi libraries have had this in production for some years now. https://github.com/KohaSuomi/Koha-24.05/commit/827040cb1ede8f65c718bb8721c34... We also have clients that are interested in this type of logging. It would be great to have this part of upstream Koha. (In reply to Katrin Fischer from comment #1)
I think logging every page could get a lot pretty fast.
We could add a new switch to cleanup_database.pl to handle different action log module-action-days combinations so that view logging could be wiped more often than other log types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 --- Comment #7 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 187904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187904&action=edit Bug 25673: Add new system preference BorrowersViewLog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 --- Comment #8 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 187905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187905&action=edit Bug 25673: Log patron view actions in staff client and REST API This patch adds a crude logging of patron view events. It adds logging to the following REST API endpoints - /api/v1/patrons - /api/v1/patrons/{patron_id} In staff client, instead of defining the log event on each page individually, we log every authorized staff client page request that contains a borrowernumber as a request parameter. To test staff client: 1. Enable system preference BorrowersViewLog 2. Navigate to patrons 3. Without specifying any filters, click "Search" 4. Click on one of the borrowers 5. Navigate to "Modification log" of this patron 6. Observe two rows Module Action Info Interface "Patrons" "VIEW" "members/moremember" "Staff interface" "Patrons" "VIEW" "list" "REST API" 7. Disable system preference BorrowersViewLog 8. Repeat steps 2-5 9. Observe no new rows To test REST API: 1. prove t/db_dependent/api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30279 CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #9 from David Nind <david@davidnind.com> --- The patches no longer apply. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org