[Bug 21731] New: t::lib::QA::TemplateFilters missing built-in TT filter "xml" causes false warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 Bug ID: 21731 Summary: t::lib::QA::TemplateFilters missing built-in TT filter "xml" causes false warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org I'm getting the following warning from the QA script: missing_filter at line 15 ( <div style="white-space:pre">[% record | xml %]</div>) I clearly do have an xml filter there. Josef has said it's because it's missing from t::lib::QA::TemplateFilters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- There another question on top of this: Do we wan't to enable all built-in template toolkit filters by default? And so add them to test? http://template-toolkit.org/docs/manual/Filters.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |21393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21393 [Bug 21393] Make template filter checks code reusable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21770 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WISHLIST Status|NEW |RESOLVED --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Closing this due to age -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WISHLIST |--- Status|RESOLVED |REOPENED --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Reopening, if it's still valid we should fix it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #3)
Reopening, if it's still valid we should fix it.
I just did a quick test and it looks like it's still valid: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt FAIL filters missing_filter at line 17 (<title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle | xml %][% ELSE %]Koha online[% END %] catalog</title>) However, it's not 100% clear to me how to fix this one. I can write a patch which fixes this problem, but there might be other places in the script that need updating too? I don't know. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 173850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173850&action=edit Bug 21731: Try to fix filter detection in QA script for xml filter This change adds support for the "xml" filter to the QA script. Test plan: 1. Change a "html" filter in opac-main.tt to use "xml" instead, and temporarily commit your change 2. Run "qa" script 3. Notice it fails 4. Apply the BZ patch 5. Run "qa" script 6. Note that it passes now 7. Sign off the BZ patch and only upload it (and not your temporary commit which you can delete after) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|chris@bigballofwax.co.nz |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Josef Moravec from comment #1)
There another question on top of this: Do we wan't to enable all built-in template toolkit filters by default? And so add them to test?
Valid question, why 'xml'? We don't use it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- The comment is incorrect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #6)
(In reply to Josef Moravec from comment #1)
There another question on top of this: Do we wan't to enable all built-in template toolkit filters by default? And so add them to test?
Valid question, why 'xml'? We don't use it.
(In reply to Jonathan Druart from comment #7)
The comment is incorrect.
I can't find a "xml" filter now, although I'm guessing I originally wanted it for a patch that I was developing back in 2018. I thought that I added "scrub_html" from bug 38488 but apparently not... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org