[Bug 15374] New: Translatability: Fix issues on OPAC summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Bug ID: 15374 Summary: Translatability: Fix issues on OPAC summary page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 45680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45680&action=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Patch complexity|--- |Small patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15375 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Chris Kirby <christopherlawrencekirby@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christopherlawrencekirby@gm | |ail.com --- Comment #2 from Chris Kirby <christopherlawrencekirby@gmail.com> --- Hi Marc, Applied the patch on Sandbox 14. - Logged in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely. I did not find that links in messages (for example to books in the OPAC) worked. - Attempted to test with user who has to much fines. Created manual fines/lost items charges, but fines did NOT display in "total due". On another sandbox, I did not apply the patch and found that for manual restriction, the expiration date picker did NOT pop up. Was fixing this part of your patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #3 from Marc Véron <veron@veron.ch> --- Hi Chris, Thanks for testing! Hmm, you talk about date picker and links to books, did you really test the OPAC summary page? Home > [Patron's name] > Your summary [server]/cgi-bin/koha/opac-user.pl It is the page that appears immediately after a log in to the OPAC ( at the left the tab 'your summary'). After log in you should see messages like the following (depending on the user's status): ---- Please note: Your account has expired as of 15.12.2015. Please contact the library if you wish to renew your account. Please note: According to our records, we don't have up-to-date contact information. Please contact the library. Update your contact information (Please note: there may be a delay in restoring your account if you submit online.) Please note: Your library card has been marked as lost or stolen. If this is an error, please contact the library. Please note: You cannot renew your books online. Reason: Your fines exceed 100.00. Please pay your fines if you wish to renew your books. Go to your account page ---- -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #4 from Marc Véron <veron@veron.ch> --- Note: To test for a user who has to much fines, you can - go to staff client - set syspref 'OPACFineNoRenewals' e.g. to 100 (if empty nothing is calculated) - add a manual fine for this user, e.g. 200 (Search a user, 'Fines' in lefthand menue, Tab 'Create manual invoice') -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Testing with a user who has too many fines did not work. I had the syspref set correctly and created a manual invoice of $100 but there was no error message saying the account was blocked due to fines. A 'Fines' tab showed up saying 'Fines (100)', which I think would be better to say $100.00. Didn't see my circulation message, not sure how this is meant to affect the OPAC? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45680|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 45876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45876&action=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4078 --- Comment #7 from Marc Véron <veron@veron.ch> --- (In reply to Aleisha Amohia from comment #5)
Testing with a user who has too many fines did not work. I had the syspref set correctly and created a manual invoice of $100 but there was no error message saying the account was blocked due to fines. A 'Fines' tab showed up saying 'Fines (100)', which I think would be better to say $100.00. Didn't see my circulation message, not sure how this is meant to affect the OPAC?
Hi Aleisha, thanks for testing. - I amended the patch to format fines tab as well. (100.00 instead of 100). Regarding the display of the currency sign see Bug 4078 (waiting for Sign-off) Regarding a user who has too many fines: - I re-tested with syspref OPACFineNoRenewals set to 100 and a patron 'Tester' with fines (200) and logged in to the OPAC with this user. (Expecting: A message that now renewals are possible due to fines.) Without patch, I get after log-in (cgi-bin/koha/opac-user.pl): - Warning message: Please note: Since you have more than 100.00 in fines, you cannot renew your books online. Please pay your fines if you wish to renew your books. - Tab Heading: Fines (200.00) With patch, I get: - Warning message: Please note: You cannot renew your books online. Reason: Your fines exceed 100.00. Please pay your fines if you wish to renew your books. Go to your account page [As expected. Better wording / no sentence splitting for translatability] - Tab Heading: Fines: 200.00 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #8 from Marc Véron <veron@veron.ch> --- Note: I amended "Bug 4078 - Display active currency symbol on currency output and input" in a way that it can be tested on top of this bug. (But it does not depend on this bug nor blocks this bug). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #9 from Aleisha Amohia <aleishaamohia@hotmail.com> ---
With patch, I get: - Warning message: Please note: You cannot renew your books online. Reason: Your fines exceed 100.00. Please pay your fines if you wish to renew your books. Go to your account page [As expected. Better wording / no sentence splitting for translatability]
- Tab Heading: Fines: 200.00
The fines tab looks much better now but I'm still not seeing any warning message when I log in. I get a warning message when I try to place a hold on something but not on the summary page when I log in. Also I tested with your patch for Bug 4078 and it works well, so can I sign off on that one? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #10 from Marc Véron <veron@veron.ch> --- (In reply to Aleisha Amohia from comment #9)
(...)I'm still not seeing any warning message when I log in.
I can reproduce the behaviour. It is related to a system preference OpacRenewalAllowed: [Allow] patrons to renew their own books on the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45876|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 45918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45918&action=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CONFLICT (content): Merge conflict in opac/opac-user.pl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45918|0 |1 is obsolete| | --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 46234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46234&action=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha <aleishaamohia@hotmail.com> (Amended to make patches apply, see comment #12) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46234|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 46564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46564&action=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha <aleishaamohia@hotmail.com> (Amended to make patches apply, see comment #12) Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marc, I have not tested the patch, but it seems that a conflict with bug 15344 has not been fixed correctly. BORROWER_INFO should not be BORROWER_INF -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org