[Bug 20719] New: Missing branchcode in /cgi-bin/koha/members/files.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Bug ID: 20719 Summary: Missing branchcode in /cgi-bin/koha/members/files.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: amitddng135@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Missing branchcode in /cgi-bin/koha/members/files.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |amitddng135@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 --- Comment #1 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 75116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75116&action=edit Branchcode not shown in files.pl Branchcode not shown in files.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 75117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75117&action=edit Bug 20719 - Missing branchcode in /cgi-bin/koha/members/files.pl Test 1. Hit the page /cgi-bin/koha/members/files.pl?borrowernumber=xx xx is a borrowernumber 2. Apply the patch and reload the page. 3. You can see branchcode on the left handside. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- This is part of a bigger problem. Need to check these out further. koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/deletemem.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/files.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/nl-search.tt This list was generated by looking at the output of: for i in `git grep circ-menu.inc | grep tt: | cut -f1 -d:`; do echo "*****";echo $i;echo;grep Branch $i;echo "*****"; done | less and then selecting those that lacked Branch. The other cases generally had the required "[% USE Branches %]" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- This is not an enhancement. The branch code/name should display. It's a minor bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 75142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75142&action=edit Bug 20719: USE Branches in TT files TEST PLAN --------- In the staff client on a kohadevbox: 1) Enable the HouseboundModule system preference. 2) Enable the EnableBorrowerFiles system preference. 3) Go to a patron detail page. -- note the Home library is shown. 4) Go to Fines tab (left pane) -- Home library is still shown. 5) Click each of the four horizontal tabs (Account, Pay fines, Create manual invoice, Create manual credit) -- Home library not visible for both create tabs and the account tab 6) Click the 'Create manual invoice' tab, and create some kind of entry. 7) On the 'Account' tab, the table has a 'Details' button. Click that. -- Home library not visible. 8) Click the 'Details' tab in the left pane. 9) Click 'More' button and choose 'Delete' -- Home library not visible when asked for delete confirmation. 10) Cancel that, and if you know how to actually set up the Norwegian system preferences you can figure out how to test the nl-search change. After seeing all these not visible, apply this patch. Repeat all the steps, but this time the Home library should be visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75117|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 75143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75143&action=edit Bug 20719 - Add missing USE Branches to files.tt Test On a kohadevbox: 0. Enable the EnableBorrowerFiles system preference 1. Go to any patron, and click on the 'Files' tab in the left pane. -- the Home library is not displayed. 2. Apply the patch, restart_all, and reload the page. -- the Home library is now displayed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75142|0 |1 is obsolete| | --- Comment #7 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 75152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75152&action=edit Bug 20719: USE Branches in TT files Works fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing branchcode in |Home library not displayed |/cgi-bin/koha/members/files |as expected |.pl | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75143|0 |1 is obsolete| | Attachment #75152|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75238&action=edit Bug 20719: Add missing USE Branches to files.tt Test On a kohadevbox: 0. Enable the EnableBorrowerFiles system preference 1. Go to any patron, and click on the 'Files' tab in the left pane. -- the Home library is not displayed. 2. Apply the patch, restart_all, and reload the page. -- the Home library is now displayed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75239&action=edit Bug 20719: USE Branches in TT files TEST PLAN --------- In the staff client on a kohadevbox: 1) Enable the HouseboundModule system preference. 2) Enable the EnableBorrowerFiles system preference. 3) Go to a patron detail page. -- note the Home library is shown. 4) Go to Fines tab (left pane) -- Home library is still shown. 5) Click each of the four horizontal tabs (Account, Pay fines, Create manual invoice, Create manual credit) -- Home library not visible for both create tabs and the account tab 6) Click the 'Create manual invoice' tab, and create some kind of entry. 7) On the 'Account' tab, the table has a 'Details' button. Click that. -- Home library not visible. 8) Click the 'Details' tab in the left pane. 9) Click 'More' button and choose 'Delete' -- Home library not visible when asked for delete confirmation. 10) Cancel that, and if you know how to actually set up the Norwegian system preferences you can figure out how to test the nl-search change. After seeing all these not visible, apply this patch. Repeat all the steps, but this time the Home library should be visible. Works OK. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Home library not displayed |Home library not displayed |as expected |on all patron account tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org