[Bug 34034] New: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Bug ID: 34034 Summary: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 21156 A few strings are defined in opac-bottom.inc for use by OverDrive and OpenLibrary search integration. These can be moved to the corresponding <script> block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 [Bug 34031] Move various translatable strings out of opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152411&action=edit Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary This patch removes some string variable definitions from opac-bottom.inc. The strings can now be picked up for translation from the corresponding <script> block. To test you must enable OpenLibrarySearch and enter OverDrive credentials to enable OverDrive search integration. - Perform a search in the OPAC. - As the results page loads you should see at the top "Searching OverDrive..." and "Searching OpenLibrary..." - When the searches complete you should see "Found X results in the library's Y collection" for each service. - Try to trigger an error message by entering the wrong (non-zero) value for the OverDriveLibraryID preference. - The search results page should show "Error searching OverDrive collection" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34035 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152411|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 155240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155240&action=edit Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary This patch removes some string variable definitions from opac-bottom.inc. The strings can now be picked up for translation from the corresponding <script> block. To test you must enable OpenLibrarySearch and enter OverDrive credentials to enable OverDrive search integration. - Perform a search in the OPAC. - As the results page loads you should see at the top "Searching OverDrive..." and "Searching OpenLibrary..." - When the searches complete you should see "Found X results in the library's Y collection" for each service. - Try to trigger an error message by entering the wrong (non-zero) value for the OverDriveLibraryID preference. - The search results page should show "Error searching OverDrive collection" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off, even though I don't have any OverDrive credentials. I was able to trigger the error message by entering some random details for OverDrive credentials. Please change back to needs signoff if this insufficient. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We need a sign-off on one of the dependencies here, please! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #4)
We need a sign-off on one of the dependencies here, please!
I've signed off all the related dependencies and changed the status to 'Signed off' where required (hope that is the right thing to do - bug 34035, bug 34031, bug 34026, and bug 33983). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155240|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156709&action=edit Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary This patch removes some string variable definitions from opac-bottom.inc. The strings can now be picked up for translation from the corresponding <script> block. To test you must enable OpenLibrarySearch and enter OverDrive credentials to enable OverDrive search integration. - Perform a search in the OPAC. - As the results page loads you should see at the top "Searching OverDrive..." and "Searching OpenLibrary..." - When the searches complete you should see "Found X results in the library's Y collection" for each service. - Try to trigger an error message by entering the wrong (non-zero) value for the OverDriveLibraryID preference. - The search results page should show "Error searching OverDrive collection" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Bug 34034 depends on bug 34031, which changed state. Bug 34031 Summary: Move various translatable strings out of opac-bottom.inc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org