https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master Summary|Customers Cancelling their |Allow patrons to cancel |Pending Holds |their waiting holds Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #1 from Margaret <margaret@bywatersolutions.com> --- Hi Chris, You should know that this enhancement runs counter to this other recently resolved bug: Bug 18856 - "Cancel Waiting Hold in OPAC does not give useful message". The functionality you are asking for was recently removed due to its tendency to leave items stranded. So, would how you like this to work? Would this be a new system pref? How would the staff side work once the hold has been canceled by the patron? How would you be alerted to this newly canceled hold? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #3 from Christofer <christofer.zorn@ajaxlibrary.ca> --- Thank you Katrin ... I would see this as a system preference. When enabled it would allow patrons to cancel the waiting hold from the Opac. From my perspective, as long as the reserves / old_reserves table was updated holding the date of the cancellation, we could then run a report that would list the items that were cancelled in the last 24 hours or so. Then staff could pull them from the hold shelf. When the customer cancels the hold the opac display would toggle the button text from "Cancel" to "Cancelled". The item would remain in their queue until the staff pulled the book and checked it in, based on the report. Our Library is new to Koha and what I love is the flexibility (we have done things in this system we could only have dreamed of in our previous one). However, choice is what makes this system great. While I respect that this request runs counter to the most recent change and libraries like the status quo, I feel giving us the option to use the system the way we need to is what Koha is about. Thank you again! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 24730 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #7 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I support this feature as well. Just last night a Library Board member asked me why she couldn't cancel a hold that was waiting for her on the hold shelf. It should definitely be a system pref because I'm sure some libraries would not want to enable this behavior. I like the idea of having a link to the cancelled holds appear on the staff home page along with the other things (pending suggestions, patrons requesting modifications, etc.) staff need to act on because that would make it front and center. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like the idea of having it on the dashboard, but if we put them there, I'd also like to see them on the holds awaiting pickup report somehow, because this is where they probably are still :) I wonder database wise how we should deal with these. We could just show 'cancelled in last... hours' - but then the library will be closed etc. and it won't work as nicely and you will never see what your coworkers have already taken care of... Some way to actually process them might be nice. Maybe a checkin could remove them from the list? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I have started coding this. The first thing I did was making it an entry in the circulation rules page so this can be set per library and per patron category. More on this tomorrow :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #8)

I like the idea of having it on the dashboard, but if we put them there, I'd also like to see them on the holds awaiting pickup report somehow, because this is where they probably are still :)

I wonder database wise how we should deal with these. We could just show 'cancelled in last... hours' - but then the library will be closed etc. and it won't work as nicely and you will never see what your coworkers have already taken care of...

I've added a hold_cancellation_requests table to store all we might need about the cancellation request. Patron's will be allowed per-circ rules to request cancellation and visual indicators will let librarians know if there are waiting holds requiring attention, haven't got there yet. It will be API-driven as much as possible. -- You are receiving this mail because: You are watching all bug changes.

SELECT * FROM circulation_rules WHERE rule_name='waiting_hold_cancellation'; => SUCCESS: Set to 0

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135166&action=edit Bug 22456: Add waiting_hold_cancellation circulation rule This patch adds handling for the waiting_hold_cancellation circulation rule. It is set no 'No' by default in the atomic update, if not previously set. Handling in the rules editor is added, in its own section. To test: 1. Apply this patch 2. Run: $ updatedatabase => SUCCESS: All good 3. Verify that the syspref is set: $ koha-mysql kohadev 4. Play with the rules editor, changing things back and forth, things should work, including library-specific and global/defualt settings. => SUCCESS: It works => SUCCESS: Texts are idiomatic 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135168&action=edit Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es) This patch adds the Koha::Object-derived classes for cancellation requests. Tests are added for the overloaded ->store method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold/CancellationRequest.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135170&action=edit Bug 22456: Allow requesting cancellation from the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, I submitted so y'all can see where this is headed to. What is done: - Circulation rules page setting the ability to request cancellation of waiting holds per library, category and item type. - Barebones, internals (db table, classes, tests, etc). All based on circ rules - OPAC handling for this - A mockup of how we would handle this in staff (see Holds awaiting pickup) The idea is that the new tab in 'Holds awaiting pickup' will provide buttons for accepting or rejecting the cancellation request. Once that's done, we should move into making some actions trigger acceptance/rejection automatically, if required. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135169|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135171|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135166|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135319&action=edit Bug 22456: Add cancellation request table This patch adds a new table, for storing holds cancellation requests, and managing them afterwards. The *hold_id* attribute is not made a FK on the reserves table because of the old_reserves thing we still do (see bug 25260 for a discussion about it). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135321&action=edit Bug 22456: DBIC update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135323&action=edit Bug 22456: Add cancellation request methods to Koha::Hold This patch adds the following helper methods for dealing with hold cancellation requests to the Koha::Hold class: * cancellation_requests * add_cancellation_request * cancellation_requestable_from_opac * cancellation_requested_by_owner To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135325&action=edit Bug 22456: Add Koha::Holds->filter_by_has_pending_cancellation_requests This patch adds that method. Which is covered by new tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #30 from David Nind <david@davidnind.com> --- Hi Tomás. I have tested this, and it all works fine except for these two things: 1. Test fails for prove t/db_dependent/Koha/Hold.t 2. I'm not sure of the workflow in the staff interface or the reason why there is a "Reject cancellation" option 1. Test fails for prove t/db_dependent/Koha/Hold.t ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ prove t/db_dependent/Koha/Hold.t t/db_dependent/Koha/Hold.t .. 4/8 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`hold_cancellation_requests`, CONSTRAINT `hc_resolver_ibfk` FOREIGN KEY (`resolver_id`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE) at /kohadevbox/koha/Koha/Object.pm line 170 # Looks like you planned 2 tests but ran 1. # Failed test 'cancellation_requests handling' # at t/db_dependent/Koha/Hold.t line 650. # Looks like you failed 1 test of 7. t/db_dependent/Koha/Hold.t .. 5/8 # Failed test 'cancel() tests' # at t/db_dependent/Koha/Hold.t line 653. Broken FK constraint# Looks like your test exited with 255 just after 5. t/db_dependent/Koha/Hold.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 4/8 subtests Test Summary Report ------------------- t/db_dependent/Koha/Hold.t (Wstat: 65280 Tests: 5 Failed: 1) Failed test: 5 Non-zero exit status: 255 Parse errors: Bad plan. You planned 8 tests but ran 5. Files=1, Tests=5, 12 wallclock secs ( 0.03 usr 0.01 sys + 9.59 cusr 1.79 csys = 11.42 CPU) Result: FAIL 2. I'm not sure of the workflow in the staff interface or the reason why there is a "Reject cancellation" option ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ If I: 1. Request cancellation in the OPAC (Request cancellation button) it changes to a non-clickable button (Cancellation requested). 2. Reject cancellation in the staff interface (Holds awaiting pickup > Holds with cancellation requests tab, and select "Reject cancellation". The result is: - In OPAC the button for the hold changes to "Cancellation rejected" (non-clickable) - In the staff interface it goes back into the "Holds waiting" tab - I have to click "Cancel hold", then it is removed from the OPAC and holds awaiting pickup > Holds waiting tab -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135326|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135350&action=edit Bug 22456: Allow requesting cancellation from the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135352&action=edit Bug 22456: Staff interface handling This patch introduces a new tab to the 'Holds awaiting pickup' screen for holds that have cancellation requests. This can be accepted (by cancelling the hold) or rejected. To test: 1. Set circulation rules for cancellation requests, allowing them for certain item type. 2. Have some waiting holds for a patron on an item type that allows requesting cancellation. 3. Visit 'Holds awaiting pickup' => SUCCESS: No holds have cancellation requests 4. In the OPAC, on the user details, notice some holds have the ability to be requested cancellation. 5. Choose to request cancellation => SUCCESS: Request is placed, the button is disabled 6. In 'Holds awaiting pickup' you can see them 7. Play with rejecting/accepting => SUCCESS: It works! 8. Things are reflected in the OPAC side -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135351|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135349|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135319|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135396&action=edit Bug 22456: Add cancellation request table This patch adds a new table, for storing holds cancellation requests, and managing them afterwards. The *hold_id* attribute is not made a FK on the reserves table because of the old_reserves thing we still do (see bug 25260 for a discussion about it). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135398&action=edit Bug 22456: DBIC update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135400&action=edit Bug 22456: Add cancellation request methods to Koha::Hold This patch adds the following helper methods for dealing with hold cancellation requests to the Koha::Hold class: * cancellation_requests * add_cancellation_request * cancellation_requestable_from_opac * cancellation_requested_by_owner To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #42 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135402&action=edit Bug 22456: Allow requesting cancellation from the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

SELECT * FROM circulation_rules WHERE rule_name='waiting_hold_cancellation'; => SUCCESS: Set to 0

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135397|0 |1 is obsolete| | --- Comment #45 from David Nind <david@davidnind.com> --- Created attachment 135405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135405&action=edit Bug 22456: Add waiting_hold_cancellation circulation rule This patch adds handling for the waiting_hold_cancellation circulation rule. It is set no 'No' by default in the atomic update, if not previously set. Handling in the rules editor is added, in its own section. To test: 1. Apply this patch 2. Run: $ updatedatabase => SUCCESS: All good 3. Verify that the syspref is set: $ koha-mysql kohadev 4. Play with the rules editor, changing things back and forth, things should work, including library-specific and global/defualt settings. => SUCCESS: It works => SUCCESS: Texts are idiomatic 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135399|0 |1 is obsolete| | --- Comment #47 from David Nind <david@davidnind.com> --- Created attachment 135407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135407&action=edit Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es) This patch adds the Koha::Object-derived classes for cancellation requests. Tests are added for the overloaded ->store method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold/CancellationRequest.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135401|0 |1 is obsolete| | --- Comment #49 from David Nind <david@davidnind.com> --- Created attachment 135409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135409&action=edit Bug 22456: Add Koha::Holds->filter_by_has_cancellation_requests This patch adds that method. Which is covered by new tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135403|0 |1 is obsolete| | --- Comment #51 from David Nind <david@davidnind.com> --- Created attachment 135411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135411&action=edit Bug 22456: Staff interface handling This patch introduces a new tab to the 'Holds awaiting pickup' screen for holds that have cancellation requests. This can be accepted (by cancelling the hold) or rejected. To test: 1. Set circulation rules for cancellation requests, allowing them for certain item type. 2. Have some waiting holds for a patron on an item type that allows requesting cancellation. 3. Visit 'Holds awaiting pickup' => SUCCESS: No holds have cancellation requests 4. In the OPAC, on the user details, notice some holds have the ability to be requested cancellation. 5. Choose to request cancellation => SUCCESS: Request is placed, the button is disabled 6. In 'Holds awaiting pickup' you can see them 7. Play with rejecting/accepting => SUCCESS: It works! 8. Things are reflected in the OPAC side Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows |This enhancement allows release notes|patrons to cancel holds |patrons to cancel holds |waiting for pickup from |waiting for pickup from |their account (summary > |their account (summary > |holds > request |holds > request |cancellation button), |cancellation button), |instead of having to |instead of having to |contact the library (for |contact the library (for |example, by email, phone, |example, by email, phone, |or in person). |or in person). | | |This is |This is |enabled by setting rules by |enabled by setting rules by |library, patron type, and |library, patron type, and |item type. The rules are |item type. The rules are |set from a new "Default |set from a new "Default |waiting hold cancellation |waiting hold cancellation |policy" section under |policy" section under |Administration > Patrons |Administration > Patrons |and circulation > |and circulation > |Circulation and fines |Circulation and fines |rules. |rules. | | |Cancellation |Cancellation |requests received for |requests are listed in a |processing are listed in a |new tab "Holds with |new tab "Holds with |cancellation requests" |cancellation requests" |under Circulation > Holds > |under Circulation > Holds > |Holds awaiting pickup. |Holds awaiting pickup. | --- Comment #52 from David Nind <david@davidnind.com> --- I've created some draft documentation for adding to the manual when pushed (anyone should be able to edit this, it is a google doc..): https://docs.google.com/document/d/1RMRvURF5VJy8YkUBuPSTilaL90JPVP23UaXln7pa... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135411|0 |1 is obsolete| | --- Comment #55 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135831&action=edit Bug 22456: Staff interface handling This patch introduces a new tab to the 'Holds awaiting pickup' screen for holds that have cancellation requests. This can be accepted (by cancelling the hold) or rejected. To test: 1. Set circulation rules for cancellation requests, allowing them for certain item type. 2. Have some waiting holds for a patron on an item type that allows requesting cancellation. 3. Visit 'Holds awaiting pickup' => SUCCESS: No holds have cancellation requests 4. In the OPAC, on the user details, notice some holds have the ability to be requested cancellation. 5. Choose to request cancellation => SUCCESS: Request is placed, the button is disabled 6. In 'Holds awaiting pickup' you can see them 7. Play with rejecting/accepting => SUCCESS: It works! 8. Things are reflected in the OPAC side Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30500 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135404|0 |1 is obsolete| | --- Comment #57 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135838&action=edit Bug 22456: Add cancellation request table This patch adds a new table, for storing holds cancellation requests, and managing them afterwards. The *hold_id* attribute is not made a FK on the reserves table because of the old_reserves thing we still do (see bug 25260 for a discussion about it). Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135406|0 |1 is obsolete| | --- Comment #59 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135840&action=edit Bug 22456: DBIC update Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135408|0 |1 is obsolete| | --- Comment #61 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135842&action=edit Bug 22456: Add cancellation request methods to Koha::Hold This patch adds the following helper methods for dealing with hold cancellation requests to the Koha::Hold class: * cancellation_requests * add_cancellation_request * cancellation_requestable_from_opac * cancellation_requested_by_owner To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135830|0 |1 is obsolete| | --- Comment #63 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135844&action=edit Bug 22456: Allow requesting cancellation from the OPAC Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135832|0 |1 is obsolete| | --- Comment #65 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135846&action=edit Bug 22456: (follow-up) Cancel holds at checkin This patch makes checkin process the cancellation requested holds actually cancel them before moving forward. To test: 1. Have a waiting hold with a patron generated cancellation request 2. At circulation, check the item in => SUCCESS: The workflow follows as if the cancellation requested hold was already cancelled => SUCCESS: The hold is actually cancelled => SUCCESS: Not shown in the OPAC anymore Sponsored-by: Montgomery County Public Libraries Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #69 from Lari Taskula <lari.taskula@hypernova.fi> --- I think it would be user friendly to let patron uncancel the cancellation request in OPAC, just because even with the confirmation dialog box someone may accidentally cancel a wrong hold or start regretting their action later. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #73 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Lari Taskula from comment #69)

I think it would be user friendly to let patron uncancel the cancellation request in OPAC, just because even with the confirmation dialog box someone may accidentally cancel a wrong hold or start regretting their action later.

Is that even possible if holds are automatically triggered for the next hold after cancellation? (maybe I'm not completely understanding the process). Anyway, IMO, I think it is overkill to have a backup for a backup. The confirmation should be the end-all. An undo seems like it is out of the scope of this project anyway. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #75 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Lari Taskula from comment #74)

(In reply to Christopher Brannon from comment #73)

...

Is that even possible if holds are automatically triggered for the next hold after cancellation? (maybe I'm not completely understanding the process).

While the hold is in pending cancellation request status (not yet processed), it should be possible. The cancellation request entry would simply be deleted from the newly introduced "hold_cancellation_requests" table and the hold would continue to exist normally.

...

An undo seems like it is out of the scope of this project anyway.

Perhaps. But I don't like a disabled button in OPAC saying "Cancellation requested" and the fact that if a patron wanted to revert the action there is nothing they can do other than giving the library a phone call and cause a lot of annoying manual work for the librarians, or an angry patron if nothing could be done.

There's no cancellation acceptance workflow (there was, originally, and I stripped it out). The main intention here is to let the staff know that hold has been cancelled even if waiting. I guess we could just remove it from the OPAC view. As it is really cancelled. Just having this intermediate status to be able to alert staff in different places. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #77 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Christopher Brannon from comment #76)

Even if an undo was an option, it would have been for a limited time. Yes, maybe we would have averted a phone call or annoying work, or an angry patron, but we get those anyway, and if they wait long enough, they will miss that window and still call. I'm not saying I'm 100% against it, but a confirmation is their 2nd chance to fix a mistake. We don't really offer undo's anywhere else. Why should this be the exception?

I think anything that reduces manual work from librarians is worth considering.

I think removing the button is a better option.

I'm fine with having the button stay as it is or get removed, or moving this into a new Bug. As you said it seems out of scope. I appreciate that and it's okay. My intention was to share a possible scenario and an idea for enhancement but not stop the Bug from moving forward because of it. It's not that huge deal for me. Tomás has done great work with this Bug! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135842|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135844|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135846|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

SELECT * FROM circulation_rules WHERE rule_name='waiting_hold_cancellation'; => SUCCESS: Set to 0

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #79 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137581&action=edit Bug 22456: Add waiting_hold_cancellation circulation rule This patch adds handling for the waiting_hold_cancellation circulation rule. It is set no 'No' by default in the atomic update, if not previously set. Handling in the rules editor is added, in its own section. To test: 1. Apply this patch 2. Run: $ updatedatabase => SUCCESS: All good 3. Verify that the syspref is set: $ koha-mysql kohadev 4. Play with the rules editor, changing things back and forth, things should work, including library-specific and global/defualt settings. => SUCCESS: It works => SUCCESS: Texts are idiomatic 5. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #81 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137583&action=edit Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es) This patch adds the Koha::Object-derived classes for cancellation requests. Tests are added for the overloaded ->store method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold/CancellationRequest.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #83 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137585&action=edit Bug 22456: Add Koha::Holds->filter_by_has_cancellation_requests This patch adds that method. Which is covered by new tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #85 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137587&action=edit Bug 22456: Staff interface handling This patch introduces a new tab to the 'Holds awaiting pickup' screen for holds that have cancellation requests. This can be accepted (by cancelling the hold) or rejected. To test: 1. Set circulation rules for cancellation requests, allowing them for certain item type. 2. Have some waiting holds for a patron on an item type that allows requesting cancellation. 3. Visit 'Holds awaiting pickup' => SUCCESS: No holds have cancellation requests 4. In the OPAC, on the user details, notice some holds have the ability to be requested cancellation. 5. Choose to request cancellation => SUCCESS: Request is placed, the button is disabled 6. In 'Holds awaiting pickup' you can see them 7. Play with rejecting/accepting => SUCCESS: It works! 8. Things are reflected in the OPAC side Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #87 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137589&action=edit Bug 22456: (QA follow-up) Consider cancellation requested as cancelled in OPAC This patch adds a helper method for filtering out cancellation requested-holds from resultsets, and makes use of it in the OPAC to filter out those in the current holds tab. Holds history now shows 'Waiting (cancellation requested)' on those. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137589|0 |1 is obsolete| | --- Comment #89 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137591&action=edit Bug 22456: (QA follow-up) Consider cancellation requested as cancelled in OPAC This patch adds a helper method for filtering out cancellation requested-holds from resultsets, and makes use of it in the OPAC to filter out those in the current holds tab. Holds history now shows 'Waiting (cancellation requested)' on those. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

SELECT * FROM circulation_rules WHERE rule_name='waiting_hold_cancellation'; => SUCCESS: Set to 0

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #91 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138210&action=edit Bug 22456: Add waiting_hold_cancellation circulation rule This patch adds handling for the waiting_hold_cancellation circulation rule. It is set no 'No' by default in the atomic update, if not previously set. Handling in the rules editor is added, in its own section. To test: 1. Apply this patch 2. Run: $ updatedatabase => SUCCESS: All good 3. Verify that the syspref is set: $ koha-mysql kohadev 4. Play with the rules editor, changing things back and forth, things should work, including library-specific and global/defualt settings. => SUCCESS: It works => SUCCESS: Texts are idiomatic 5. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #93 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138212&action=edit Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es) This patch adds the Koha::Object-derived classes for cancellation requests. Tests are added for the overloaded ->store method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold/CancellationRequest.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #95 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138214&action=edit Bug 22456: Add Koha::Holds->filter_by_has_cancellation_requests This patch adds that method. Which is covered by new tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #97 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138216&action=edit Bug 22456: Staff interface handling This patch introduces a new tab to the 'Holds awaiting pickup' screen for holds that have cancellation requests. This can be accepted (by cancelling the hold) or rejected. To test: 1. Set circulation rules for cancellation requests, allowing them for certain item type. 2. Have some waiting holds for a patron on an item type that allows requesting cancellation. 3. Visit 'Holds awaiting pickup' => SUCCESS: No holds have cancellation requests 4. In the OPAC, on the user details, notice some holds have the ability to be requested cancellation. 5. Choose to request cancellation => SUCCESS: Request is placed, the button is disabled 6. In 'Holds awaiting pickup' you can see them 7. Play with rejecting/accepting => SUCCESS: It works! 8. Things are reflected in the OPAC side Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #99 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138218&action=edit Bug 22456: (QA follow-up) Consider cancellation requested as cancelled in OPAC This patch adds a helper method for filtering out cancellation requested-holds from resultsets, and makes use of it in the OPAC to filter out those in the current holds tab. Holds history now shows 'Waiting (cancellation requested)' on those. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #100 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #102 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but I get this error when trying to return an item with a hold on it: Can't call method "id" on an undefined value at /kohadevbox/koha/circ/returns.pl line 351 349: # is there a waiting hold for the item, for which cancellation 350: # has been requested? 351: my $waiting_holds_to_be_cancelled = 352: Koha::Holds->waiting->search( { itemnumber => $item->id } ) 353: ->filter_by_has_cancellation_requests; 354: while ( my $hold = $waiting_holds_to_be_cancelled->next ) { -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #104 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #102)

I am sorry, but I get this error when trying to return an item with a hold on it:

Can't call method "id" on an undefined value at /kohadevbox/koha/circ/returns.pl line 351

349: # is there a waiting hold for the item, for which cancellation 350: # has been requested? 351: my $waiting_holds_to_be_cancelled = 352: Koha::Holds->waiting->search( { itemnumber => $item->id } ) 353: ->filter_by_has_cancellation_requests; 354: while ( my $hold = $waiting_holds_to_be_cancelled->next ) {

Sorry, I cannot reproduce. I tried with: - 3 item-level holds, for different patrons, on same item - 1 biblio-level hold - Doing a check-in for a not having item-level hold item on the biblio => SUCCESS: biblio-level hold trapped, offered to confirm. tried both confirming and discarding. The fact it breaks on $item->id is pointing me to something else: it means the item hasn't been found using the barcode. So... it must be something else on your branch that wasn't correctly rebased after this one got pushed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #106 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #105)

I'm marking this one as resolved now. Any further stuff related to it should be filed on a separate follow-up bug from now on.

Thanks!

Bumped into bugs caused by bug 22456 while testing bug 15516 so I've raised bug 31303. Critical severity since it causes the OPAC to crash in koha-testing-docker if the patron has waiting holds due to the "waiting_hold_cancellation" rule missing. Not sure how this passed QA, but I'll investigate and report back on bug 31303. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31303 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31303 [Bug 31303] Fatal error when viewing OPAC user account with waiting holds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31395 [Bug 31395] Checking in non-existent barcodes makes Koha explode -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/632 CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 [Bug 36064] Add Holds with cancellation requests info to intranet-main page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36174 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36174 [Bug 36174] Holds with cancellation requests tab display -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39820 [Bug 39820] Items with hold cancellation requests should have the hold cancelled when checked in via SIP -- You are receiving this mail because: You are watching all bug changes.