http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 22086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22086&action=edit Bug 11034: remove incorrect return for BiblioAutoLink BiblioAutoLink was being called expecting an array to be returned. The subroutine in fact returns a scalar As the variables that the return was stored in, went out of scope immediately. It is probably better to be explicit that we are throwing the return away by not going through the motions of storing it in a variable To test: [1] Add or save a bib record using the cataloging editor. [2] Verify that no regressions have occurred [3] (optional) If BiblioAddsAuthorities is on, verfiy that relevant authority records are linked to. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21944|0 |1 is obsolete| | Attachment #22086|0 |1 is obsolete| | --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 22087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22087&action=edit Bug 11034: remove incorrect return for BiblioAutoLink BiblioAutoLink was being called expecting an array to be returned. The subroutine in fact returns a scalar As the variables that the return was stored in, went out of scope immediately. It is probably better to be explicit that we are throwing the return away by not going through the motions of storing it in a variable To test: [1] Add or save a bib record using the cataloging editor. [2] Verify that no regressions have occurred [3] (optional) If BiblioAddsAuthorities is on, verify that relevant authority records are linked to from the bib. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22087|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22313&action=edit Bug 11034: remove incorrect return for BiblioAutoLink BiblioAutoLink was being called expecting an array to be returned. The subroutine in fact returns a scalar As the variables that the return was stored in, went out of scope immediately. It is probably better to be explicit that we are throwing the return away by not going through the motions of storing it in a variable To test: [1] Add or save a bib record using the cataloging editor. [2] Verify that no regressions have occurred [3] (optional) If BiblioAddsAuthorities is on, verify that relevant authority records are linked to from the bib. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes.