[Bug 34322] New: Correct icon triggering more fund search options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Bug ID: 34322 Summary: Correct icon triggering more fund search options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org On budget and fund pages the search header form has a folder icon which triggers the expansion of the library filter. On other pages we use "fa-sliders" to indicate that there are more search options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153719&action=edit Bug 34322: Correct icon triggering more fund search options This patch updates the budget/fund administration header search form so that it uses the "fa-slider" Font Awesome icon instead of a folder icon. This makes it consistent with other search forms which have a similar set of additional options. To test, apply the patch and go to Administration -> Budgets. - The "Search funds" form should have the "fa-sliders" icon. - Clicking it should trigger the expansion of the additional search options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34323 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 [Bug 34323] Enhance header search icon for more options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153719|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 153733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153733&action=edit Bug 34322: Correct icon triggering more fund search options This patch updates the budget/fund administration header search form so that it uses the "fa-slider" Font Awesome icon instead of a folder icon. This makes it consistent with other search forms which have a similar set of additional options. To test, apply the patch and go to Administration -> Budgets. - The "Search funds" form should have the "fa-sliders" icon. - Clicking it should trigger the expansion of the additional search options. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153733|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154055&action=edit Bug 34322: Correct icon triggering more fund search options This patch updates the budget/fund administration header search form so that it uses the "fa-slider" Font Awesome icon instead of a folder icon. This makes it consistent with other search forms which have a similar set of additional options. To test, apply the patch and go to Administration -> Budgets. - The "Search funds" form should have the "fa-sliders" icon. - Clicking it should trigger the expansion of the additional search options. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |32910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 [Bug 32910] Upgrade fontawesome icons to V6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 32910 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Bug 34322 depends on bug 32910, which changed state. Bug 32910 Summary: Upgrade fontawesome icons to V6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org