[Bug 34112] New: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 Bug ID: 34112 Summary: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com Depends on: 32910 When working on the upgrade FontAwesome to v.6 I mistakenly replaced "fa-edit" with "fa-pencil-alt". While this works, it's a carry-over from FontAwesome v.5 and may not continue to work. We should use <i class="fa-solid fa-pencil"></i> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 [Bug 32910] Upgrade fontawesome icons to V6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152639&action=edit Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons The FontAwesome class "fa-pencil-alt" works in v.6 but is actually a v.5 class. We should use "fa-solid fa-pencil" instead. This patch also corrects some leftover instances of "fa-edit" To test, apply the patch and view some pages in the OPAC and staff interface which have updated icons, e.g. - Administration -> Libraries - Catalog -> Bibliographic details - OPAC -> Bibliographic details Confirm that the pencil icon looks correct. Checking all modified templates is probably too much, but inspecting the patch should show that only fa-pencil-alt and fa-edit icons are affected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152639|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152652&action=edit Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons The FontAwesome class "fa-pencil-alt" works in v.6 but is actually a v.5 class. We should use "fa-solid fa-pencil" instead. This patch also corrects some leftover instances of "fa-edit" To test, apply the patch and view some pages in the OPAC and staff interface which have updated icons, e.g. - Administration -> Libraries - Catalog -> Bibliographic details - OPAC -> Bibliographic details Confirm that the pencil icon looks correct. Checking all modified templates is probably too much, but inspecting the patch should show that only fa-pencil-alt and fa-edit icons are affected. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152652|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153172&action=edit Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons The FontAwesome class "fa-pencil-alt" works in v.6 but is actually a v.5 class. We should use "fa-solid fa-pencil" instead. This patch also corrects some leftover instances of "fa-edit" To test, apply the patch and view some pages in the OPAC and staff interface which have updated icons, e.g. - Administration -> Libraries - Catalog -> Bibliographic details - OPAC -> Bibliographic details Confirm that the pencil icon looks correct. Checking all modified templates is probably too much, but inspecting the patch should show that only fa-pencil-alt and fa-edit icons are affected. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to master |RESOLVED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Fontawesome 6 not in 23.05.x series, no backport required here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 Bug 34112 depends on bug 32910, which changed state. Bug 32910 Summary: Upgrade fontawesome icons to V6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org