[Bug 7298] New: export late orders, with # of claims and claim dates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Bug #: 7298 Summary: export late orders, with # of claims and claim dates Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions AssignedTo: claire.hernandez@biblibre.com ReportedBy: claire.hernandez@biblibre.com QAContact: ian.walls@bywatersolutions.com Blocks: 7163 let the librarian export late order listing, and see how many claims have been made, as well as claim dates(BibLibre MT6844) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|claire.hernandez@biblibre.c |jonathan.druart@biblibre.co |om |m --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-22 16:27:53 UTC --- Created attachment 7809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7809 Bug 7298 Export late orders as csv Proposed patch In the lateorders.pl: this patch allow to export late orders as a csv file. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-23 11:58:54 UTC --- I am not so happy about the filename lateorders-excel.pl. Perhaps we could choose something more generic? export_lateorders perhaps? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-23 13:17:53 UTC --- Hi Katrin, I don't like this name neither, however a file named ' alserials/lateissues-excel.pl' already exists and have the same purpose :-/ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-23 13:47:18 UTC --- I think in this case I would vote against consistency and for a nicer file name. Perhaps someone else has an opinion on this? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #5 from Magnus Enger <magnus@enger.priv.no> 2012-02-23 14:02:40 UTC --- (In reply to comment #4)
I think in this case I would vote against consistency and for a nicer file name. Perhaps someone else has an opinion on this?
I agree with using something more generic! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2012-02-23 20:24:03 UTC --- If we are exporting it as csv not .xls why not lateissues-csv.pl ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-26 15:27:14 UTC --- Created attachment 7891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7891 CSV file contains no order data Hi Jonathan, while testing this I spotted a another problem, that might explain why my csv didn't have the data I expected it to have. When you forget to add an email address to the vendor there will be an error message, but it still saves a claim data and a claim count to the database. I think this should not happen. Problems I found: 1) I claimed 2 orders successfully, the table shows the count and the date. But when I mark them and click on export, there is no useful information in the csv file. (see attached screenshot) 2) Perhaps make the link a button 'Export as CSV' next to 'Claim orders'? Similar to the button for exporting CSV data on the basket page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-27 10:38:52 UTC --- Just a comment on the name: I agree with Magnus to use a more generic name. Why not something like late_orders_export? Note that someone in the future may add an option to your script that makes it export to csv as well as ... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-29 16:04:58 UTC --- Created attachment 7946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7946 Bug 7298 Followup rename export scripts renames export scripts And replaces the export lick with a new button. I rename acqui/lateorders-excel.pl and lateissues-excel.pl Katrin, Sorry but I can reproduce your bug. Could you debug in the lateorders-export.pl script into the @ordernumbers loop ? (print $ordernumber and $order) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #10 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- I have the same problem as Katrin in comment 7 : no data in the csv file (tested whith openoffice 3.1). Furthermore, in the biblibre sandbox 1, I tried to claim a late order (because the number and dates of claims might appear in the csv) and had this message : "No letter_code at /home/koha/src/acqui/lateorders.pl line 83" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Can you verify you are a "Claim acquisition" defined in yours letters ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |koha@univ-lyon3.fr --- Comment #12 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I have an error when I try "claim order" : "Software error: Can't use string ("1") as a HASH ref while "strict refs" in use at /home/koha/src/acqui/lateorders.pl line 91. For help, please send mail to the webmaster (webmaster@test4-sandbox), giving this error message and the time and date of the error. " I have a "Claim acquisition" defined in the letters.The csv file is quite empty. (cf. attachment) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #13 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 8333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8333&action=edit csv file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5356 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Blocked by Bug 5356 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7809|0 |1 is obsolete| | Attachment #7946|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10426&action=edit Bug 7298 Export late orders as csv -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #16 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11713&action=edit bottom row misaligned The function seems to work fine, but the moving of the checkboxes to the left has made it so that the bottom row is no longer lined up right. Also there is no need for 2 claim order buttons. These are minor design fixes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11717&action=edit Bug 7298: Followup, FIX table bottom -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Nicole, This followup fixes the 2 problems in the table bottom. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10426|0 |1 is obsolete| | --- Comment #19 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11721&action=edit [SIGNED-OFF] Bug 7298 Export late orders as csv Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11717|0 |1 is obsolete| | --- Comment #20 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11722&action=edit [SIGNED-OFF] Bug 7298: Followup, FIX table bottom Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment 1- bug signed-off since more than 1 month, dealing with QA myself 2- qa.pl script shows some errors, easy to solve (use COALESCE instead of IFNULL & use spaces for indent) 3- replaces a SQL query in GetOrder in an unsafe way imo: - add many table.* to an already very long query (was biblio+biblioitems+aqorders, and adds aqbudgets+aqbasket) Would be better not to use * (including biblioitems, that contains marcxml field !!! was already here before the patch, but if you can fix it...) - does some changes that look strange : why DATE(aqbasket.closedate) AS orderdate ? why aqorders.quantity - IFNULL(aqorders.quantityreceived,0) AS quantity -quantity is a field from aqorders ? 4- the form $$order{estimateddeliverydate} must be discarded in favor of $order->{estimateddeliverydate} Failing QA for #4, need info (and maybe fix) for #3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 12624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12624&action=edit Bug 7298 fixing 2 QA errors * replace IFNULL by COALESCE * replace 4 tabs by 4 "4 spaces" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12817&action=edit Bug 7298: Followup FIX the field list to return in GetOrder -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- I don't know if the list of field is good but grep says me I am good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12817|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12818&action=edit Bug 7298: Followup FIX the field list to return in GetOrder -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #26 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Tested on a VM. I think it does not work : I had 8 documents late, I created the csv, and here is its content : ORDER DATE ESTIMATED DELIVERY DATE VENDOR INFORMATION TOTAL COST BASKET CLAIMS COUNT CLAIMED DATE () ( days) x = () () () ( days) x = () () () ( days) x = () () () ( days) x = () () () ( days) x = () () () ( days) x = () () () ( days) x = () () () ( days) x = () () Total Number Late 8 M. Saby Rennes 2 university -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12624|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15027&action=edit Bug 7298 fixing 3 QA errors * replace IFNULL by COALESCE * replace 4 tabs by 4 "4 spaces" * replace a simple quote string -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12818|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15028&action=edit Bug 7298: Followup FIX the field list to return in GetOrder -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #26)
Tested on a VM. I think it does not work :
The last patch produced a mysql error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #30 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 15037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15037&action=edit [SIGNED-OFF] Bug 7298 Export late orders as csv Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #31 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 15038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15038&action=edit [SIGNED-OFF] Bug 7298: Followup, FIX table bottom Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #32 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 15039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15039&action=edit [SIGNED-OFF] Bug 7298 fixing 3 QA errors * replace IFNULL by COALESCE * replace 4 tabs by 4 "4 spaces" * replace a simple quote string Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #33 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 15040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15040&action=edit [SIGNED-OFF] Bug 7298: Followup FIX the field list to return in GetOrder Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #34 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- My first sign-off using git bz. I hope everything is ok... I signed off but maybe a little followup would be necessary : In the last line of the csv, there is two , before "Total Number Late". I am not sure it is normal. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #35 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Oh, I missed that point "Uncomment the # before each patch you would like to obsolete before saving." :( M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11721|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11722|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15027|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #34)
My first sign-off using git bz. I hope everything is ok...
I signed off but maybe a little followup would be necessary : In the last line of the csv, there is two , before "Total Number Late". I am not sure it is normal.
M. Saby
The last line of the CSV contains : "Total Number Late" in the third column and "x" (number of orders in the CSV) in the 4th column. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #37 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Yes. I thought it will be in column 1 and 2. But is a matter of taste, so I am fine with that... M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch QA Contact|koha.sekjal@gmail.com |paul.poulain@biblibre.com --- Comment #38 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * a tiny POD mistake, fixed in a follow-up * no other comments, work fine passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15037|0 |1 is obsolete| | Attachment #15038|0 |1 is obsolete| | Attachment #15039|0 |1 is obsolete| | Attachment #15040|0 |1 is obsolete| | --- Comment #39 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16688&action=edit [PASSED QA] Bug 7298 Export late orders as csv Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #40 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16689&action=edit [PASSED QA] Bug 7298: Followup, FIX table bottom Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #41 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16690&action=edit [PASSED QA] Bug 7298 fixing 3 QA errors * replace IFNULL by COALESCE * replace 4 tabs by 4 "4 spaces" * replace a simple quote string Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #42 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16691&action=edit [PASSED QA] Bug 7298: Followup FIX the field list to return in GetOrder Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #43 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16692&action=edit [PASSED QA] bug 7298 QA follow-up, fix POD Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #44 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I get a nasty error from this: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'o ORDER BY title' at line 12 at /home/jcamins/kohaclone/C4/Serials.pm line 1906. at /home/jcamins/kohaclone/serials/lateissues-export.pl line 134 The query that is generating is, sure enough, wrong: SELECT serialid, aqbooksellerid, name, biblio.title, planneddate, serialseq, serial.status, serial.subscriptionid, claimdate, subscription.branchcode FROM serial LEFT JOIN subscription ON serial.subscriptionid=subscription.subscriptionid LEFT JOIN biblio ON subscription.biblionumber=biblio.biblionumber LEFT JOIN aqbooksellers ON subscription.aqbooksellerid = aqbooksellers.id WHERE subscription.subscriptionid = serial.subscriptionid AND (serial.STATUS = 4 OR ((planneddate < now() AND serial.STATUS =1) OR serial.STATUS = 3 OR serial.STATUS = 7)) AND subscription.aqbooksellerid= and serialid = on ORDER BY title Also, there needs to be a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #45 from Jonathan Druart <jonathan.druart@biblibre.com> --- Jared, This development does not modify the export for serials. I just renamed the script in order to be consistent (mv /serials/lateissues-excel.pl /serials/lateissues-export.pl). So your issue certainly exists on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16688|0 |1 is obsolete| | Attachment #16689|0 |1 is obsolete| | Attachment #16690|0 |1 is obsolete| | Attachment #16691|0 |1 is obsolete| | Attachment #16692|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16956&action=edit Bug 7298 Export late orders as csv This patch allows to export late orders as csv. Test plan: - Go on the late orders page (acqui/lateorders.pl) - Select one or more order and click on the button "export as CSV". - The generated file should contains some information on the orders (order date, estimated delivery date, vendor name, information field, cost, basket name (and basketid), claims count and the claimed date) The last line of the file is the total of orders. - You are not allow to select order from different vendor. - The check/uncheck all links appears only if a vendor is selected. - Check that the check/uncheck works for all pages of the table. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #47 from Jonathan Druart <jonathan.druart@biblibre.com> --- The attachment 16956 is a rebased and squashed patch. I added a test plan. An issue is fixed: the user is not allow to select orders from different vendor. This behavior was broken by datatable. Switch back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #48 from Jonathan Druart <jonathan.druart@biblibre.com> --- Since this patch has 3 signoffs and I cannot recreate the issue described by Jared, I switch the status to Signed Off. The issue is not relevant, as I said, I don't affect the lateissues-export.pl script. I retested feature and it works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19819&action=edit Bug 7298: Follow-up fixing capitalization and moving supplier id Fixes a few capitalization errors on the late orders page like - Claim orders - filter - Search results Also moves the supplierid from the order date column to the vendor column. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I have tested this and it works fine. I have fixed some things in a follow up patch, but I think I can't pass this as it is. The CSV has lots of untranslatable strings while it seems we have found some solution for that problem for the CSV export of baskets and basket groups. Could you take a look there if if this can be adapted? Also I think it would be nicer to have the author and publisher in separate columns in the CSV, which would also remove some more translation problems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is also a bug in how the checkboxed get blocked so you can only select titles from one vendor. I have more than 10 late orders, when I load the late orders page, the checkboxes don't lock. When I change the number of late orders shown in the table, it starts to work - hope you can reproduce this. Also the late order emails are broken... filing a bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10618 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #52 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #50) Katrin, thank you for your patch! I will submit 2 patchs. 1 fixes the checkboxes issues, the other allow the translation for csv headers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19819|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20313&action=edit Bug 7298: Follow-up fixing capitalization and moving supplier id Fixes a few capitalization errors on the late orders page like - Claim orders - filter - Search results Also moves the supplierid from the order date column to the vendor column. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #54 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20314&action=edit Bug 7298: FIX checkboxes binding on load Click on checkboxes should be bound on load. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #55 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20315&action=edit Bug 7298: CSV strings are translatables. Using a template file, the CSV headers become translatable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #56 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello, I test this patch with a sandbox. Everything seems to work as define in the test plan. I try only with 3 orders. But, as katrin mentionned, in the csv file, the header wasn't translate in french... Can you verify before I change the status in "signed off" Sonia -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #57 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #56)
Hello, I test this patch with a sandbox. Everything seems to work as define in the test plan. I try only with 3 orders. But, as katrin mentionned, in the csv file, the header wasn't translate in french... Can you verify before I change the status in "signed off" Sonia
Hello Sonia, Headers are new strings, so they are not translatable on sandboxes without a manual modification of po files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #58 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by sonia <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #59 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 20471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20471&action=edit Bug 7298 Export late orders as csv This patch allows to export late orders as csv. Test plan: - Go on the late orders page (acqui/lateorders.pl) - Select one or more order and click on the button "export as CSV". - The generated file should contains some information on the orders (order date, estimated delivery date, vendor name, information field, cost, basket name (and basketid), claims count and the claimed date) The last line of the file is the total of orders. - You are not allow to select order from different vendor. - The check/uncheck all links appears only if a vendor is selected. - Check that the check/uncheck works for all pages of the table. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: sonia <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #60 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 20472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20472&action=edit Bug 7298: Follow-up fixing capitalization and moving supplier id Fixes a few capitalization errors on the late orders page like - Claim orders - filter - Search results Also moves the supplierid from the order date column to the vendor column. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: sonia <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #61 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 20473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20473&action=edit Bug 7298: FIX checkboxes binding on load Click on checkboxes should be bound on load. Signed-off-by: sonia <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #62 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 20474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20474&action=edit Bug 7298: CSV strings are translatables. Using a template file, the CSV headers become translatable. Signed-off-by: sonia <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #63 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello Jonathan. So for me everything works fine. I change in Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #64 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #63)
Hello Jonathan. So for me everything works fine. I change in Signed off.
Thanks for testing Sonia! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|paul.poulain@biblibre.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, the QA script points out some things, I would have fixed the tabs, but I think deciding about the license is up to you: FAIL serials/lateissues-export.pl OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 7) OK valid OK critic OK koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/lateorders.tt OK forbidden patterns OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt FAIL forbidden patterns forbidden pattern: tab char (line 220) OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: tab char (line 45) OK tt_valid OK valid_template Could you take a look? I will continue testing the functionality. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some additional notes from code review: - GetBasketGroupAsCSV could use some unit tests as the SQL statement has been altered quite a bit. - lateissues-export.pl could use Modern::Perl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10931 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #67 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, we are almost there - it works really nicely, but we got one bigger problems with translating the CSV. Posting my testing notes here: Testing notes: - CSV header row is now translatable. Tested by updating the German po files and checking for the line. - Tested that claiming for late serial issues still works as expected, as one file has been renamed. Filed 10931 for untranslatable CSV contents. - Tested that claiming late orders still works: * Table searching and sorting Works nicely, but some columns could be split up for better searching and sorting: * Order date: 20/01/2013 (245 days) * Total cost: 10.00x1 = 10.00 Books => item type should be separate * Basket: 10 MPL => Library and basket number could be separate columns * Filters * Combined various filters, search results look correct. * Selecting order for claiming * Limiting by vendor makes it possible to check/uncheck all * With no vendor limit, entries for other vendors will be locked after the first checkbox is checked for one vendor * Exporting as CSV * Exported single line > CSV appears correct. * Exporting multiple lines > CSV appears correct. PROBLEM: Translated CSV don't work correctly, as line breaks are lost in the translation process. * Sending serial claim email * No regressions found - there are some problems with the email contents noted on bug 7298. In order to reproduce the problem with translated CSV files make sure you test with updated po files containing a translated version of the header row or a copy of it. I think we already ran into this problem with the templates for the cart email, which are plain text and not HTML. Not sure how to solve this, but currently it seems not to work for translated templates at all as you will get all data on one single line. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #68 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21339&action=edit Bug 7298: QA Followup - use Modern::Perl; - GPL version - tabs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #69 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #65)
Hi Jonathan, Hi Katrin,
[...] Could you take a look? I will continue testing the functionality.
Will be fixed. (In reply to Katrin Fischer from comment #66)
Some additional notes from code review: - GetBasketGroupAsCSV could use some unit tests as the SQL statement has been altered quite a bit.
The modified routine is GetOrder. It already has a unit test (not really good but exists).
- lateissues-export.pl could use Modern::Perl Will be done.
(In reply to Katrin Fischer from comment #67)
Hi Jonathan, * Exporting as CSV * Exported single line > CSV appears correct. * Exporting multiple lines > CSV appears correct. PROBLEM: Translated CSV don't work correctly, as line breaks are lost in the translation process.
* Sending serial claim email * No regressions found - there are some problems with the email contents noted on bug 7298.
We are on bug 7298 :)
In order to reproduce the problem with translated CSV files make sure you test with updated po files containing a translated version of the header row or a copy of it. I think we already ran into this problem with the templates for the cart email, which are plain text and not HTML. Not sure how to solve this, but currently it seems not to work for translated templates at all as you will get all data on one single line.
I will have a look at bug 10931. But the problem does not occur for others csv export (basket and basketgroup)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
(In reply to Katrin Fischer from comment #67)
Hi Jonathan, * Exporting as CSV * Exported single line > CSV appears correct. * Exporting multiple lines > CSV appears correct. PROBLEM: Translated CSV don't work correctly, as line breaks are lost in the translation process.
* Sending serial claim email * No regressions found - there are some problems with the email contents noted on bug 7298.
We are on bug 7298 :)
Bug 10618 - sorry. And was not failing the bug for this - just thought it would be worth noting.
I will have a look at bug 10931. But the problem does not occur for others csv export (basket and basketgroup)?
I didn't have time to check - sorry. But I assume it will happen everywhere where we try to translate plain text (not HTML) with the translation scripts and line breaks are essential for functionality. Maybe we need to have it 'non translatable' for now, but i would prefer a different solution. We found a fix for the cart mails, but it's a bit ugly. The template is HTML and then we strip the tags out (iirc). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #71 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, this is all good, but I think we still need to fix the translated CSV for exportig late orders? Serials CSV will be fixed by the new feature (hopefully) and there is bug 10935 for baskets and basketgroups which I will test next. I will go ahead and attach my tested patches here but not switch the status to passed QA until I have a follow-up for fixing the translations :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20471|0 |1 is obsolete| | Attachment #20472|0 |1 is obsolete| | Attachment #20473|0 |1 is obsolete| | Attachment #20474|0 |1 is obsolete| | Attachment #21339|0 |1 is obsolete| | --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21383&action=edit [PASSED QA] Bug 7298 Export late orders as csv This patch allows to export late orders as csv. Test plan: - Go on the late orders page (acqui/lateorders.pl) - Select one or more order and click on the button "export as CSV". - The generated file should contains some information on the orders (order date, estimated delivery date, vendor name, information field, cost, basket name (and basketid), claims count and the claimed date) The last line of the file is the total of orders. - You are not allow to select order from different vendor. - The check/uncheck all links appears only if a vendor is selected. - Check that the check/uncheck works for all pages of the table. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing comments on last patch in this series. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21384&action=edit [PASSED QA] Bug 7298: Follow-up fixing capitalization and moving supplier id Fixes a few capitalization errors on the late orders page like - Claim orders - filter - Search results Also moves the supplierid from the order date column to the vendor column. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21385&action=edit [PASSED QA] Bug 7298: FIX checkboxes binding on load Click on checkboxes should be bound on load. Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21386&action=edit [PASSED QA] Bug 7298: CSV strings are translatables. Using a template file, the CSV headers become translatable. Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21387&action=edit [PASSED QA] Bug 7298: QA Followup - use Modern::Perl; - GPL version - tabs Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and all tests. Testing notes: - CSV header row is now translatable. Tested by updating the German po files and checking for the line. - Tested that claiming for late serial issues still works as expected, as one file has been renamed. Filed 10931 for untranslatable CSV contents. - Tested that claiming late orders still works: * Table searching and sorting Works nicely, but some columns could be split up for better searching and sorting: * Order date: 20/01/2013 (245 days) * Total cost: 10.00x1 = 10.00 Books => item type should be separate * Basket: 10 MPL => Library and basket number could be separate columns * Filters * Combined various filters, search results look correct. * Selecting order for claiming * Limiting by vendor makes it possible to check/uncheck all * With no vendor limit, entries for other vendors will be locked after the first checkbox is checked for one vendor * Exporting as CSV * Exported single line > CSV appears correct. * Exporting multiple lines > CSV appears correct. PROBLEM: Translated CSV don't work correctly, as line breaks are lost in the translation process. Needs to be fixed in a follow-up. * Sending serial claim email * No regressions found - there are some problems with the email contents noted on bug 7298. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested bug 10935 and added a follow-up - please take a look and provide a follow up :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10935 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #78 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21398&action=edit Bug 7298: Followup: CSV strings are translatables. Following the same way as bug 10935, the headers are in an include file. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21398|0 |1 is obsolete| | --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21523&action=edit [PASSED QA] Bug 7298: Followup: CSV strings are translatables. Following the same way as bug 10935, the headers are in an include file. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Translatability tested successfully. Passes all tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This has taken a while... thx Jonathan for your patience! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #82 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #81)
This has taken a while... thx Jonathan for your patience!
Thanks for your patience too :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11027 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |gmcharlt@gmail.com --- Comment #83 from Galen Charlton <gmcharlt@gmail.com> --- Patch doesn't apply on account of the renaming of the serial claims export script -- tossing back for the patch submitter to rebase. Feel free to set back to passed QA afterwards so that I can try to make this in before the string freeze window closes. General note for the future -- it would have been better if the patch for renaming the existing script had stayed separate; in fact, that kind of refactoring should have been a separate bug since the name of the serials claim export script has no direct bearing on the functionality of the feature proposed here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21383|0 |1 is obsolete| | Attachment #21384|0 |1 is obsolete| | Attachment #21385|0 |1 is obsolete| | Attachment #21386|0 |1 is obsolete| | Attachment #21387|0 |1 is obsolete| | Attachment #21523|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22617&action=edit Bug 7298 Export late orders as csv This patch allows to export late orders as csv. Test plan: - Go on the late orders page (acqui/lateorders.pl) - Select one or more order and click on the button "export as CSV". - The generated file should contains some information on the orders (order date, estimated delivery date, vendor name, information field, cost, basket name (and basketid), claims count and the claimed date) The last line of the file is the total of orders. - You are not allow to select order from different vendor. - The check/uncheck all links appears only if a vendor is selected. - Check that the check/uncheck works for all pages of the table. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing comments on last patch in this series. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #85 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22618&action=edit Bug 7298: Follow-up fixing capitalization and moving supplier id Fixes a few capitalization errors on the late orders page like - Claim orders - filter - Search results Also moves the supplierid from the order date column to the vendor column. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #86 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22619&action=edit Bug 7298: FIX checkboxes binding on load Click on checkboxes should be bound on load. Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #87 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22620&action=edit Bug 7298: CSV strings are translatables. Using a template file, the CSV headers become translatable. Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #88 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22621&action=edit Bug 7298: QA Followup - use Modern::Perl; - GPL version - tabs Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and all tests. Testing notes: - CSV header row is now translatable. Tested by updating the German po files and checking for the line. - Tested that claiming for late serial issues still works as expected, as one file has been renamed. Filed 10931 for untranslatable CSV contents. - Tested that claiming late orders still works: * Table searching and sorting Works nicely, but some columns could be split up for better searching and sorting: * Order date: 20/01/2013 (245 days) * Total cost: 10.00x1 = 10.00 Books => item type should be separate * Basket: 10 MPL => Library and basket number could be separate columns * Filters * Combined various filters, search results look correct. * Selecting order for claiming * Limiting by vendor makes it possible to check/uncheck all * With no vendor limit, entries for other vendors will be locked after the first checkbox is checked for one vendor * Exporting as CSV * Exported single line > CSV appears correct. * Exporting multiple lines > CSV appears correct. PROBLEM: Translated CSV don't work correctly, as line breaks are lost in the translation process. Needs to be fixed in a follow-up. * Sending serial claim email * No regressions found - there are some problems with the email contents noted on bug 7298. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #89 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22622&action=edit Bug 7298: Followup: CSV strings are translatables. Following the same way as bug 10935, the headers are in an include file. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Translatability tested successfully. Passes all tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #90 from Jonathan Druart <jonathan.druart@biblibre.com> --- Galen, All patches rebased. The serial claims export does not work, see bug 11168. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #91 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #92 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hi Jonathan I am trying to resolve conflict on Bug 10758, so I came to the changes introduced in GetOrder by commit fd2c751a86fad7a388c57fcd51746dbc4592c807 (the main patch for bug 7298) Don't you think the resulting routine could be make simpler ? I don't see the use for: aqorders.claims_count AS claims_count, aqorders.claimed_date AS claimed_date, For aqorders.rrp AS unitpricesupplier, aqorders.ecost AS unitpricelib, and biblioitems.publishercode AS publisher aqbudgets.budget_name AS budget, Are these renaming really needed? Are they made for avoiding confusion somewhere in code? By the way, I was trying to factorize some UT in Acquisition.t (not yet done), and one of my assumptions was that the fields returned by GetOrder were the same as each orders of GetOrderS and GetCancelledOrders. It was working, but of course it is no more the case. So I'm wondering if the fields added in the hashe returned by GetOrder could be usefull too in GetOrderS and GetCancelledOrders. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #93 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to mathieu saby from comment #92)
Are these renaming really needed? Are they made for avoiding confusion somewhere in code?
I wrote this patch 18 months ago, so I don't know why I renamed these fields. Certainly I preferred to use "unitpricesupplier" rather than "rrp". But "unitpricelib" is not a good choice... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11027 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14264 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org