[Bug 42017] New: Fix content type of OPAC news RSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 Bug ID: 42017 Summary: Fix content type of OPAC news RSS Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 7843 I noticed that in Firefox, the default XML viewer isn't triggered when I view the OPAC news RSS feed. That seems to be because opac-news-rss.pl uses output_html_with_http_headers instead of output_with_http_headers. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 [Bug 7843] Add RSS feeds for OPAC news -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 194904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194904&action=edit Bug 42017: Fix content type of OPAC news RSS This patch updates opac-news-rss.pl so that it outputs data with the correct content type, text/xml. To reproduce you must have at least one news item in your system. From the OPAC main page, click the RSS feed link. - If you are using Firefox or Chrome you will see unstyled plain test on the screen. You may or may not be able to see the problem if your browser (e.g. Vivaldi) has a built-in RSS reader. To test, apply the patch and restart services. - In the OPAC, from the main page, click the RSS feed link at the bottom of the OPAC news list. - You should see the XML view of the feed. This confirms that the browser is receiving the correct content type. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194904|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 194906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194906&action=edit Bug 42017: Fix content type of OPAC news RSS This patch updates opac-news-rss.pl so that it outputs data with the correct content type, text/xml. To reproduce you must have at least one news item in your system. From the OPAC main page, click the RSS feed link. - If you are using Firefox or Chrome you will see unstyled plain test on the screen. You may or may not be able to see the problem if your browser (e.g. Vivaldi) has a built-in RSS reader. To test, apply the patch and restart services. - In the OPAC, from the main page, click the RSS feed link at the bottom of the OPAC news list. - You should see the XML view of the feed. This confirms that the browser is receiving the correct content type. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|Signed Off |Passed QA Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196268&action=edit Bug 42017: Fix content type of OPAC news RSS This patch updates opac-news-rss.pl so that it outputs data with the correct content type, text/xml. To reproduce you must have at least one news item in your system. From the OPAC main page, click the RSS feed link. - If you are using Firefox or Chrome you will see unstyled plain test on the screen. You may or may not be able to see the problem if your browser (e.g. Vivaldi) has a built-in RSS reader. To test, apply the patch and restart services. - In the OPAC, from the main page, click the RSS feed link at the bottom of the OPAC news list. - You should see the XML view of the feed. This confirms that the browser is receiving the correct content type. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42017 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org