[Bug 42103] New: Spelling: marc record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 Bug ID: 42103 Summary: Spelling: marc record Initiative type: --- Sponsorship --- status: Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com Found while translating: Koha/Database/DataInconsistency.pm:262 Biblionumber {biblionumber} has item fields ({item_tag}) in the marc record MARC is an acronym and should be capitalized. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main Keywords| |Academy Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Component|I18N/L10N |Templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also: koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc:624 Manage marc modification templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 --- Comment #2 from Simon M <simonmulligan@live.co.uk> --- Created attachment 197781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197781&action=edit Bug 42103: Capitalize MARC acronym in templates and DataInconsistency Patch from commit ae4d85e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |andrew.auld@openfifth.co.uk Assignee|oleonard@myacpl.org |simonmulligan@live.co.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198075&action=edit Bug 42103: Capitalize MARC acronym in templates and DataInconsistency Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198075|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 198197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198197&action=edit Bug 42103: Capitalize MARC acronym in templates and DataInconsistency This fixes the spelling of "marc" in two places: - an error message from running the database audit - the description for the marc_modification_templates permission Test plan: 1. The easiest way to test this change is to check the diff for the patch and note that "marc" is changed to "MARC" in two places. 2. Database audit output (More > About Koha > Database audit): - Check the diff (otherwise would need to alter the database structure somehow so that the audit would generate the error message). 3. Check the description for the marc_modification_templates permission: - Go to any patron record - Select More > Set permissions - In the filter, enter: marc modification - Note that the description is: Manage marc modification templates (marc_modification_templates) 4. Apply the patch. 5. Repeat step 3 and note that the description is now: Manage MARC modification templates (marc_modification_templates) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the spelling of release notes| |"marc" (marc to MARC) in | |two places: | |- an error message in the | |database audit (More > | |About Koha > Database | |audit) | |- the description for the | |marc_modification_templates | |permission QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Simon! Although this is a straightforward string change, I added a description and test plan to the commit message (see the commit message guidelines - https://wiki.koha-community.org/wiki/Commit_messages), and added a release note. If you'd like your full name to show in the release notes and the timeline as a new Koha developer (More > About Koha > Timeline), let me know and I'll amend the patch. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- prove -v /kohadevbox/koha/t/db_dependent/Koha/Database/DataInconsistency.t # Subtest: item_fields_in_marc 1..1 not ok 1 # Failed test at /kohadevbox/koha/t/db_dependent/Koha/Database/DataInconsistency.t line 349. # Structures begin differing at: # $got->[0] = 'Biblionumber 905 has item fields (952) in the MARC record' # $expected->[0] = 'Biblionumber 905 has item fields (952) in the marc record' # Looks like you failed 1 test of 1. not ok 3 - item_fields_in_marc # Failed test 'item_fields_in_marc' # at /kohadevbox/koha/t/db_dependent/Koha/Database/DataInconsistency.t line 353. # Subtest: decoding_errors 1..2 ok 1 ok 2 ok 4 - decoding_errors # Looks like you failed 1 test of 4. not ok 4 - errors_in_marc # Failed test 'errors_in_marc' # at /kohadevbox/koha/t/db_dependent/Koha/Database/DataInconsistency.t line 371. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 198667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198667&action=edit Bug 42103: (follow-up) Fix failing test Patch from commit 99001cd -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42103 --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org