[Bug 42012] New: e.preventDefault not called in clubs.tt club_hold_search handler
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Bug ID: 42012 Summary: e.preventDefault not called in clubs.tt club_hold_search handler Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org In clubs/clubs.tt, the .club_hold_search click handler uses e.preventDefault instead of e.preventDefault(). This was probably a typo or similar in Bug 24393. This references the method without calling it, so the default anchor action is never prevented. Since the element is an <a href="#">, clicking "Search to hold" causes the page to scroll to the top. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194689&action=edit Bug 42012: Fix missing preventDefault() call in clubs.tt - e.preventDefault was missing parentheses, so the default action was never actually prevented - The element is an <a href="#"> link, so clicking it would cause the page to scroll to top -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |paul.derscheid@lmscloud.de QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393 [Bug 24393] Remove event attributes from patron clubs list template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42116 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194689|0 |1 is obsolete| | --- Comment #2 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 195599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195599&action=edit Bug 42012: Fix missing preventDefault() call in clubs.tt e.preventDefault was missing parentheses, so the default action was not prevented. The element is an <a href="#"> link, so clicking it causes the page to scroll to top To test: - On Staff side, go to Tools > Patron Clubs - Create a Club Template, only name is needed - Create a Club, only name is needed - Go to a Patron's Check out page > Clubs > **Enroll** in the club - Back on Tools > Clubs use the Actions menu to "Search to hold" - The page scrolls to the top before redirecting - Apply patch - Repeat "Search to hold" - Page does not scroll anymore but still redirects Signed-Off-By: Eric Phetteplace <ephetteplace@cca.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195599|0 |1 is obsolete| | --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 195601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195601&action=edit Bug 42012: Fix missing preventDefault() call in clubs.tt e.preventDefault was missing parentheses, so the default action was not prevented. The element is an <a href="#"> link, so clicking it causes the page to scroll to top To test: - On Staff side, go to Tools > Patron Clubs - Create a Club Template, only name is needed - Create a Club, only name is needed - Go to a Patron's Check out page > Clubs > **Enroll** in the club - Back on Tools > Clubs use the Actions menu to "Search to hold" - The page scrolls to the top before redirecting - Apply patch - Repeat "Search to hold" - Page does not scroll anymore but still redirects Signed-Off-By: Eric Phetteplace <ephetteplace@cca.edu> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42012 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org