[Bug 16786] New: No longer to add multiple emails addresses in an email field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Bug ID: 16786 Summary: No longer to add multiple emails addresses in an email field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Previous to Koha 3.22, it was possible to enter multiple comma separated email addresses in a patron's email field. This allowed a patron to opt to receive a copy of any given email in more than one address! Now the email validation disallows this, but there is no technical reason to disallow it as far as I am aware. The email validator should be updated to supported multiple comma separated email addresses in any given email field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 BASE Library Consortium <baselibrary.consortium@nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baselibrary.consortium@nhs. | |net --- Comment #1 from BASE Library Consortium <baselibrary.consortium@nhs.net> --- Our library teams used to have this functionality on a previous LMS and would like to see this enhancement. Test case on BibLibre Koha sandbox 04 (17.06) when adding more than one valid email address in the email, emailpro or B_email and separating using a comma, space or semicolon, the error message reads: Please enter a valid email address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9815 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No longer to add multiple |Cannot add multiple emails |emails addresses in an |addresses in an email field |email field | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jeremy.breuillard@biblibre. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 --- Comment #2 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 137270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137270&action=edit Bug 16786: Cannot add multiple emails adresses in an email field The primary email field can allow more than one email adresses if those are separated by comma (,;) Test plan: 1) Home > Patrons 2) Create a new patron / Edit an existing patron 3) Part:'Contact information' > Field:'Primary email' : write at least 2 email adresses separated by comma 4) Try to save it... impossible 5) Apply patch and repeat 1) to 3) then save again 6) Now this field allows more than one email adress as long as there is comma separation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137270|0 |1 is obsolete| | --- Comment #3 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 137274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137274&action=edit Bug 16786: Cannot add multiple emails adresses in an email field The primary email field can allow more than one email adresses if those are separated by comma (,;) Test plan: 1) Home > Patrons 2) Create a new patron / Edit an existing patron 3) Part:'Contact information' > Field:'Primary email' : write at least 2 email adresses separated by comma 4) Try to save it... impossible 5) Apply patch and repeat 1) to 3) then save again 6) Now this field allows more than one email adress as long as there is comma separation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137274|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137275&action=edit Bug 16786: Cannot add multiple emails adresses in an email field The primary email field can allow more than one email adresses if those are separated by comma (,;) Test plan: 1) Home > Patrons 2) Create a new patron / Edit an existing patron 3) Part:'Contact information' > Field:'Primary email' : write at least 2 email adresses separated by comma 4) Try to save it... impossible 5) Apply patch and repeat 1) to 3) then save again 6) Now this field allows more than one email adress as long as there is comma separation Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm pretty sure the change to validator-strings.inc isn't necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #5)
I'm pretty sure the change to validator-strings.inc isn't necessary.
You beat me to it! Will re-sign the new patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137275|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137276&action=edit Bug 16786: Cannot add multiple emails adresses in an email field The primary email field can allow more than one email adresses if those are separated by comma (,;) Test plan: 1) Home > Patrons 2) Create a new patron / Edit an existing patron 3) Part:'Contact information' > Field:'Primary email' : write at least 2 email adresses separated by comma 4) Try to save it... impossible 5) Apply patch and repeat 1) to 3) then save again 6) Now this field allows more than one email adress as long as there is comma separation Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jeremy.breuillard@biblibre. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 --- Comment #8 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- (In reply to Kyle M Hall from comment #6)
(In reply to Kyle M Hall from comment #5)
I'm pretty sure the change to validator-strings.inc isn't necessary.
You beat me to it! Will re-sign the new patch!
=D ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- It's an interesting idea, although it could cause SSO problems, if the email field is a match point. Trying to think of other functionality that expects there to be a single value that can be checked using SQL operations without application-specific logic (ie breaking apart of the email addresses)... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12802 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- See also bug 12802. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ich Have a look at Koha::Email->is_valid : https://git.koha-community.org/Koha-community/Koha/src/commit/1f098a8c866fec... Looks like is does not allows actually several addresses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried applying the patch and Primary email in a patron file still prevents me from entering two email addresses separated by a comma. I tried both in a sandbox and on my local installation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31376 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 --- Comment #13 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- I see the problem. The other way is to do 1 email = 1 field and so on ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jérémy Breuillard from comment #13)
I see the problem. The other way is to do 1 email = 1 field and so on ?
Aware of bug 12802? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Bug 12802 is now integrated since 25.05 We may close this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org