https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73545&action=edit Bug 20510: Remove unused sub TotalPaid from C4::Stats Test plan: 0) Do not apply the patch 1) Run git grep TotalPaid and confirm it is only defined and then used once in a test 2) Apply the patch 3) git grep TotalPaid should return nothing 4) prove t/db_dependent/Stats.t should be green -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20225 |18643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20225 [Bug 20225] Remove unused script reports/stats.print.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Went back to 3.22.x to see what used it. git log -- reports/ hunted for the stats.print and stats.screen. Added dependencies which have already been pushed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73545|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73653&action=edit Bug 20510: Remove unused sub TotalPaid from C4::Stats Test plan: 0) Do not apply the patch 1) Run git grep TotalPaid and confirm it is only defined and then used once in a test 2) Apply the patch 3) git grep TotalPaid should return nothing 4) prove t/db_dependent/Stats.t should be green Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73653|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73671&action=edit Bug 20510: Remove unused sub TotalPaid from C4::Stats Test plan: 0) Do not apply the patch 1) Run git grep TotalPaid and confirm it is only defined and then used once in a test 2) Apply the patch 3) git grep TotalPaid should return nothing 4) prove t/db_dependent/Stats.t should be green Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.