[Bug 19097] New: Koha to MARC mappings Part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Bug ID: 19097 Summary: Koha to MARC mappings Part 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10306 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19096 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 [Bug 19096] Koha to MARC mappings Part 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Summary|Koha to MARC mappings Part |Koha to MARC mappings (Part |3 |3): Correct remaining | |GetMarcFromKohaField and | |TransformMarcToKoha calls --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- After bug 19096, we will need some cleanup. This patch set does only remove obsoleted parameters, so essentially it is a no-op. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving this QA comment on bug 19096 about sub GetMarcFromKohaField here also: return wantarray ? @retval : ( @retval ? $retval[0] : undef ); This is not necessary, do not do that please. Caller can do my ( $v ) = the_sub(); Not blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Bug 19097 depends on bug 19096, which changed state. Bug 19096 Summary: Koha to MARC mappings (Part 2): Make Default authoritative https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 [Bug 22721] Normalize GetMarcFromKohaField calls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Bug 19097 depends on bug 22721, which changed state. Bug 22721 Summary: Normalize GetMarcFromKohaField calls https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks like bug 30813 did most of the work now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #3)
Looks like bug 30813 did most of the work now.
But not all. Will make it more concrete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #4)
(In reply to Marcel de Rooy from comment #3)
Looks like bug 30813 did most of the work now.
But not all. Will make it more concrete.
? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 158063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158063&action=edit Bug 19097: GetMarcSubfieldStructureFromKohaField - remove wantarray Replacing wantarray by a list parameter. Adding comment to calls where simply one return is assumed. Test plan: Look at results of git grep GetMarcSubfieldStructureFromKohaField Run t/db_dependent/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #5)
(In reply to Marcel de Rooy from comment #4)
(In reply to Marcel de Rooy from comment #3)
Looks like bug 30813 did most of the work now.
But not all. Will make it more concrete.
?
First patch addresses sub GetMarcSubfieldStructureFromKohaField. Still another follow-up needed for GetMarcFromKohaField. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 158231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158231&action=edit Bug 19097: Remove wantarray from GetMarcSubfieldStructureFromKohaField Replacing wantarray by always returning all mappings. In a few cases only we expect multiple ones. Changing two calls to pick the first hit, and add comment about the implicit assumption being made (as before, no behavior change). Test plan: Look at results of git grep GetMarcSubfieldStructureFromKohaField Run t/db_dependent/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 158232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158232&action=edit Bug 19097: Remove wantarray from GetMarcFromKohaField The routine should be called in list context now. Warns also about use of obsoleted framework parameter. This is the case for several years already btw. But may help us catch a forgotten occurrence? Can be removed later. In a follow-up we will check for second parameters and we will update calls in scalar context. Test plan: Prove t/db_dependent/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 158233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158233&action=edit Bug 19097: Adjust some GetMarcFromKohaField calls We need to: [1] Remove obsolete framework parameters if any (yes there are). [2] Check scalar context calls if any (most probably not). Ad 1: How to find them? Git grep and look at each hit. You will need the -C parameter to add a few context lines around the call even. Found one in C4/Biblio.pm and six in Suggestions.t with ''. Found one in C4/Items on a second line. Similar one in Koha/EDI. Note: sub receipt_items in EDI has no unit tests yet. Also did a few git searches like: git grep GetMarcFromKohaField | grep -v -P "GetMarcFromKohaField.*;"| grep -P "GetMarcFromKohaField\s*\(" Note: Seeing still three lines; they are all fine. Last line comes from testing to trigger the warn. Ad 2: Have been looking at each git grep line and did not spot any scalar context call. Before this report, we had an example in POD and the Biblio test only. Try to find them by performing smarter git searches? Did look again at results for: git grep GetMarcFromKohaField | grep -v -P "\)\s*=\s*&?(C4::Biblio::)?GetMarcFromKohaField" | grep -v -P "use " The tests from this grep are included in the last test plan line. Test plan: Read the patch. Run t/db_dependent/Biblio/TransformHtmlToMarc.t Run t/db_dependent/Items.t Run t/db_dependent/Suggestions.t Run prove t/Biblio2.t t/db_dependent/Biblio.t t/db_dependent/Filter_MARC_ViewPolicy.t t/db_dependent/Koha/Authorities.t t/db_dependent/Koha/Biblio/Metadata.t t/db_dependent/Koha/Filter/EmbedItemsAvailability.t t/db_dependent/Koha/SearchEngine/Search.t t/db_dependent/XISBN.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158063|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha to MARC mappings (Part |Koha to MARC mappings (Part |3): Correct remaining |3): Correct remaining |GetMarcFromKohaField and |GetMarcFromKohaField calls |TransformMarcToKoha calls | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158231|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158246&action=edit Bug 19097: Remove wantarray from GetMarcSubfieldStructureFromKohaField Replacing wantarray by always returning all mappings. In a few cases only we expect multiple ones. Changing two calls to pick the first hit, and add comment about the implicit assumption being made (as before, no behavior change). Test plan: Look at results of git grep GetMarcSubfieldStructureFromKohaField Run t/db_dependent/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158232|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158247&action=edit Bug 19097: Remove wantarray from GetMarcFromKohaField The routine should be called in list context now. Warns also about use of obsoleted framework parameter. This is the case for several years already btw. But may help us catch a forgotten occurrence? Can be removed later. In a follow-up we will check for second parameters and we will update calls in scalar context. Test plan: Prove t/db_dependent/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158233|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158248&action=edit Bug 19097: Adjust some GetMarcFromKohaField calls We need to: [1] Remove obsolete framework parameters if any (yes there are). [2] Check scalar context calls if any (most probably not). Ad 1: How to find them? Git grep and look at each hit. You will need the -C parameter to add a few context lines around the call even. Found one in C4/Biblio.pm and six in Suggestions.t with ''. Found one in C4/Items on a second line. Similar one in Koha/EDI. Note: sub receipt_items in EDI has no unit tests yet. Also did a few git searches like: git grep GetMarcFromKohaField | grep -v -P "GetMarcFromKohaField.*;"| grep -P "GetMarcFromKohaField\s*\(" Note: Seeing still three lines; they are all fine. Last line comes from testing to trigger the warn. Ad 2: Have been looking at each git grep line and did not spot any scalar context call. Before this report, we had an example in POD and the Biblio test only. Try to find them by performing smarter git searches? Did look again at results for: git grep GetMarcFromKohaField | grep -v -P "\)\s*=\s*&?(C4::Biblio::)?GetMarcFromKohaField" | grep -v -P "use " The tests from this grep are included in the last test plan line. Test plan: Read the patch. Run t/db_dependent/Biblio/TransformHtmlToMarc.t Run t/db_dependent/Items.t Run t/db_dependent/Suggestions.t Run prove t/Biblio2.t t/db_dependent/Biblio.t t/db_dependent/Filter_MARC_ViewPolicy.t t/db_dependent/Koha/Authorities.t t/db_dependent/Koha/Biblio/Metadata.t t/db_dependent/Koha/Filter/EmbedItemsAvailability.t t/db_dependent/Koha/SearchEngine/Search.t t/db_dependent/XISBN.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158249&action=edit Bug 19097: (follow-up) Fix typo 'altough' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thx Nick. All tough :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Signed Off |Failed QA --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- /kohadevbox/koha/t/db_dependent/Biblio.t .. 2/20 # Failed test 'We expect two hits' # at /kohadevbox/koha/t/db_dependent/Biblio.t line 127. # got: '1' # expected: '2' # Failed test 'Testing a random column for existence in 2nd hash' # at /kohadevbox/koha/t/db_dependent/Biblio.t line 129. # Looks like you failed 2 tests of 27. # Failed test 'GetMarcSubfieldStructureFromKohaField' # at /kohadevbox/koha/t/db_dependent/Biblio.t line 135. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #16)
/kohadevbox/koha/t/db_dependent/Biblio.t .. 2/20 # Failed test 'We expect two hits' # at /kohadevbox/koha/t/db_dependent/Biblio.t line 127. # got: '1' # expected: '2'
# Failed test 'Testing a random column for existence in 2nd hash' # at /kohadevbox/koha/t/db_dependent/Biblio.t line 129. # Looks like you failed 2 tests of 27.
# Failed test 'GetMarcSubfieldStructureFromKohaField' # at /kohadevbox/koha/t/db_dependent/Biblio.t line 135.
Hmm. Passes with me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #17)
(In reply to Jonathan Druart from comment #16)
/kohadevbox/koha/t/db_dependent/Biblio.t .. 2/20 # Failed test 'We expect two hits' # at /kohadevbox/koha/t/db_dependent/Biblio.t line 127. # got: '1' # expected: '2'
# Failed test 'Testing a random column for existence in 2nd hash' # at /kohadevbox/koha/t/db_dependent/Biblio.t line 129. # Looks like you failed 2 tests of 27.
# Failed test 'GetMarcSubfieldStructureFromKohaField' # at /kohadevbox/koha/t/db_dependent/Biblio.t line 135.
Hmm. Passes with me.
This test assumes multiple mappings for kohafield biblio.copyrightdate (in 260, 264) as present in default install. Could you check your data? Obviously, the test could add them too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hum indeed, it passes after a reset_all. Weird I have not played with the mapping this morning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158246|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165103&action=edit Bug 19097: Remove wantarray from GetMarcSubfieldStructureFromKohaField Replacing wantarray by always returning all mappings. In a few cases only we expect multiple ones. Changing two calls to pick the first hit, and add comment about the implicit assumption being made (as before, no behavior change). Test plan: Look at results of git grep GetMarcSubfieldStructureFromKohaField Run t/db_dependent/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158247|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165104&action=edit Bug 19097: Remove wantarray from GetMarcFromKohaField The routine should be called in list context now. Warns also about use of obsoleted framework parameter. This is the case for several years already btw. But may help us catch a forgotten occurrence? Can be removed later. In a follow-up we will check for second parameters and we will update calls in scalar context. Test plan: Prove t/db_dependent/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158248|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165105&action=edit Bug 19097: Adjust some GetMarcFromKohaField calls We need to: [1] Remove obsolete framework parameters if any (yes there are). [2] Check scalar context calls if any (most probably not). Ad 1: How to find them? Git grep and look at each hit. You will need the -C parameter to add a few context lines around the call even. Found one in C4/Biblio.pm and six in Suggestions.t with ''. Found one in C4/Items on a second line. Similar one in Koha/EDI. Note: sub receipt_items in EDI has no unit tests yet. Also did a few git searches like: git grep GetMarcFromKohaField | grep -v -P "GetMarcFromKohaField.*;"| grep -P "GetMarcFromKohaField\s*\(" Note: Seeing still three lines; they are all fine. Last line comes from testing to trigger the warn. Ad 2: Have been looking at each git grep line and did not spot any scalar context call. Before this report, we had an example in POD and the Biblio test only. Try to find them by performing smarter git searches? Did look again at results for: git grep GetMarcFromKohaField | grep -v -P "\)\s*=\s*&?(C4::Biblio::)?GetMarcFromKohaField" | grep -v -P "use " The tests from this grep are included in the last test plan line. Test plan: Read the patch. Run t/db_dependent/Biblio/TransformHtmlToMarc.t Run t/db_dependent/Items.t Run t/db_dependent/Suggestions.t Run prove t/Biblio2.t t/db_dependent/Biblio.t t/db_dependent/Filter_MARC_ViewPolicy.t t/db_dependent/Koha/Authorities.t t/db_dependent/Koha/Biblio/Metadata.t t/db_dependent/Koha/Filter/EmbedItemsAvailability.t t/db_dependent/Koha/SearchEngine/Search.t t/db_dependent/XISBN.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158249|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165106&action=edit Bug 19097: (follow-up) Fix typo 'altough' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another nice piece of overdue cleanup, thanks Marcel. All working well, no regressions spotted and tests working and updated. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #27 from David Nind <david@davidnind.com> --- I have reviewed. As far as I can tell, there is nothing to document for the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- This bug makes Koha_Main_My8 fails: t/db_dependent/Biblio.t .. 1/24 # Failed test 'We expect two hits' # at t/db_dependent/Biblio.t line 147. # got: '1' # expected: '2' # Failed test 'Testing a random column for existence in 2nd hash' # at t/db_dependent/Biblio.t line 149. # Looks like you failed 2 tests of 27. # Failed test 'GetMarcSubfieldStructureFromKohaField' # at t/db_dependent/Biblio.t line 155. t/db_dependent/Biblio.t .. 11/24 # Looks like you failed 1 test of 24. t/db_dependent/Biblio.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/24 subtests Test Summary Report ------------------- t/db_dependent/Biblio.t (Wstat: 256 (exited 1) Tests: 24 Failed: 1) Failed test: 3 Non-zero exit status: 1 Files=1, Tests=24, 8 wallclock secs ( 0.05 usr 0.01 sys + 4.84 cusr 1.81 csys = 6.71 CPU) Result: FAIL This is because jenkins's config for this job has `export TEST_DB_UPGRADE=yes`, which means the test suite will be run after we run the update DB process (and not after a "regular" installation simulated using the installer/onboarding selenium tests) You can easily recreate (not necessarily using My8): 1 koha-mysql kohadev -e "DROP DATABASE koha_kohadev" || true 2 mysql -h db -u koha_kohadev -ppassword -e"CREATE DATABASE koha_kohadev" 3 flush_memcached 4 sudo service apache2 restart 5 sudo service koha-common restart 6 koha-mysql kohadev < /kohadevbox/misc4dev/data/sql/marc21/dump_kohadev_v19.11.00.sql 7 sudo koha-shell kohadev -p -c 'perl /kohadevbox/koha/installer/data/mysql/updatedatabase.pl' Then prove t/db_dependent/Biblio.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- so I guess you need to make sure the mapping exists in DB (and not assuming it's there already) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #29)
so I guess you need to make sure the mapping exists in DB (and not assuming it's there already)
Well, I can imagine that more tests will fail for that reason? Will take a look -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38513 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- See bug 38513 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38513 [Bug 38513] Fix Biblio.t for Koha_Main_My8 test configuration -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org