[Bug 41829] New: Tag editor button has wrong id on copied MARC field when value builder plugin is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 Bug ID: 41829 Summary: Tag editor button has wrong id on copied MARC field when value builder plugin is used Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Noticed this when testing bug 39522. When one copies MARC field, Tag editor button on fields containing value builder plugin have same id as original MARC field. To reproduce: 1. Find MARC framework which has value builder plugin attached to one of its fields. 2. Navigate to Cataloging -> New record. 3. Navigate to MARC field with plugin attached to it. 4. Inspect fields Tag editor button with browsers developer tools. -> Check the id of Tag editor button. 5. Copy the field and check id of copied Tag editor button. -> Notice that it has the same id as in original field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 192997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192997&action=edit Bug 41829: Set correct id to copied Tag editor button When one copies MARC field, Tag editor button on fields containing value builder plugin have same id as original MARC field. This patch sets correct id to these buttons. To reproduce: 1. Find MARC framework which has value builder plugin attached to one of its fields. 2. Navigate to Cataloging -> New record. 3. Navigate to MARC field with plugin attached to it. 4. Inspect fields Tag editor button with browsers developer tools. -> Check the id of Tag editor button. 5. Copy the field and check id of copied Tag editor button. -> Notice that it has the same id as in original field. 6. Apply this patch. 7. Referesh the page, navigate back to field and copy it. 8. Inspect Tag editors id. -> Id should now be same as in other copied fields. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192997|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 193865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193865&action=edit Bug 41829: Set correct id to copied Tag editor button When one copies MARC field, Tag editor button on fields containing value builder plugin have same id as original MARC field. This patch sets correct id to these buttons. To reproduce: 1. Find MARC framework which has value builder plugin attached to one of its fields. 2. Navigate to Cataloging -> New record. 3. Navigate to MARC field with plugin attached to it. 4. Inspect fields Tag editor button with browsers developer tools. -> Check the id of Tag editor button. 5. Copy the field and check id of copied Tag editor button. -> Notice that it has the same id as in original field. 6. Apply this patch. 7. Referesh the page, navigate back to field and copy it. 8. Inspect Tag editors id. -> Id should now be same as in other copied fields. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com Sponsorship status|--- |Sponsored Status|Signed Off |Passed QA Comma delimited| |Koha-Suomi Oy list of Sponsors| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193865|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 198314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198314&action=edit Bug 41829: Set correct id to copied Tag editor button When one copies MARC field, Tag editor button on fields containing value builder plugin have same id as original MARC field. This patch sets correct id to these buttons. To reproduce: 1. Find MARC framework which has value builder plugin attached to one of its fields. 2. Navigate to Cataloging -> New record. 3. Navigate to MARC field with plugin attached to it. 4. Inspect fields Tag editor button with browsers developer tools. -> Check the id of Tag editor button. 5. Copy the field and check id of copied Tag editor button. -> Notice that it has the same id as in original field. 6. Apply this patch. 7. Referesh the page, navigate back to field and copy it. 8. Inspect Tag editors id. -> Id should now be same as in other copied fields. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 --- Comment #4 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41829 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org