[Bug 36091] New: Spelling: Patron card number/cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Bug ID: 36091 Summary: Spelling: Patron card number/cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Not sure which spelling is correct, but consistency is good. $ grep -rn "Patron cardnumber" * koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/cash_register_stats.tt:4: "[% t("Manager name") | html %]"[% sep | html %]"[% t("Patron cardnumber") | html %]"[% sep | html %]"[% t("Patron name") | html %]"[% sep | html %]"[% t("Transaction library") | html %]"[% sep | html %]"[% t("Transaction date") | html %]"[% sep | html %]"[% t("Updated") | html %]"[% sep | html %]"[% t("Transaction type") | html %]"[% sep |html %]"[% t("Notes") | html %]"[% sep | html %]"[% t("Amount") | html %]"[% sep | html %]"[% t("Title") | html %]"[% sep | html %]"[% t("Barcode") | html %]"[% sep | html %]"[% t("Item type") | html %]" grep: misc/translator/po/.git/objects/pack/pack-b0a884343922aff65f857e780adda0f2bcc2203f.pack: binary file matches grep: misc/translator/po/.git/objects/pack/tmp_pack_O9fPOy: binary file matches misc/release_notes/release_notes_20_05_00.html:1588:<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329">[24329]</a> Patron cardnumber change times are lost during upgrade for bug 3820</li> misc/release_notes/release_notes_20_05_00.md:1194:- [[24329]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329) Patron cardnumber change times are lost during upgrade for bug 3820 $ grep -rn "Patron card number" * koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt:172: <th>Patron card number</th> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I think we should add something like this to our Terminology page (https://wiki.koha-community.org/wiki/Terminology): 'card number (noun) When referring to a patron's library card, use "card number," not "cardnumber." "cardnumber" should be used only when referring to the database column.' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Spelling: Patron card |Spelling: Use "card number" |number/cardnumber |instead of cardnumber in | |text -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 162148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162148&action=edit Bug 36091: Spelling: Use "card number" instead of cardnumber in text This patch replaces the term "cardnumber" with "card number" in labels and text where the patron's library card number is referred to. Where the database column is referenced "cardnumber" is kept. A full test plan would be very time-consuming and I think examining the patch should be verification enough for changes which are limited to adding a space. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162148|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 162170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162170&action=edit Bug 36091: Spelling: Use "card number" instead of cardnumber in text This patch replaces the term "cardnumber" with "card number" in labels and text where the patron's library card number is referred to. Where the database column is referenced "cardnumber" is kept. A full test plan would be very time-consuming and I think examining the patch should be verification enough for changes which are limited to adding a space. Signed-off-by: Magnus Enger <magnus@libriotech.no> Verified that the patch only changes "visible" text, and not references to the database column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162170|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 162370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162370&action=edit Bug 36091: Spelling: Use "card number" instead of cardnumber in text This patch replaces the term "cardnumber" with "card number" in labels and text where the patron's library card number is referred to. Where the database column is referenced "cardnumber" is kept. A full test plan would be very time-consuming and I think examining the patch should be verification enough for changes which are limited to adding a space. Signed-off-by: Magnus Enger <magnus@libriotech.no> Verified that the patch only changes "visible" text, and not references to the database column. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply to 23.05.x cleanly, no baackport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org