[Bug 14727] New: koha-indexer tab completion in bash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Bug ID: 14727 Summary: koha-indexer tab completion in bash Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz The koha-indexer script should provide tab-completion in bash, as other scripts do. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14714 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 [Bug 14714] koha-mysql tab-completion in bash -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 41933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41933&action=edit Bug 14727: koha-indexer tab completion in bash This patch introduces tab-completion in bash to the koha-indexer command. It completes using valid option switches and instance names. It stops completing then -h or --help are issued, and once a command switch is chosen (either --start, --stop or --restart) it goes ahead with valid instances completion. To test: - Have a packages install (kohadevbox works) - Run: $ . debian/koha-common.bash-completion - Type koha-indexer <tab> - Play with all the options => SUCCESS: They work as they should. - Sign off :-D Note: it fixes a small glitch on the plack completion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41933|0 |1 is obsolete| | --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 43314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43314&action=edit Bug 14727: koha-indexer tab completion in bash This patch introduces tab-completion in bash to the koha-indexer command. It completes using valid option switches and instance names. It stops completing then -h or --help are issued, and once a command switch is chosen (either --start, --stop or --restart) it goes ahead with valid instances completion. To test: - Have a packages install (kohadevbox works) - Run: $ . debian/koha-common.bash-completion - Type koha-indexer <tab> - Play with all the options => SUCCESS: They work as they should. - Sign off :-D Note: it fixes a small glitch on the plack completion. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Verified working, including filtering out already used options and instances. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43314|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43381&action=edit Bug 14727: koha-indexer tab completion in bash This patch introduces tab-completion in bash to the koha-indexer command. It completes using valid option switches and instance names. It stops completing then -h or --help are issued, and once a command switch is chosen (either --start, --stop or --restart) it goes ahead with valid instances completion. To test: - Have a packages install (kohadevbox works) - Run: $ . debian/koha-common.bash-completion - Type koha-indexer <tab> - Play with all the options => SUCCESS: They work as they should. - Sign off :-D Note: it fixes a small glitch on the plack completion. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Verified working, including filtering out already used options and instances. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The completion works but: root@kohadevbox:~# koha-indexer --start kohadev [ ok ] Starting Koha indexing daemon for kohadev:. root@kohadevbox:~# koha-indexer --stop kohadev [FAIL] Error: Indexer not running for kohadev: failed! root@kohadevbox:~# ps aux | grep zebra kohadev+ 509 0.0 0.0 18596 188 ? S 11:45 0:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --stdout=/var/log/koha/kohadev/zebra.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --delay=30 --user=kohadev-koha.kohadev-koha -- zebrasrv -v none,fatal,warn -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 511 0.0 0.8 121780 9148 ? S 11:45 0:00 zebrasrv -v none,fatal,warn -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 3017 0.0 0.0 18596 188 ? S 11:52 0:00 daemon --name=kohadev-koha-indexer --errlog=/var/log/koha/kohadev/indexer-error.log --stdout=/var/log/koha/kohadev/indexer.log --output=/var/log/koha/kohadev/indexer-output.log --verbose=1 --respawn --delay=30 --user=kohadev-koha.kohadev-koha -- /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5 kohadev+ 3020 0.8 11.0 341964 113288 ? S 11:52 0:01 /usr/bin/perl /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #4)
The completion works but:
root@kohadevbox:~# koha-indexer --start kohadev [ ok ] Starting Koha indexing daemon for kohadev:. root@kohadevbox:~# koha-indexer --stop kohadev [FAIL] Error: Indexer not running for kohadev: failed!
root@kohadevbox:~# ps aux | grep zebra kohadev+ 509 0.0 0.0 18596 188 ? S 11:45 0:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --stdout=/var/log/koha/kohadev/zebra.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --delay=30 --user=kohadev-koha.kohadev-koha -- zebrasrv -v none,fatal,warn -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 511 0.0 0.8 121780 9148 ? S 11:45 0:00 zebrasrv -v none,fatal,warn -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 3017 0.0 0.0 18596 188 ? S 11:52 0:00 daemon --name=kohadev-koha-indexer --errlog=/var/log/koha/kohadev/indexer-error.log --stdout=/var/log/koha/kohadev/indexer.log --output=/var/log/koha/kohadev/indexer-output.log --verbose=1 --respawn --delay=30 --user=kohadev-koha.kohadev-koha -- /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5 kohadev+ 3020 0.8 11.0 341964 113288 ? S 11:52 0:01 /usr/bin/perl /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5
Please fill a bug for that... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15011 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|koha-indexer tab completion |koha-indexer tab-completion |in bash |in bash -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org