https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 74943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74943&action=edit pic 1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18172 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob@calyx.net.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74945|0 |1 is obsolete| | --- Comment #4 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 74963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74963&action=edit Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled ps: you will need an active and working overdrive account to test this patch 1/ prepare a koha with overdrive sysprefs set and working (OverDriveLibraryID,OverDriveClientKey,OverDriveClientSecret) 2/ set OverDriveCirculation syspref to 'disable' 3/ do an opac search, note the 'Login to OverDrive account' message is incorrectly displayed see pic 1 4/ apply patch 5/ do an opac search, note the 'Login to OverDrive account' message is no longer displayed (good) see pic 2 Can confirm that bug is replicable and patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74963|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 75077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75077&action=edit Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled ps: you will need an active and working overdrive account to test this patch 1/ prepare a koha with overdrive sysprefs set and working (OverDriveLibraryID,OverDriveClientKey,OverDriveClientSecret) 2/ set OverDriveCirculation syspref to 'disable' 3/ do an opac search, note the 'Login to OverDrive account' message is incorrectly displayed see pic 1 4/ apply patch 5/ do an opac search, note the 'Login to OverDrive account' message is no longer displayed (good) see pic 2 Can confirm that bug is replicable and patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.