[Bug 31811] New: Add 'page-section' to marc modification templates pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Bug ID: 31811 Summary: Add 'page-section' to marc modification templates pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952 Blocks: 31757 We need the page-section div adding to the marc modification template page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 'page-section' to marc |Add 'page-section' to MARC |modification templates |modification templates |pages |pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142276&action=edit Bug 31811: Add 'page-section' to MARC modification templates pages This patch adds "page-section" divs to the MARC modification templates template so that sections are properly defined and content has adequate contrast. Note: The patch includes indentation changes, so please ignore whitespace when checking the diff. To test, apply the patch and go to Cataloging -> MARC modification templates. The main content should be surrounded by a white box whether you're looking at the list of templates, the the action add/edit form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142276|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142281&action=edit Bug 31811: Add 'page-section' to MARC modification templates pages This patch adds "page-section" divs to the MARC modification templates template so that sections are properly defined and content has adequate contrast. Note: The patch includes indentation changes, so please ignore whitespace when checking the diff. To test, apply the patch and go to Cataloging -> MARC modification templates. The main content should be surrounded by a white box whether you're looking at the list of templates, the the action add/edit form. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142281|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142311&action=edit Bug 31811: Add 'page-section' to MARC modification templates pages This patch adds "page-section" divs to the MARC modification templates template so that sections are properly defined and content has adequate contrast. Note: The patch includes indentation changes, so please ignore whitespace when checking the diff. To test, apply the patch and go to Cataloging -> MARC modification templates. The main content should be surrounded by a white box whether you're looking at the list of templates, the the action add/edit form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- `git diff -w` comes in handy with these paches ;p All looks good, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31811 Bug 31811 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org