[Bug 41689] New: "Staff note" and "OPAC" message types in patron files untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Bug ID: 41689 Summary: "Staff note" and "OPAC" message types in patron files untranslatable Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com The message types were added by bug 40367, but they are not translatable. To recreate: 1. Go to a patron account > Add message 2. Add a message with "Staff - Internal note" 3. Add a second message with "OPAC - [Name]" 4. Add a language to your Koha gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA Add the language in StaffInterfaceLanguages 5. Switch to the new language 6. Go to the patron's account --> Staff note is in english --> OPAC is in English (this is normal in fr-CA because we still call it OPAC even if it's an english term, but could be different in another language) 7. Check the translation files cd misc/translator/po/ git grep "Staff notes" fr-CA* --> There is nothing from patron-messages.inc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40367 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40367 [Bug 40367] Improve display of messages on patron account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ayoub.glizi-vicioso@inLibro | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 --- Comment #1 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191989&action=edit Bug 41689: Make patron message labels translatable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191989|0 |1 is obsolete| | --- Comment #2 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191993&action=edit Bug 41689: Make patron message labels translatable To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" ** NOTE: make sure to have the LAST version of the translation file (.po) or it might not work. (from: koha-traductions-main) 4- Add any language (I'll use french-Canada, fr-CA, in this case):
From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA
5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ayoub.glizi-vicioso@inLibro |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191993|0 |1 is obsolete| | --- Comment #3 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191996&action=edit Bug 41689: Make patron message labels translatable To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" 4- Add any language (I'll use french-Canada, fr-CA, in this case):
From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA
5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 191998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191998&action=edit Bug 41689: Make patron message labels translatable To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" 4- Add any language (I'll use french-Canada, fr-CA, in this case):
From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA
5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) QA checks - fail for tidy, but fixed Processing files [RUNNING] koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc Result: [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc` Processing additional checks PASS! Please check your setup, the tidy should happen automatically :) I tidied and amended the patch, it was only a one line whitespace change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191998|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 192599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192599&action=edit Bug 41689: Make patron message labels translatable To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" 4- Add any language (I'll use french-Canada, fr-CA, in this case):
From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA
5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.03 |26.05.00,25.11.03,25.05.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41689 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 40367 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org