https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89950&action=edit Bug 22957: Remove type attribute from script tags: Staff client includes 1/2 This patch removes the "type" attribute from <script> tags in several staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Acquisitions -> Vendor (uses acuisitions-toolbar.inc) - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record (uses additem.js.inc) - Catalog -> Search results -> Bibliographic detail view. (uses browser-strings.inc, catalog-strings.inc, datatables.inc, and format_price.inc ) - Tools -> Label creator -> Manage -> Label batches -> Export batch (uses greybox.inc) Validating the HTML source of any of these pages should return no errors related to the "type" attribute. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Quick question about & vs & and HTML vs XML validation with respect to the removal of CDATA in acquisitions-toolbar.inc? Are we ever validating as XML or XHTML? If not, okay. If so, then why remove CDATA? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89950|0 |1 is obsolete| | --- Comment #4 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 91337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91337&action=edit Bug 22957: Remove type attribute from script tags: Staff client includes 1/2 This patch removes the "type" attribute from <script> tags in several staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Acquisitions -> Vendor (uses acuisitions-toolbar.inc) - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record (uses additem.js.inc) - Catalog -> Search results -> Bibliographic detail view. (uses browser-strings.inc, catalog-strings.inc, datatables.inc, and format_price.inc ) - Tools -> Label creator -> Manage -> Label batches -> Export batch (uses greybox.inc) Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.