[Bug 43849] New: Add context for translation of "Editor"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 Bug ID: 43849 Summary: Add context for translation of "Editor" Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: anneli.osterman@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: caroline.cyr-la-rose@inlibro.com, f.demians@tamil.fr, jonathan.druart@gmail.com, julian.maurice@biblibre.com Target Milestone: --- The word "Editor" can be translated in different ways. In MARC frameworks it refers to bibliographic record's editor, the page where you edit the record. koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt:238 • koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt:36 In other places it can refer to a person or an occupation. We need to use different translations for these different use cases so it would be nice to have context for these translations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 209515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209515&action=edit Bug 43849: Add translation context to "Editor" in MARC editor strings The word "Editor" can be translated in different ways. In MARC frameworks and the cataloguing editor it refers to the page where a bibliographic record is edited But elsewhere it can refer to a person. Use tp() with the "Bibliographic record editor" context so translators can translate these separately. Test plan: 1. Update the French PO files before applying the patch: gulp po:update --lang fr-FR 2. Check the current state of the "Editor" strings: cd misc/translator git diff po/fr-FR-staff-prog.po => There is a single "Editor" entry with no msgctxt 3. Apply the patch 4. Update the PO files again gulp po:update --lang fr-FR 5. Run git diff again and notice that a new entry has been created: msgctxt "Bibliographic record editor" msgid "Editor" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #209515|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 210004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210004&action=edit Bug 43849: Add translation context to "Editor" in MARC editor strings The word "Editor" can be translated in different ways. In MARC frameworks and the cataloguing editor it refers to the page where a bibliographic record is edited But elsewhere it can refer to a person. Use tp() with the "Bibliographic record editor" context so translators can translate these separately. Test plan: 1. Update the French PO files before applying the patch: gulp po:update --lang fr-FR 2. Check the current state of the "Editor" strings: cd misc/translator git diff po/fr-FR-staff-prog.po => There is a single "Editor" entry with no msgctxt 3. Apply the patch 4. Update the PO files again gulp po:update --lang fr-FR 5. Run git diff again and notice that a new entry has been created: msgctxt "Bibliographic record editor" msgid "Editor" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I had trouble following the test plan - but I have signed off anyway. If this is not what is expected, please change the status. Testing notes (using KTD): 1. Step 2: needed to change into the po directory to run the diff command, ended up opening fr-FR-staff-prog.po and searching for "Editor" - with this entry on 37976 37973 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt:238 37974 #: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt:36 37975 #, c-format 37976 msgid "Editor" 37977 msgstr "Éditeur" 2. Step 5: Used git diff fr-FR-messages.po - now no single entry for "Editor" in fr-FR-staff-prog.po - new entry for "Editor" in fr-FR-messages.po 6524 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt:238 6525 #: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt:8 6526 #: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt:36 6527 #, fuzzy 6528 msgctxt "Bibliographic record editor" 6529 msgid "Editor" 6530 msgstr "Éditeur" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #210004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 210074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210074&action=edit Bug 43849: Add translation context to "Editor" in MARC editor strings The word "Editor" can be translated in different ways. In MARC frameworks and the cataloguing editor it refers to the page where a bibliographic record is edited But elsewhere it can refer to a person. Use tp() with the "Bibliographic record editor" context so translators can translate these separately. Test plan: 1. Update the French PO files before applying the patch: gulp po:update --lang fr-FR 2. Check the current state of the "Editor" strings: cd misc/translator git diff po/fr-FR-staff-prog.po => There is a single "Editor" entry with no msgctxt 3. Apply the patch 4. Update the PO files again gulp po:update --lang fr-FR 5. Run git diff again and notice that a new entry has been created: msgctxt "Bibliographic record editor" msgid "Editor" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43849 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org