http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- I agree, and I think it should be off by default. I have submitted a patch that has logging off by default and needs the -l switch on to log to a file. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15581&action=edit Bug 9656: Make logging to a file optional (for fines) To test: 1/ Before the patch run misc/cronjobs/fines.pl Notice that a file has been written to /tmp 2/ rm the file 3/ Apply the patch and run the script again Notice the file is not created 4/ run the script with -l Notice the file is created again -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #3)

Test: 1) pre-patch, file created in tmp

2) post-patch, no args, file no created

3) post-patch, -l, errors: a) error message ~/kohaclone$ misc/cronjobs/fines.pl -l Can't use an undefined value as a symbol reference at misc/cronjobs/fines.pl line 141. b) file created, only column names cat /tmp/kohadev* cardnumber categorycode surname firstname email phone address citystate itemnumber barcode date_due type days_overdue fine

Fixed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15643|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15644&action=edit [SIGNED-OFF] Bug 9656: Make logging to a file optional (for fines) To test: 1/ Before the patch run misc/cronjobs/fines.pl Notice that a file has been written to /tmp 2/ rm the file 3/ Apply the patch and run the script again Notice the file is not created 4/ run the script with -l Notice the file is created again Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Now it work as described. No errors. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: If the -o parameter is given, there is no logfile created, I think it is not consistent. To keep a consistency with current configuration, isn't it better just to produce a log file if the -o parameter exists? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think I might have misunderstood your comment... digging around a bit. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15767&action=edit Bug 9656: Followup Make logging to a file optional (for fines) The -log option become optional if the -output_dir is given. Test plan: call the script with 1/ no one parameter : no log file 2/ -l : log file will be created in /tmp 3/ -o=/home/koha/var/log : log file with be created in the specified 4/ -o=/home/koha/var/log -l: Same as 3/ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15767|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15814&action=edit [SIGNED-OFF] Bug 9656: Followup Make logging to a file optional (for fines) The -log option become optional if the -output_dir is given. Test plan: call the script with 1/ no one parameter : no log file 2/ -l : log file will be created in /tmp 3/ -o=/home/koha/var/log : log file with be created in the specified 4/ -o=/home/koha/var/log -l: Same as 3/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: All combination of options tested. Works well. No errors. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15644|0 |1 is obsolete| | --- Comment #13 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 15860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15860&action=edit Bug 9656: Make logging to a file optional (for fines) To test: 1/ Before the patch run misc/cronjobs/fines.pl Notice that a file has been written to /tmp 2/ rm the file 3/ Apply the patch and run the script again Notice the file is not created 4/ run the script with -l Notice the file is created again Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Now it work as described. No errors. Signed-off-by: Elliott Davis <elliott@bywatersolions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. The output directory is not set according to an environment variable as claimed by the help, but the help was wrong prior to these patches so I am pushing them anyway. -- You are receiving this mail because: You are watching all bug changes.