[Bug 14960] New: Remove C4::Dates from files in misc/cronjobs (part 1)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Bug ID: 14960 Summary: Remove C4::Dates from files in misc/cronjobs (part 1) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org This patch removes C4::Dates from following files - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl (Note: The remainig files misc/cronjobs/overdue_notices.pl and misc/cronjobs/staticfines.pl will be covered with a separate bug) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 43149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43149&action=edit Bug 14960 - Remove C4::Dates from files in misc/cronjobs (part 1) This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Blocks| |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 43310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43310&action=edit Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove C4::Dates from files |Remove C4::Dates from files |in misc/cronjobs (part 1) |in misc/cronjobs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #3 from Marc Véron <veron@veron.ch> --- Still applies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #4 from Marc Véron <veron@veron.ch> --- Still applies. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43310|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 44440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44440&action=edit Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply ( 04.11.2015 / mv :-) ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it --- Comment #6 from Zeno Tajoli <z.tajoli@cineca.it> --- Marc, this bug cover also misc/cronjobs/overdue_notices.pl and misc/cronjobs/staticfines.pl ? Because I see modification also on those two scripts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #7 from Marc Véron <veron@veron.ch> --- (In reply to Zeno Tajoli from comment #6)
Marc, this bug cover also misc/cronjobs/overdue_notices.pl and misc/cronjobs/staticfines.pl ? Because I see modification also on those two scripts.
Yes, as mentioned in teh latest commit message. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala@gmail.com Assignee|veron@veron.ch |j.kylmala@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|j.kylmala@gmail.com |veron@veron.ch --- Comment #8 from Marc Véron <veron@veron.ch> --- Joonas, are you working on this bug? It was assigned to you since this morning. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44440|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Comment on attachment 44440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44440 Bug 14960 - Remove C4::Dates from files in misc/cronjobs Hmm, something is wrong with the latest patch when I amended to make it apply. Going back... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43310|1 |0 is obsolete| | --- Comment #10 from Marc Véron <veron@veron.ch> --- Comment on attachment 43310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43310 Bug 14960 - Remove C4::Dates from files in misc/cronjobs Reactivating... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43310|0 |1 is obsolete| | --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 44563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44563&action=edit Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply and follwoing comments on IRC by putti http://irc.koha-community.org/koha/2015-11-06#i_1752803 (misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84) 6.11.2015 /mv -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Eyeballs well. Have yet to test it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44563|0 |1 is obsolete| | --- Comment #13 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 44611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44611&action=edit Remove C4 Dates from files in misc/cronjob -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #14 from Mirko Tietgen <mirko@abunchofthings.net> --- Zeno: you forgot to set the bug to "signed off" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Zeno Tajoli <z.tajoli@cineca.it> --- Sorry, I forgot to change the status -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44611|Remove C4 Dates from files |[SIGNED-OFF] Remove C4 description|in misc/cronjob |Dates from files in | |misc/cronjob -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #16 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to M. Tompsett from comment #12)
Eyeballs well. Have yet to test it.
I can say also that the code looks good. Haven't ran the scripts thoroughly, though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44611|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44742&action=edit Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply and follwoing comments on IRC by putti http://irc.koha-community.org/koha/2015-11-06#i_1752803 (misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84) 6.11.2015 /mv Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44743&action=edit Bug 14960: Simplify the date management in staticfines There is no need to create a DT objcet, then display in string/iso then recreate a DT object from this string. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44742|0 |1 is obsolete| | Attachment #44743|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44927&action=edit [PASSED QA] Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply and follwoing comments on IRC by putti http://irc.koha-community.org/koha/2015-11-06#i_1752803 (misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84) 6.11.2015 /mv Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44928&action=edit [PASSED QA] Bug 14960: Simplify the date management in staticfines There is no need to create a DT objcet, then display in string/iso then recreate a DT object from this string. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marc and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org