[Bug 10276] New: Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Bug ID: 10276 Summary: Extend IndependentBranches to support groups of libraries Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle.m.hall@gmail.com Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10090, 10206 Assignee|gmcharlt@gmail.com |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18205&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10278 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18205|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18479&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10263 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10090 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10277 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10206 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18479|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18519&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18519|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18716&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18716|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18717&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18717|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18850&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10502 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18850|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20773&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |srdjan@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20773|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21145&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #9 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 10276 - Extend IndependentBranches to support groups of libraries Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10276 - Extend IndependentBranches to support groups of libraries The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21145|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22791&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Jerry Brock <elibristech@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #12 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 23037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23037&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Jerry Brock <elibristech@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23037|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23484&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Jerry Brock <elibristech@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10263 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10502 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23484|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23489&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Jerry Brock <elibristech@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, Why did you submit new patches when the patch is signed off? Why don't you submit followups? What is the diff between the SO patch and the last one? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Maybe it is just a rebase... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #16)
Maybe it is just a rebase...
Yep, I had to rebase this patch due to additions to bug 10277, which this one depends on. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from Joel Sasse <jsasse@plumcreeklibrary.net> --- I tested this and want to sign off on this patch. Joel Sasse -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23489|0 |1 is obsolete| | --- Comment #19 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 23637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23637&action=edit Extend IndependetBranches to support groups of libraries -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23637|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23641&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch currently doesn't apply. I tried applying it directly on master and on top of bug 10277: Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 10276 - Extend IndependentBranches to support groups of libraries fatal: sha1 information is lacking or useless (C4/Items.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10276 - Extend IndependentBranches to support groups of libraries The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 23641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23641 Bug 10276 - Extend IndependentBranches to support groups of libraries Review of attachment 23641: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=23641) ----------------------------------------------------------------- Patch doesn't apply, but doing a quick code review: 1) Commit message could be updated, dependencies noted are resolved and example is slightly wrong (should be group 1 and 3). 2) Patch touches a lot of routines in different modules, but none of this is backed up by unit tests. This is a big feature with a lot of possible consequences if we break something, I think unit tests are a requirement, at least for the new routine. (UT) 3) Patch has bug 10277 notes as dependency, but is not using the new function consequently (C4::Context->IsSuperLibrarian()) 4) Patch seems to remove 'properties' from the interface. Currently libraries can add properties library groups. I think we need to discuss this before removing the feature. Also we need to think about databases with property groups defined and how to migrate them. Or keep the option. (properties) ::: C4/Branch.pm @@ +43,4 @@
&GetBranchCategories &GetBranchesInCategory &ModBranchCategoryInfo + &GetIndependentGroupModificationRights
UT @@ +376,4 @@
#TODO manage category types. rename possibly to 'agency domains' ? as borrowergroups are called categories. sub GetCategoryTypes { + return ( 'searchdomain','independent_groups');
properties @@ +446,5 @@
+ + If 'branch' is not provided, it will be looked up via + C4::Context->userenv->{branch}. + + If 'for' is provided, the lookup is limited to that branch.
Could you explain the behaviour/use of 'for' a bit more? @@ +452,5 @@
+ If called in a list context, returns a list of + branchcodes ( including $this_branch ). + + If called in a scalar context, it returns + a count of matching branchcodes. Returns 1 if
...? :) ::: C4/Serials.pm @@ +238,5 @@
+ subscription.subscriptionid as subsid + |; + if ( C4::Context->preference('IndependentBranches') + && C4::Context->userenv + && C4::Context->userenv->{'flags'} % 2 != 1
C4::Context->IsSuperLibrarian() @@ +355,5 @@
+ |; + + if ( C4::Context->preference('IndependentBranches') + && C4::Context->userenv + && C4::Context->userenv->{'flags'} % 2 != 1
C4::Context->IsSuperLibrarian() @@ +413,5 @@
+ |; + + if ( C4::Context->preference('IndependentBranches') + && C4::Context->userenv + && C4::Context->userenv->{'flags'} % 2 != 1
C4::Context->IsSuperLibrarian() @@ +594,5 @@
+ |; + + if ( C4::Context->preference('IndependentBranches') + && C4::Context->userenv + && C4::Context->userenv->{'flags'} != 1
C4::Context->IsSuperLibrarian() ::: catalogue/moredetail.pl @@ +177,3 @@
my $userenv = C4::Context->userenv(); + unless ( + $userenv->{'flags'} % 2 != 1
C4::Context->IsSuperLibrarian() ::: cataloguing/additem.pl @@ +702,4 @@
#verifying rights my $userenv = C4::Context->userenv(); + unless ( + $userenv->{'flags'} % 2 == 1
C4::Context->IsSuperLibrarian()f ::: circ/circulation-home.pl @@ +39,5 @@
$template->param( fast_cataloging => 1 ) if (defined $fa);
# Checking if the transfer page needs to be displayed +$template->param( display_transfer => 1 ) + if ( $flags->{'superlibrarian'} == 1
C4::Context->IsSuperLibrarian() ::: installer/data/mysql/kohastructure.sql @@ +365,4 @@
`categorycode` varchar(10) NOT NULL default '', -- unique identifier for the library/branch group `categoryname` varchar(32), -- name of the library/branch group `codedescription` mediumtext, -- longer description of the library/branch group + `categorytype` ENUM( 'searchdomain', 'independent_group' ) NULL DEFAULT NULL, -- says whether this is a search group or an independent group
properties -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23641|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23953&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23953|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23992&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, there is a conflict in Branches.pm. I tried to resolve it, but started wondering about @bind_parameters. You remove the push line, so it never gets assigned, but is used later on. Also I think we should use ? instead of $branches. my $query="SELECT * FROM branches"; my @bind_parameters; if ($onlymine && C4::Context->userenv && C4::Context->userenv->{branch}){ - $query .= ' WHERE branchcode = ? '; - push @bind_parameters, C4::Context->userenv->{branch}; + my $branches = GetIndependentGroupModificationRights({ stringify => 1 }); + $query .= qq{ WHERE branchcode IN ( $branches ) }; } $query .= " ORDER BY branchname"; $sth = $dbh->prepare($query); $sth->execute(@bind_parameters); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I am a bit worried about the stringify because it will break escaping by dbi. I think it would be better using a list: There is an example for that in our coding guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL10:_Placeholders -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #26)
Hi Kyle, I am a bit worried about the stringify because it will break escaping by dbi. I think it would be better using a list:
There is an example for that in our coding guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL10:_Placeholders
Using placeholders would end up complicating every single query in an extreme manner. That practice of using placeholders is to prevent SQL injection attacks. That is not an issue here. An attack such as that is absolutely not possible in this case, since what we are turning into a string is a list of branchcodes that were just pulled from the database. Good question though! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Actually, there is one case where it's possible that the passed in branch parameter could be stringified directly. I will add a followup to escape that parameter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23992|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24427&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, the attached patch introduces a lot of old super librarian checks. Please take a look. I just did a quick search for "flags". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24428&action=edit Bug 10276i [QA Followup] - Extend IndependentBranches to support groups of libraries -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Indeed it does! I'll add another followup for that. (In reply to Katrin Fischer from comment #30)
Kyle, the attached patch introduces a lot of old super librarian checks. Please take a look. I just did a quick search for "flags".
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #33 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Kyle M Hall from comment #27)
(In reply to Katrin Fischer from comment #26)
Hi Kyle, I am a bit worried about the stringify because it will break escaping by dbi. I think it would be better using a list:
There is an example for that in our coding guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL10:_Placeholders
Using placeholders would end up complicating every single query in an extreme manner. That practice of using placeholders is to prevent SQL injection attacks. That is not an issue here. An attack such as that is absolutely not possible in this case, since what we are turning into a string is a list of branchcodes that were just pulled from the database. Good question though!
It is absolutely possible, if someone, through XSS or CRSF or another means has managed to get sql into the db, this will then fetch and run it. The only time we should not use placeholders is in a case like SELECT * FROM fish WHERE name="fish"; However, SQL injection is not the only reason, for using placeholders. They are for db independence, they will escape characters in the way that is safe for the rdbms running underneath. So we dont need to bother doing the escaping ourself, eg, what if branchcode had a character that would bust the query, GetIndependentGroupModificationRights is doing no escaping/sanitation, ie it is handing back what is in the db, with , '. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #34 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Chris Cormack from comment #33)
So we dont need to bother doing the escaping ourself, eg, what if branchcode had a character that would bust the query, GetIndependentGroupModificationRights is doing no escaping/sanitation, ie it is handing back what is in the db, with , '.
And $dbh->quote() is not the answer, either. I am taking a hard line on this: I will never knowingly push patches that add violations of SQL10 (and certainly not a bunch of them in one fell swoop). I see no upside for the short- and long-term health of the codebase to do so. (In reply to Kyle M Hall from comment #27)
Using placeholders would end up complicating every single query in an extreme manner.
No, it wouldn't. There is an example of how to handle it in code you've written yourself, i.e., ModCourseInstructors(). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24427|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25722&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24428|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25723&action=edit Bug 10276i [QA Followup] - Extend IndependentBranches to support groups of libraries -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25724&action=edit Bug 10276i [QA Followup 2] - Remove stringify, use placeholders for db queries -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #38 from M. Tompsett <mtompset@hotmail.com> --- I want to make sure I understand this. Let's say I enable patron self registration. And self registration puts them into BranchA. Let's say I mark BranchA as part of a group which also includes BranchB. Should not a patron with all staff permissions (not super librarian) in BranchB, be able to edit the patron which belongs to BranchA such that they are moved to BranchB? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 26015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26015&action=edit Bug 10276 [QA Followup 3] - Fix inability to change patron's branch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25722|0 |1 is obsolete| | --- Comment #40 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26026&action=edit [SIGNED OFF] Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25723|0 |1 is obsolete| | --- Comment #41 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26027&action=edit [SIGNED OFF] Bug 10276i [QA Followup] - Extend IndependentBranches to support groups of libraries Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25724|0 |1 is obsolete| | --- Comment #42 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26028&action=edit [SIGNED OFF] Bug 10276i [QA Followup 2] - Remove stringify, use placeholders for db queries Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26015|0 |1 is obsolete| | --- Comment #43 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26029&action=edit [SIGNED OFF] Bug 10276 [QA Followup 3] - Fix inability to change patron's branch Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #44 from M. Tompsett <mtompset@hotmail.com> --- TEST PLAN (I used) ------------------- 1) Back up DB 2) Drop the koha database, create a blank one. 3) Apply the patch 4) Run the koha qa test tool: koha-qa.pl -v 2 -c 4 5) Do the web install from the staff client (everything less patrons and branches). 6) Run the test: prove -v t/db_dependent/Branch.t 7) Log into Koha staff client with system user 8) Create three branches: BRA, BRB, BRC 9) Create an independent group: AB 10) Make sure BRA and BRB are in AB, but BRC is not. 11) Create two users: staff with everything checked and not super librarian, and patron. Put them in BRB and BRA respectively. 12) Change IndependentBranches to 'Prevent' (turn it on). 12) Log out of system user 13) Log in as staff user. 14) Can staff user find both himself and the other patron? -- this should be true 15) view the other patron, and edit -- this should be allowed, since BRB and BRA are in the same group. 16) move the patron from BRA into BRB and click save. -- this should work. 17) view the other patron, and edit 18) This time, move the patron to BRC and click save. -- this should work. It's bad to do, but it should work. 19) Try to find the other patron. -- this should be possible now, because BRC is not in group. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #45 from M. Tompsett <mtompset@hotmail.com> --- Oops... this should NOT be possible now, because BRC is not in group. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #46 from M. Tompsett <mtompset@hotmail.com> --- Bug 11746 has been pushed to master, which is good. However, this means that the links displayed in the catalogue/details.pl page are displaying Edit on items which the user should not have edit links for. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26026|0 |1 is obsolete| | Attachment #26027|0 |1 is obsolete| | Attachment #26028|0 |1 is obsolete| | Attachment #26029|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28354&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28355&action=edit Bug 10276i [QA Followup] - Extend IndependentBranches to support groups of libraries Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28356&action=edit Bug 10276i [QA Followup 2] - Remove stringify, use placeholders for db queries Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28357&action=edit Bug 10276 [QA Followup 3] - Fix inability to change patron's branch Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28354|0 |1 is obsolete| | Attachment #28355|0 |1 is obsolete| | Attachment #28356|0 |1 is obsolete| | Attachment #28357|0 |1 is obsolete| | --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28358&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28359&action=edit Bug 10276 [QA Followup] - Extend IndependentBranches to support groups of libraries Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28360&action=edit Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28361&action=edit Bug 10276 [QA Followup 3] - Fix inability to change patron's branch Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28365&action=edit Bug 10276 [QA Followup 3] - Fix edit links on catalogue/detail.pl Bug 11746 has been pushed to master, which is good. However, this means that the links displayed in the catalogue/details.pl page are displaying Edit on items which the user should not have edit links for. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28365|0 |1 is obsolete| | --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28366&action=edit Bug 10276 [QA Followup 4] - Fix edit links on catalogue/detail.pl Bug 11746 has been pushed to master, which is good. However, this means that the links displayed in the catalogue/details.pl page are displaying Edit on items which the user should not have edit links for. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28366|0 |1 is obsolete| | --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28367&action=edit Bug 10276 [QA Followup 4] - Fix edit links on catalogue/detail.pl Bug 11746 has been pushed to master, which is good. However, this means that the links displayed in the catalogue/details.pl page are displaying Edit on items which the user should not have edit links for. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Rolf Schrittenlocher <schritte@ub.uni-frankfurt.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |schritte@ub.uni-frankfurt.d | |e -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #58 from Jonathan Druart <jonathan.druart@biblibre.com> --- Partial QA comments: 1/ There is a lack of unit tests here. 2/ I don't understand the interest of the stringify param, it's just a 1 line join. 3/ QA Followup 2 could be squashed with the main patch for the readability. 4/ Clone is a new dependency. But that could be avoid. I think something like my $clone = { %$hash_ref }; does the same think. 5/ How to be sure your changes are exhaustive? Everywhere IndependentBranches is used, that's it? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12599 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> ---
1/ There is a lack of unit tests here.
I'll add some.
2/ I don't understand the interest of the stringify param, it's just a 1 line join.
That's cruft from previous versions of the feature. I'll find and remove those.
3/ QA Followup 2 could be squashed with the main patch for the readability.
Will do!
4/ Clone is a new dependency. But that could be avoid. I think something like my $clone = { %$hash_ref }; does the same think. I'll take a look at that.
5/ How to be sure your changes are exhaustive? Everywhere IndependentBranches is used, that's it?
Yep! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #60 from M. Tompsett <mtompset@hotmail.com> --- Also, it fails to apply cleanly now. Make sure to rebase. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Jeremy Evans <Jeremy.evans@nibsc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Jeremy.evans@nibsc.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #61 from M. Tompsett <mtompset@hotmail.com> --- Still needs a rebase and fix. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #62 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 28360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28360 Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries Review of attachment 28360: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=28360) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +2414,5 @@
+ my @branches = GetIndependentGroupModificationRights(); + $query .= + " AND ( borrowers.branchcode = ? OR borrowers.branchcode IN ( " + . join( ',', ('?') x @branches ) . " ) ) "; + push( @query_params, @branches );
2416 has a ? in addition to the join'd ones on 2417. This leads to an off by one error. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28358|0 |1 is obsolete| | Attachment #28359|0 |1 is obsolete| | Attachment #28360|0 |1 is obsolete| | Attachment #28361|0 |1 is obsolete| | Attachment #28367|0 |1 is obsolete| | --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36027&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36027|0 |1 is obsolete| | --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36028&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36029&action=edit Bug 10276 [QA Followup] - Extend IndependentBranches to support groups of libraries Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #66 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36030&action=edit Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36031&action=edit Bug 10276 [QA Followup 3] - Fix inability to change patron's branch Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #68 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36032&action=edit Bug 10276 [QA Followup 4] - Fix edit links on catalogue/detail.pl Bug 11746 has been pushed to master, which is good. However, this means that the links displayed in the catalogue/details.pl page are displaying Edit on items which the user should not have edit links for. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #69 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 36030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36030 Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries Review of attachment 36030: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=36030) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +2401,5 @@
+ my @branches = GetIndependentGroupModificationRights(); + $query .= + " AND ( borrowers.branchcode = ? OR borrowers.branchcode IN ( " + . join( ',', ('?') x @branches ) . " ) ) "; + push( @query_params, @branches );
There is @branches+1 ?'s, but only @branches parameters. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #70 from M. Tompsett <mtompset@hotmail.com> --- For reason given in comment #69. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #71 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 36030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36030 Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries Review of attachment 36030: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=36030) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +2401,5 @@
+ my @branches = GetIndependentGroupModificationRights(); + $query .= + " AND ( borrowers.branchcode = ? OR borrowers.branchcode IN ( " + . join( ',', ('?') x @branches ) . " ) ) "; + push( @query_params, @branches );
This is the only function which checks borrowers.branchcode. Is this correct? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #72 from M. Tompsett <mtompset@hotmail.com> --- Since this is taking time to get signed off, perhaps convert the updatedatabase.pl to an atomicupdate, so this will need less tweaks when applying the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #73 from M. Tompsett <mtompset@hotmail.com> --- Please rebase and fix the issue raised in comment #71. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #74 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #73)
Please rebase and fix the issue raised in comment #71.
And comment #69. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36028|0 |1 is obsolete| | Attachment #36029|0 |1 is obsolete| | Attachment #36030|0 |1 is obsolete| | Attachment #36031|0 |1 is obsolete| | Attachment #36032|0 |1 is obsolete| | --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41064&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41064|0 |1 is obsolete| | --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41065&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41065|0 |1 is obsolete| | --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41066&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41067&action=edit Bug 10276 [QA Followup] - Extend IndependentBranches to support groups of libraries Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #79 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41068&action=edit Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #80 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41069&action=edit Bug 10276 [QA Followup 3] - Fix inability to change patron's branch Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #81 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41070&action=edit Bug 10276 [QA Followup 4] - Fix edit links on catalogue/detail.pl Bug 11746 has been pushed to master, which is good. However, this means that the links displayed in the catalogue/details.pl page are displaying Edit on items which the user should not have edit links for. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #82 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 41066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41066 Bug 10276 - Extend IndependentBranches to support groups of libraries Review of attachment 41066: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=41066) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +1912,5 @@
+C<@results> is sorted alphabetically by book title. + +=cut + +sub GetParcel {
Has been removed by Bug 13318 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org