[Bug 11638] New: Untranslatable "Tag editor" in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Bug ID: 11638 Summary: Untranslatable "Tag editor" in addbiblio.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr addbiblio.pl has a hard-coded (and therefore untranslatable) "Tag editor" text. It appears in two places in the code. Also: print "Content-Type: text/html\n\n<html><body><h1>ERROR when DELETING BIBLIO $biblionumber : $error</h1></body></html>"; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I find these instances of the phrase "tag editor" in .pl and .pm files: Line 220 of authorities\authorities.pl Line 252 of authorities\authorities.pl Line 2833 of C4\Items.pm Line 398 of cataloguing\addbiblio.pl Line 427 of cataloguing\addbiblio.pl Line 238 of cataloguing\additem.pl Line 255 of cataloguing\additem.pl Line 404 of tools\batchMod.pl Line 418 of tools\batchMod.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27922&action=edit Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com Component|I18N/L10N |Templates Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | Summary|Untranslatable "Tag editor" |Remove HTML from |in addbiblio.pl |addbiblio.pl --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Changed Bug description and component -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27922|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27928&action=edit Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values 2. Update translation file for a language, check new string 'Tag editor' About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug. Updated test plan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- *** Bug 682 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Owen Leonard from comment #1)
I find these instances of the phrase "tag editor" in .pl and .pm files:
Line 238 of cataloguing\additem.pl Line 255 of cataloguing\additem.pl
This two in Bug 12176 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Owen Leonard from comment #1)
I find these instances of the phrase "tag editor" in .pl and .pm files:
Line 220 of authorities\authorities.pl Line 252 of authorities\authorities.pl
This two in Bug 12177 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Owen Leonard from comment #1)
I find these instances of the phrase "tag editor" in .pl and .pm files:
Line 404 of tools\batchMod.pl Line 418 of tools\batchMod.pl
This two in Bug 12180 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=766 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27928|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 29462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29462&action=edit Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values 2. Update translation file for a language, check new string 'Tag editor' About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug. Updated test plan Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29462|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29492&action=edit [PASSED QA] Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values 2. Update translation file for a language, check new string 'Tag editor' About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug. Updated test plan Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org