[Bug 37167] New: Fix mapping call number searches to Z39.50
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Bug ID: 37167 Summary: Fix mapping call number searches to Z39.50 Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org If you do an advanced search for Call number, your search will be for &idx=callnum, but the code in catalogue/search.pl that creates $z3950par to pass to z3950_search_args to eventually fill the form if you use the Z39.50/SRU Search button in your search results thinks that the index for callnum searches is still the one it was 15 years ago, lcn,phr, so instead of getting your search term filled in the "Dewey:" field (which isn't, it's a generic call number search), you get it in the "Title:" field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 168048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168048&action=edit Bug 37167: Fix mapping call number searches to Z39.50 When you do an advanced search for call number, your search uses the index callnum, but the code that maps your search to a possible Z39.50 search still uses the index lcn,phr which was last used 15 years ago, so it's treated as an unknown index and mapped to the Title field in the Z39.50 search form. Test plan: 1. Click Search in the top menu to load Advanced Search 2. Change the dropdown menu for the first input from Keyword to Call Number, and paste TT174.3 in the input and search 3. Find the Z39.50/SRU search button in your results and click it 4. Note that your search was filled in the Title field 5. Apply patch, reset_all 6. Repeat steps 1-3, note that your search was filled in the Dewey field 7. Choose the server Library of Congress SRU and search 8. Note that even though we labelled it Dewey and you searched for an LC call number, your results are things with that call number in 050, the LC call number field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Filed bug 37168 for fixing the inaccurate "Dewey" label. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168048|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 168183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168183&action=edit Bug 37167: Fix mapping call number searches to Z39.50 When you do an advanced search for call number, your search uses the index callnum, but the code that maps your search to a possible Z39.50 search still uses the index lcn,phr which was last used 15 years ago, so it's treated as an unknown index and mapped to the Title field in the Z39.50 search form. Test plan: 1. Click Search in the top menu to load Advanced Search 2. Change the dropdown menu for the first input from Keyword to Call Number, and paste TT174.3 in the input and search 3. Find the Z39.50/SRU search button in your results and click it 4. Note that your search was filled in the Title field 5. Apply patch, reset_all 6. Repeat steps 1-3, note that your search was filled in the Dewey field 7. Choose the server Library of Congress SRU and search 8. Note that even though we labelled it Dewey and you searched for an LC call number, your results are things with that call number in 050, the LC call number field. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. For step 5, only a restart_all is required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37168 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- I reset_all all the time when I mean restart_all, I'd be surprised if that's the first time I've done it in a test plan :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Phil Ringnalda from comment #5)
I reset_all all the time when I mean restart_all, I'd be surprised if that's the first time I've done it in a test plan :)
No problem! Sometimes (very occasionally I find) a reset_all is required. I just add the testing notes for my future self, but they may be of use to others as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168183|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168263&action=edit Bug 37167: Fix mapping call number searches to Z39.50 When you do an advanced search for call number, your search uses the index callnum, but the code that maps your search to a possible Z39.50 search still uses the index lcn,phr which was last used 15 years ago, so it's treated as an unknown index and mapped to the Title field in the Z39.50 search form. Test plan: 1. Click Search in the top menu to load Advanced Search 2. Change the dropdown menu for the first input from Keyword to Call Number, and paste TT174.3 in the input and search 3. Find the Z39.50/SRU search button in your results and click it 4. Note that your search was filled in the Title field 5. Apply patch, reset_all 6. Repeat steps 1-3, note that your search was filled in the Dewey field 7. Choose the server Library of Congress SRU and search 8. Note that even though we labelled it Dewey and you searched for an LC call number, your results are things with that call number in 050, the LC call number field. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the quick work here Phil, All working as described. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Dewey is better than title for sure, but we are pretending that all libraries use Dewey. In Germany almost no library uses Dewey. Even in the US some might be using LOC I think? I wonder if this automatism really makes sense or won't be a nuisance for some libraries that would prefer if there was no auto-fill at all? Not sure what we could do, to make this smarter. Just pondering to maybe result in a new bug with some ideas on how to make this a bit smarter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 --- Comment #10 from Phil Ringnalda <phil@chetcolibrary.org> --- Conveniently, Dewey isn't Dewey, it's actually LC. It would have been cleaner if I discovered everything broken with this feature before I filed the first bug or wrote the first patch, but since no generic call number search actually exists in Z39.50, bug 37168 is heading toward making this prefill keyword, making Dewey actually search Dewey, and people who know their callnum search was for either LC or Dewey can copy-paste from keyword to the appropriate flavor, while people with call numbers that are neither can leave it in keyword. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 --- Comment #12 from Phil Ringnalda <phil@chetcolibrary.org> --- Preferring no auto-fill at all is easy: don't do a call number search and then continue to Z39.50 from the results of that search :) Replace via Z39.50 doesn't prefill call numbers, there's nothing in biblio/biblioitems from which they could, so this only comes up if you explicitly say in advanced search that you are searching call number, and then go to Z39.50 from those results rather than going to Cataloging - New from Z39.50 when you've given up on your search results and want to start from scratch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes how the Z39.50 release notes| |search form is populated | |when using the Z39.50/SRU | |search option, from | |advanced search results in | |the staff interface where a | |"Call number" search is | |made. It now autofills the | |searched for value in the | |"Dewey" field instead of | |the "Title" field. | | | |(Even | |though the field is | |labelled "Dewey", it also | |searches for Library of | |Congress call numbers in | |the 050 tag. Note that | |there are other issues with | |the search form, the labels | |used, and what is actually | |searched for - there are | |separate bugs for these). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37167 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org