http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #2 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9310&action=edit CSV of US Presidential Quotes for Testing -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #4 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9323&action=edit Updating-datatables.css-to-reflect-changes-from-v1.8 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #6 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9325&action=edit Adding-DateTime-Format-MySQL-as-a-core-dependency -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #8 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9327&action=edit QOTD-uploader -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9328|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #12 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9373&action=edit Adding sanity checks to verify file type and size -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9373|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9327|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #15 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9378&action=edit Misc UI improvements to both the QOTD editor and uploader including a number suggested by jcamins Also removing a debug warn -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- I have some issues with the staff client pages: 1. The pages have no headings. Both the main page and the upload page should show the name of the page. 2. The templates don't obey capitalization rules addressed by Bug 2780 ("Import Quotes" should be "Import quotes"). 3. The buttons in the toolbar have a custom style applied to them. Instead of making them different from other toolbar buttons they should be generated using the same code other toolbars use. 4. The comment in the toolbar ("Click Source or Text field...") belongs somewhere else. We don't have a well-established pattern for text like this, but the "Authorised values" page offers a possible example (/cgi-bin/koha/admin/authorised_values.pl). 5. I think it would be nice to have a compact table pager at the top in addition to the full pager at the bottom. 6. The "actions" columns should not be sortable. 7. datatables.css adds "border-radius: 5px;" to all inputs. This kind of broad style change shouldn't be happening in a module-specific CSS file. It could be qualified so that it applies only to datatables-related inputs. IMO it should be removed altogether because it doesn't look consistently good across browsers. 8. The "import quotes" page lacks any kind of instructions. Perhaps it should at least specify what format it expects? 9. The upload form on the import is in the toolbar div. It belongs in the main body of the page, preferably in a <fieldset> with a descriptive <legend> 10. The "save quotes" button doesn't belong in the toolbar. Generally sava buttons are at the bottom of tables, although some pages have them at the top. In any case putting it in the toolbar makes its purpose unclear. It wasn't clear to me that I had to click "save quotes" to complete the process. 11. The breadcrumbs on the import page should give the user a path back to the main quotes page: "Home > Tools > Quote editor > Quote uploader." -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9392|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9377|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #19 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9405&action=edit Quote-of-the-day (QOTD) Feature for OPAC This feature will add the option of displaying a select quote for the day on the OPAC homepage. It will include the addition of a QOTD editor in the tools section of the staff interface which will allow the addition, editing, and deletion of quotes. A single system preference will enable/disable the display of the QOTD on the OPAC homepage. A new granular permission will also be added to conrol user access to the QOTD editor tool. Possible extentions to this would be code to allow alternate quote selection algorithms to be added to vary how the currently displayed quote is selected from the table of quotes. This patch is a squash of the following work: --Adding quotes table to kohastructure.sql and updatedatabase.pl Note: This patch is intended for a MySQL based installation only. That means that it includes backticks because that is what is required at this point in history to install Koha correctly on a MySQL based installation. Feel free to port this over to the Pg stuff in the data/Pg directory. --Adding system preference to control display of QOTD on OPAC main page --Adding sample quote data These quotes are taken from various US presidents. I'm not sure these are applicable to the rest of the world, so I'm leaving it to translators and others to add sample quote data for other languages. --Adding edit_quotes user permissions --Squash with other db related patches in this series --Adding quotes editor pages to tools --Adding QOTD editor link to tools homepage --Integration of DataTables into QOTD Editor --Impleminting jEditable into the quote editor --Adding delete and add option to editor --Fixing OPAC display so the QOTD div does not show if no quote is returned --Also removing useless code from tools/quotes.pl --Adding spans around QOTD foo in opac-main.tt --Also fixing quote selection logic to accomodate the possibility of a single quote in the db a litte better. --Changing timestamp column header to a more user-friendly 'Last Displayed' --Fixing bug in quote selection logic. This bug caused a situation where when the table had only a single quote with an id greater than 1 in it, no quote would be selected. --Fixing up sorting in the quote editor table. --jcamins --Adding span element to quote separator --jcamins --Overriding the default empty table message supplied by datatables-strings.inc --Adds missing page heading --Adds beginning of click-for-help elements. --Refactors delete functionality to allow selecting of quotes to delete, enabling multi-delete. --Refactors saving added quote functionality so that striking <Enter> saves the new quote. --Refactors canceling aded quote functionality so that striking <Esc> cancels the new quote. --Removing debug console.log statements --Implementng the YUI button widget/toolbar used on other pages. --Adds a 5px radius to all YUI buttons to bring them into conformity with the general trend toward rounded corners --Fixes capitalization in quote editor --Implements improvements suggested by jcamins and oleonard --Adds DataTables Plugin dataTables.fnReloadAjax.js -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9405|0 |1 is obsolete| | --- Comment #21 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9407&action=edit Quote-of-the-day (QOTD) Feature for OPAC This feature will add the option of displaying a select quote for the day on the OPAC homepage. It will include the addition of a QOTD editor in the tools section of the staff interface which will allow the addition, editing, and deletion of quotes. A single system preference will enable/disable the display of the QOTD on the OPAC homepage. A new granular permission will also be added to conrol user access to the QOTD editor tool. Possible extentions to this would be code to allow alternate quote selection algorithms to be added to vary how the currently displayed quote is selected from the table of quotes. This patch is a squash of the following work: --Adding quotes table to kohastructure.sql and updatedatabase.pl Note: This patch is intended for a MySQL based installation only. That means that it includes backticks because that is what is required at this point in history to install Koha correctly on a MySQL based installation. Feel free to port this over to the Pg stuff in the data/Pg directory. --Adding system preference to control display of QOTD on OPAC main page --Adding sample quote data These quotes are taken from various US presidents. I'm not sure these are applicable to the rest of the world, so I'm leaving it to translators and others to add sample quote data for other languages. --Adding edit_quotes user permissions --Squash with other db related patches in this series --Adding quotes editor pages to tools --Adding QOTD editor link to tools homepage --Integration of DataTables into QOTD Editor --Impleminting jEditable into the quote editor --Adding delete and add option to editor --Fixing OPAC display so the QOTD div does not show if no quote is returned --Also removing useless code from tools/quotes.pl --Adding spans around QOTD foo in opac-main.tt --Also fixing quote selection logic to accomodate the possibility of a single quote in the db a litte better. --Changing timestamp column header to a more user-friendly 'Last Displayed' --Fixing bug in quote selection logic. This bug caused a situation where when the table had only a single quote with an id greater than 1 in it, no quote would be selected. --Fixing up sorting in the quote editor table. --jcamins --Adding span element to quote separator --jcamins --Overriding the default empty table message supplied by datatables-strings.inc --Adds missing page heading --Adds beginning of click-for-help elements. --Refactors delete functionality to allow selecting of quotes to delete, enabling multi-delete. --Refactors saving added quote functionality so that striking <Enter> saves the new quote. --Refactors canceling aded quote functionality so that striking <Esc> cancels the new quote. --Removing debug console.log statements --Implementng the YUI button widget/toolbar used on other pages. --Adds a 5px radius to all YUI buttons to bring them into conformity with the general trend toward rounded corners --Fixes capitalization in quote editor --Implements improvements suggested by jcamins and oleonard --Adds DataTables Plugin dataTables.fnReloadAjax.js -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #23 from Chris Nighswonger <cnighswonger@foundations.edu> --- These two patches reflect several bug-fixes, improvements, js refactoring, and address points 1,2,3,6 & 11 of Owen's concerns. More work will be forthcoming to address most of Owen's remaining points as well as to ensure translatability and add more click-helps as well as Koha's standard help. Marking this as "In Discussion" because that best represents the status of this bug at this time. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #25 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9433&action=edit Further UI work on the QOTD uploader This patch addresses another of oleonard's points as well as some general cleanup: --Adds instructions to each stage of the uploader --Consolidates quote tool css into quotes.css -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #27 from Chris Nighswonger <cnighswonger@foundations.edu> --- The last four patches attached here incorporate the majority of oleonard's recommendations as well as various improvements including the marking of JS strings for translatability. NOTE FOR TESTERS: These last four patches are new, so you will have to roll off any previous versions of them prior to applying the new ones. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5184 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #29 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9441&action=edit Adding Daily Quotes Tests to Koha.t test suite; also fixing sort order on quote selection SQL -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9441|0 |1 is obsolete| | --- Comment #31 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9443&action=edit Adding Daily Quotes Tests to Koha.t test suite; also fixing sort order on quote selection SQL -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9321|0 |1 is obsolete| | --- Comment #34 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9474&action=edit Bug 7977: Upgrading DataTables library to 1.9.1 Previous versions of the DataTables library did not support listeners for custom DataTabels events. These listeners are necessary to the "add quote" feature of the QOD editor. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #36 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9476&action=edit Fixing C4::Koha import -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9325|0 |1 is obsolete| | --- Comment #38 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9478&action=edit Bug 7977: Adding DateTime::Format::MySQL as a core dependency Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9409|0 |1 is obsolete| | --- Comment #40 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9480&action=edit Bug 7977: QOTD uploader to enable uploading csv files containing quotes This series will add a DataTable's based upload/editor with which to upload csv files containing quotes to be used by the QOTD feature. The file should be formatted thusly: "source","text-of-quote" "source","text-of-quote" ... Note: This work serves as a good example of potential improvements in all other "editor" and file upload areas of Koha. This patch is a squash of the following work: --Adding code to parse CSV file contents and push it into a DataTable --Adding in jEditable to enable table editing --Adding ajax to post data back to the server to be saved --Fixing edit and adding delete functionality --Adding some missing css as well as server feedback on save --Fixing a bug which limited the number of quotes which could be uploaded --Also fixing a minor bug with fnCSVToArray and doing some style cleanup. --Adding sanity checks to verify file type and size --Implements YUI button widget/toolbar --Improved handling of hiding uploader UI --Adds row selectability --Adds multi-delete capability --Adds YUI button/toolbar widget --Fixing capitalization in quote uploader --Implements improvments suggested by jcamins and oleonard Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9434|0 |1 is obsolete| | --- Comment #42 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9482&action=edit Bug 7977: Further UI work on the QOTD editor This patch implements more of oleonard's suggestions as well as other improvments: --Adds instructions for using the QOTD editor --Moves inline css to quotes.css, etc. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9442|0 |1 is obsolete| | --- Comment #44 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9484&action=edit Bug 7977: Fixing quote sample data timestamps Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9447|0 |1 is obsolete| | --- Comment #46 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9486&action=edit Bug 7977: Adding Koha standard help files for QOTD feature Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #47 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment for Bug 7977: Upgrading DataTables library to 1.9.1 Bug 7977: Updating datatables.css to reflect changes from v1.8.1 to v1.9.1 Bug 7977: Adding jEditable minified version Bug 7977: Adding DateTime::Format::MySQL as a core dependency Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #49 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Following patches look good. Just... the link in your help page does not exist (http://manual.koha-community.org/3.8/en/QOTDuploader.html). I don't know if it is normal or not :-/ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #51 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #49)

QA comment: Following patches look good.

Just... the link in your help page does not exist (http://manual.koha-community.org/3.8/en/QOTDuploader.html). I don't know if it is normal or not :-/

This is because no links exist atm. I mentioned this to Nicole on #koha the other day. These are really just "placeholders" which can be either used by her or a followup patch submitted once she has the info in the manual. Perhaps we should have a procedure for this, though, so I'll suggest that to her. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #53 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9503&action=edit Followup patch addressing items pointed out by Jonathan Druart -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9503|0 |1 is obsolete| | --- Comment #55 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9504&action=edit Followup patch addressing items pointed out by Jonathan Druart -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #57 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #55)

Created attachment 9504 [details] Followup patch addressing items pointed out by Jonathan Druart

Hi Chris, Thanks for your followup. However, I think the following syntax is not usable: $iTotalRecords = $dbh->selectrow_array("SELECT count(*) FROM quotes WHERE id LIKE %?% OR source LIKE %?% OR text LIKE %?% OR timestamp LIKE %?%;",undef,($filter, $filter, $filter, $filter)); You can write this like: $iTotalRecords = $dbh->selectrow_array("SELECT count(*) FROM quotes WHERE id LIKE ? OR source LIKE ? OR text LIKE ? OR timestamp LIKE ?;",undef,("%$filter%")x4); -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #59 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #57)

(In reply to comment #55)

...

Created attachment 9504 [details] Followup patch addressing items pointed out by Jonathan Druart

Hi Chris, Thanks for your followup.

However, I think the following syntax is not usable:

$iTotalRecords = $dbh->selectrow_array("SELECT count(*) FROM quotes WHERE id LIKE %?% OR source LIKE %?% OR text LIKE %?% OR timestamp LIKE %?%;",undef,($filter, $filter, $filter, $filter));

You can write this like:

$iTotalRecords = $dbh->selectrow_array("SELECT count(*) FROM quotes WHERE id LIKE ? OR source LIKE ? OR text LIKE ? OR timestamp LIKE ?;",undef,("%$filter%")x4);

This is actually unused due to the removal of server-side processing, so I've attached another followup removing it from quotes_ajax.pl Thanks! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #61 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9521&action=edit Bug 7977: Improving upload result message display -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9517|0 |1 is obsolete| | --- Comment #63 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9530&action=edit Bug 7977: Fixing a bug which results in quote fields being incorrectly offset when saving uploaded quotes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #65 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- All follow-ups signed off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #67 from Chris Nighswonger <cnighswonger@foundations.edu> --- As this bug appears to have passed QA, please set the status accordingly so this can be pushed on to master. It will be difficult to keep rebased if too much time elapses. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Ian Walls <koha.sekjal@gmail.com> --- QA comments: 1) Introduces a new system dependency, DateTime::Format::MySQL, which only seems to be used to format datetimes into ISO for querying the quotes table. We already have Koha::DateUtils, which can process a datetime in ISO, or many other formats, so I'm not seeing the need to add a dependency on DateTime::Format::MySQL. Does this module do something more that I'm missing? 2) Also, the varchar(45) on the 'source' for the quote seems a bit short... I think having this as a 'text' field would provide more flexibility. 3) Minor typo in tools/quotes-upload.tt: "...you will be promoted to..." should be "...you will be prompted to..." 4) Link to documentation is hardcoded to 3.8 manual page... should it be this way? Won't that require maintenance every release, to keep pointing at the right version? 5) Hardcoded styling in tools/quotes.tt (the <p> under <h1>QOTD Editor</h1>) Marking as Failed QA primarily for 1), but 3) and 5) need t be addressed, as well. 2) and 4) are up for discussion. I think this would be a prime candidate for a Plugin as per Bug 7804... it seems like a pretty stand-alone thing, if it's basic requirements are met. The only complication I see is getting permissions handled properly, but that's just a matter of a small database update script, which would need to run anyway to install the table. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #71 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #69)

QA comments:

1) Introduces a new system dependency, DateTime::Format::MySQL, which only seems to be used to format datetimes into ISO for querying the quotes table. We already have Koha::DateUtils, which can process a datetime in ISO, or many other formats, so I'm not seeing the need to add a dependency on DateTime::Format::MySQL. Does this module do something more that I'm missing?

Looking at the perldoc for Koha::DateUtils it appears that we are transitioning to DateTime and that the K::DU module is merely meant to ease that transition by hiding "the complexity of switch to DateTime." I would suggest that using DateTime::Format::MySQL is the better approach as we work toward phasing out Koha::DateUtils and moving completely to DateTime. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #73 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #69)

QA comments:

3) Minor typo in tools/quotes-upload.tt: "...you will be promoted to..." should be "...you will be prompted to..."

5) Hardcoded styling in tools/quotes.tt (the <p> under <h1>QOTD Editor</h1>)

I'll fix these in the followup as well. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #75 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #69)

QA comments:

I think this would be a prime candidate for a Plugin as per Bug 7804... it seems like a pretty stand-alone thing, if it's basic requirements are met. The only complication I see is getting permissions handled properly, but that's just a matter of a small database update script, which would need to run anyway to install the table.

I've pretty much burned up the hours allotted for development on this feature, so I will not be able to port it over to a plugin. That does not, however, prevent someone else from doing so if that is desirable. Or for funding the additional hours needed to do so. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #77 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9683&action=edit Fixing a typo in the quotes-upload help file and hardcoded css -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #79 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #78)

These patches address #'s 2,3,5 of Ian's concerns.

I'd like to have a better handle on our long term use of Koha::DateUtils before removing DateTime::Format::MySQL.

It was my understanding that Koha::DateUtils was a transitory package, perhaps we could check with Colin Campbell. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #81 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #80)

Ah, I must have missed that about Koha::DateUtils. No need to recreate the wheel if we can include another stable, Debian-packaged library. If we're going to phase it out, then using DateTime::Format::__something__ makes sense, though __something__ == MySQL could be coding us into a corner when Postgres support roles along.

It should be trivial to add code to check kohaconf.xml for our DB flavor and load the appropriate module. This will be a broad issue I suspect. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9474|0 |1 is obsolete| | Attachment #9475|0 |1 is obsolete| | Attachment #9477|0 |1 is obsolete| | Attachment #9478|0 |1 is obsolete| | Attachment #9479|0 |1 is obsolete| | Attachment #9480|0 |1 is obsolete| | Attachment #9481|0 |1 is obsolete| | Attachment #9482|0 |1 is obsolete| | Attachment #9483|0 |1 is obsolete| | Attachment #9484|0 |1 is obsolete| | Attachment #9485|0 |1 is obsolete| | Attachment #9486|0 |1 is obsolete| | Attachment #9505|0 |1 is obsolete| | Attachment #9529|0 |1 is obsolete| | Attachment #9530|0 |1 is obsolete| | Attachment #9531|0 |1 is obsolete| | Attachment #9682|0 |1 is obsolete| | Attachment #9683|0 |1 is obsolete| | Attachment #9711|0 |1 is obsolete| | --- Comment #83 from Mason James <mtj@kohaaloha.com> --- Created attachment 9712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9712&action=edit Bug 7977: Upgrading DataTables library to 1.9.1 Previous versions of the DataTables library did not support listeners for custom DataTabels events. These listeners are necessary to the "add quote" feature of the QOD editor. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #85 from Mason James <mtj@kohaaloha.com> --- Created attachment 9714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9714&action=edit Bug 7977: Adding jEditable minified version jEditable is necessary to create DataTables with editable fields Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #87 from Mason James <mtj@kohaaloha.com> --- Created attachment 9716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9716&action=edit Bug 7977: Quote-of-the-day (QOTD) Feature for OPAC This feature will add the option of displaying a select quote for the day on the OPAC homepage. It will include the addition of a QOTD editor in the tools section of the staff interface which will allow the addition, editing, and deletion of quotes. A single system preference will enable/disable the display of the QOTD on the OPAC homepage. A new granular permission will also be added to conrol user access to the QOTD editor tool. Possible extentions to this would be code to allow alternate quote selection algorithms to be added to vary how the currently displayed quote is selected from the table of quotes. This patch is a squash of the following work: --Adding quotes table to kohastructure.sql and updatedatabase.pl Note: This patch is intended for a MySQL based installation only. That means that it includes backticks because that is what is required at this point in history to install Koha correctly on a MySQL based installation. Feel free to port this over to the Pg stuff in the data/Pg directory. --Adding system preference to control display of QOTD on OPAC main page --Adding sample quote data These quotes are taken from various US presidents. I'm not sure these are applicable to the rest of the world, so I'm leaving it to translators and others to add sample quote data for other languages. --Adding edit_quotes user permissions --Squash with other db related patches in this series --Adding quotes editor pages to tools --Adding QOTD editor link to tools homepage --Integration of DataTables into QOTD Editor --Impleminting jEditable into the quote editor --Adding delete and add option to editor --Fixing OPAC display so the QOTD div does not show if no quote is returned --Also removing useless code from tools/quotes.pl --Adding spans around QOTD foo in opac-main.tt --Also fixing quote selection logic to accomodate the possibility of a single quote in the db a litte better. --Changing timestamp column header to a more user-friendly 'Last Displayed' --Fixing bug in quote selection logic. This bug caused a situation where when the table had only a single quote with an id greater than 1 in it, no quote would be selected. --Fixing up sorting in the quote editor table. --jcamins --Adding span element to quote separator --jcamins --Overriding the default empty table message supplied by datatables-strings.inc --Adds missing page heading --Adds beginning of click-for-help elements. --Refactors delete functionality to allow selecting of quotes to delete, enabling multi-delete. --Refactors saving added quote functionality so that striking <Enter> saves the new quote. --Refactors canceling aded quote functionality so that striking <Esc> cancels the new quote. --Removing debug console.log statements --Implementng the YUI button widget/toolbar used on other pages. --Adds a 5px radius to all YUI buttons to bring them into conformity with the general trend toward rounded corners --Fixes capitalization in quote editor --Implements improvements suggested by jcamins and oleonard --Adds DataTables Plugin dataTables.fnReloadAjax.js Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #89 from Mason James <mtj@kohaaloha.com> --- Created attachment 9718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9718&action=edit Bug 7977: Further UI work on the QOTD uploader This patch addresses another of oleonard's points as well as some general cleanup: --Adds instructions to each stage of the uploader --Consolidates quote tool css into quotes.css Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #91 from Mason James <mtj@kohaaloha.com> --- Created attachment 9720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9720&action=edit Bug 7977: Fixing captialization on the tools main page Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #93 from Mason James <mtj@kohaaloha.com> --- Created attachment 9722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9722&action=edit Bug 7977: Fixing quote sample data timestamps Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #95 from Mason James <mtj@kohaaloha.com> --- Created attachment 9724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9724&action=edit Bug 7977: Adding Daily Quotes Tests to Koha.t test suite; also fixing sort order on quote selection SQL Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #97 from Mason James <mtj@kohaaloha.com> --- Created attachment 9726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9726&action=edit Bug 7977: Followup patch addressing items pointed out by Jonathan Druart Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #99 from Mason James <mtj@kohaaloha.com> --- Created attachment 9728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9728&action=edit Bug 7977: Fixing a bug which results in quote fields being incorrectly offset when saving uploaded quotes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #101 from Mason James <mtj@kohaaloha.com> --- Created attachment 9730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9730&action=edit Making source a text field rather than a varchar to avoid potential length limitations http://bugs.koha-community.org/show_bug.cgi?id=7977 Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #103 from Mason James <mtj@kohaaloha.com> --- Created attachment 9732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9732&action=edit add edit_quotes to es-ES/mandatory/userpermissions.sql Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #105 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #104)

(In reply to comment #66)

...

QA comments:

I think these patchs can be passed QA.

Given the length and the complexity of this development I prefer to need additional QA.

hi Jonathon ^^^^^ oups, sorry about the spelling Jonathan!

passing QA on this applied cleanly to 804b073a8274d9f719ef746d74198ade735dc620 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #107 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #106)

2nd QA comment: * this patch does not respect UC on 1st word only that is applied everywhere in Koha now. I've added a follow-up

Thanks for fixing the spots I missed that in during my followup for it.

About the Adding-DateTime-Format-MySQL-as-a-core-dependency => could there be another interesting use of this package ?

I'm sure that anywhere we need DateTime formatting in MySQL format this will be useful. It takes Koha::DateUtils one step closer to being phased out. :-) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Bug 7977 depends on bug 5184, which changed state. Bug 5184 Summary: Upgrade jQuery to the latest version http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Bug 7977 depends on bug 5184, which changed state. Bug 5184 Summary: Upgrade jQuery to the latest version http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.