[Bug 20685] New: Modify notice page for HOLD SLIP rendering incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Bug ID: 20685 Summary: Modify notice page for HOLD SLIP rendering incorrectly Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When I enter the following text into the Email template for 'HOLD_SLIP' in Home › Tools › Notices & Slips › Modify notice... <div style='max-width: 4in;'> <h3><<borrowers.surname>>, <<borrowers.firstname>></h3><br /> <<borrowers.streetnumber>> <<borrowers.address>><br /> <<borrowers.address2>><br /> <<borrowers.city>>, <<borrowers.state>> <<borrowers.zipcode>><br /> <br /> <br /> <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Then save, the final line of text renders as <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> When I navigate back to the modify notice page for HOLD_SLIP. The text is correct in letter.content. I've replicated the issue in 17.05 and 17.11 using both firefox and chrome. Note that simply pasting the last line of text into an existing notice doesn't cause the display issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75022&action=edit Bug 20685: Escape letter template content in textarea Test plan: enter the following text into the Email template for 'HOLD_SLIP' in Home › Tools › Notices & Slips › Modify notice <div style='max-width: 4in;'> <h3><<borrowers.surname>>, <<borrowers.firstname>></h3><br /> <<borrowers.streetnumber>> <<borrowers.address>><br /> <<borrowers.address2>><br /> <<borrowers.city>>, <<borrowers.state>> <<borrowers.zipcode>><br /> <br /> <br /> <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Edit it again Without this patch you will get: <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master Severity|minor |normal Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75022|0 |1 is obsolete| | --- Comment #2 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 75039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75039&action=edit Bug 20685: Escape letter template content in textarea Test plan: enter the following text into the Email template for 'HOLD_SLIP' in Home › Tools › Notices & Slips › Modify notice <div style='max-width: 4in;'> <h3><<borrowers.surname>>, <<borrowers.firstname>></h3><br /> <<borrowers.streetnumber>> <<borrowers.address>><br /> <<borrowers.address2>><br /> <<borrowers.city>>, <<borrowers.state>> <<borrowers.zipcode>><br /> <br /> <br /> <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Edit it again Without this patch you will get: <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75039|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75046&action=edit Bug 20685: Escape letter template content in textarea Test plan: enter the following text into the Email template for 'HOLD_SLIP' in Home › Tools › Notices & Slips › Modify notice <div style='max-width: 4in;'> <h3><<borrowers.surname>>, <<borrowers.firstname>></h3><br /> <<borrowers.streetnumber>> <<borrowers.address>><br /> <<borrowers.address2>><br /> <<borrowers.city>>, <<borrowers.state>> <<borrowers.zipcode>><br /> <br /> <br /> <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Edit it again Without this patch you will get: <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Modify notice page for HOLD |Modify letter template does |SLIP rendering incorrectly |not render incorrectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 --- Comment #5 from Barton Chittenden <barton@bywatersolutions.com> --- Can we get this backported? I'm editing the slip in question, and it's causing all sorts of inconvenience. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Modify letter template does |Modify letter template does |not render incorrectly |not render correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org