[Bug 23227] New: Remove type attribute from script tags: Reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Bug ID: 23227 Summary: Remove type attribute from script tags: Reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 22956 This patch will remove the obsolete "type" attribute from <script> tags in the following reports templates: - intranet-tmpl\prog\en\modules\reports\dictionary.tt - intranet-tmpl\prog\en\modules\reports\itemslost.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956 [Bug 22956] Omnibus: Remove type attribute from script tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91054&action=edit Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from <script> tags in two reports templates. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Reports -> Dictionary - Delete - Specifying a date range for a date column - Reports -> Items lost - Report results -> Datatables functionality -> Selection tools for export Validating the HTML source of any of these pages should return no errors related to the "type" attribute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91054|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 91299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91299&action=edit Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from <script> tags in two reports templates. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Reports -> Dictionary - Delete - Specifying a date range for a date column - Reports -> Items lost - Report results -> Datatables functionality -> Selection tools for export Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91299|0 |1 is obsolete| | --- Comment #3 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 91352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91352&action=edit Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from <script> tags in two reports templates. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Reports -> Dictionary - Delete - Specifying a date range for a date column - Reports -> Items lost - Report results -> Datatables functionality -> Selection tools for export Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Frédérik Chénier <frederik.chenier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91352|0 |1 is obsolete| | --- Comment #4 from Frédérik Chénier <frederik.chenier@inlibro.com> --- Created attachment 91353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91353&action=edit Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from <script> tags in two reports templates. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Reports -> Dictionary - Delete - Specifying a date range for a date column - Reports -> Items lost - Report results -> Datatables functionality -> Selection tools for export Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91353|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91387&action=edit Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from <script> tags in two reports templates. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Reports -> Dictionary - Delete - Specifying a date range for a date column - Reports -> Items lost - Report results -> Datatables functionality -> Selection tools for export Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org