[Bug 23697] New: autocompletion search in patron module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Bug ID: 23697 Summary: autocompletion search in patron module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: stephane.delaye@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com How add autocompletion search in patron module. with jquery it's possible like this $(document).ready(function(){ $( '#searchmember' ).autocomplete({ source: function(request, response) { $.ajax({ url: "/cgi-bin/koha/circ/ysearch.pl", dataType: "json", data: { term: request.term }, success: function(data) { response( $.map( data, function( item ) { return { label: item.surname + " , " + item.firstname + " .-Date of birth naissance: " + item.dateofbirth + " .-Address: " + item.address + " .-City:" + item.city, value: item.surname + " " + item.firstname } })); } }); }, minLength: 1, }); }); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 93443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93443&action=edit Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93443|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 93476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93476&action=edit Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|autocompletion search in |Auto complete for patron |patron module |search in patron module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |oleonard@myacpl.org --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works fine! Just have a little 'but': For the patron auto-complete we got a system preference to turn the feature off: CircAutocompl So my question would be: Should we also use this pref here? Does it need a pref? I am setting 'Failed QA' - let's discuss this quickly tomorrow. Also adding Owen in CC as he might know about the reasoning behind the pref in circulation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After discussing with Owen, I think it would be best if we use the pref for this as well and update the wording of the pref a little bit to cover both. Matts, could you provide a follow-up please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #5 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Any hint on what the syspref should be renamed to? PatronAutoCompl? And why not PatronAutoCompletion, since truncated words are ugly and may me meaningless to some people? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Matthias Meusburger from comment #5)
Any hint on what the syspref should be renamed to?
PatronAutoCompl?
And why not PatronAutoCompletion, since truncated words are ugly and may me meaningless to some people?
I actually meant only correcting the description (although you have a point about it being a bit ugly :) ) Now: [Don't try|Try] to guess the patron being entered while typing a patron search on the circulation screen. Only returns the first 10 results at a time. Maybe change to: [Don't try|Try] to guess the patron being entered while typing a patron search for circulation or patron search. Only returns the first 10 results at a time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- How about: [Don't try|Try] to guess the patron when typing a name in the circulation check out and patron search screens. Only shows the first 10 results. Like the idea of making the preference name PatronAutoCompletion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #8 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 93721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93721&action=edit Bug 23697, Follow-up: Add autocompletion search in patron module - Rename CircAutocompl system preference to PatronAutocompletion - Take this system preference into consideration for patron search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93476|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93721|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93738&action=edit Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93739&action=edit Bug 23697, Follow-up: Add autocompletion search in patron module - Rename CircAutocompl system preference to PatronAutocompletion - Take this system preference into consideration for patron search Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93738|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93832&action=edit Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93833&action=edit Bug 23697: (follow-up) Add autocompletion search in patron module - Rename CircAutocompl system preference to PatronAutocompletion - Take this system preference into consideration for patron search Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93834&action=edit Bug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete Just a find and replace on the changed system preference name. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93739|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93832|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93835&action=edit Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93833|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93836&action=edit Bug 23697: (follow-up) Add autocompletion search in patron module - Rename CircAutocompl system preference to PatronAutocompletion - Take this system preference into consideration for patron search Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93834|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93837&action=edit Bug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete Just a find and replace on the changed system preference name. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93838&action=edit Bug 23697: (QA follow-up) Fix quotes in database update statement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Auto complete for patron |Add auto complete for |search in patron module |patron search in patron | |module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an release notes| |optional auto-complete | |function to the patron | |search field when in the | |patrons module. | | | |We rename | |the `CircAutocompl` system | |preference to | |`PatronAutoComplete` and | |use it for both functions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds an |This enhancement adds an release notes|optional auto-complete |optional auto-complete |function to the patron |function to the patron |search field when in the |search field when in the |patrons module. |patrons module. | | |We rename |The |the `CircAutocompl` system |`CircAutocompl` system |preference to |preference is renamed to |`PatronAutoComplete` and |`PatronAutoComplete` and |use it for both functions. |use for both the | |circulation and patrons | |module auto-complete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26125 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26125 [Bug 26125] In 'Patrons Patron search' tab open checkout screen not patron detail screen -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org