https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | Severity|enhancement |normal Summary|Dead report code since |Dead report code for |before 3.0.x |"Create Compound Report" | |since prior to 3.0.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 74871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74871&action=edit Bug 20663: Remove dead code related to compound reports TEST PLAN --------- git grep "Create Compound Report" -- only one file git grep compound | grep 1 -- this is the only setting of the compound tt variable less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt -- There is an TT IF statement for compound. -- In that statement it would trigger 'Save Compound' git grep save_compound -- only the template and the guided report perl git grep create_compound -- only triggered by the save code in the guided report perl -- in the export for the C4/Reports/Guided.pm git grep run_compound -- left over in export apply the patch look around and see the pieces are cleaned up. run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74871|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74925&action=edit Bug 20663: Remove dead code related to compound reports TEST PLAN --------- git grep "Create Compound Report" -- only one file git grep compound | grep 1 -- this is the only setting of the compound tt variable less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt -- There is an TT IF statement for compound. -- In that statement it would trigger 'Save Compound' git grep save_compound -- only the template and the guided report perl git grep create_compound -- only triggered by the save code in the guided report perl -- in the export for the C4/Reports/Guided.pm git grep run_compound -- left over in export apply the patch look around and see the pieces are cleaned up. run koha qa test tools Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Isn't this patch supposed to have the Signed-off status? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74926|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75056&action=edit Bug 20663: Add some POD, so koha test tools don't complain Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Dead since commit 68ce64a793b023164ac19a56602747945a1bdca1 Date: Mon Oct 29 13:19:58 2007 -0500 Bugfixing the template, and removing link to compound reports -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.