[Bug 20625] New: Cannot add new patron category without currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 Bug ID: 20625 Summary: Cannot add new patron category without currency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Internal server errror on clicking New category in Admin/Patron categories Template process failed: undef error - Can't call method "p_sep_by_space" on an undefined value at /usr/share/koha/devclone/Koha/Number/Price.pm line 126. Sub _format_params assumes that there is an active currency. (Which was not there yet in a new installed system.) Since we are showing an empty page here, I do not see the need of a currency for just formatting a zero or null value ?? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #1 from Liz Rea <liz@catalyst.net.nz> --- Maybe add the currency selection into the onboarder, before you add a patron category (if the "currency" sample data isn't selected) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18888 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4078 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 18e72e31957a51206875ac27d92929909a90ef34 Bug 4078: Add the ability to display and configure the symbol for prices Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Add the ability to customize and display the symbol for a currency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74737&action=edit Bug 20625: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74738&action=edit Bug 20625: Handle non existing of active currency This patch avoid the explosion in the air when creating a new patron category and no active currency is defined. Test plan: Remove the currencies, create a new patron category Without this patch applied you will get Can't call method "p_sep_by_space" on an undefined value With this patch the form will be displayed correctly and you will be able to create the patron category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74737|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 74740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74740&action=edit Bug 20625: Add tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74738|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 74741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74741&action=edit Bug 20625: Handle non existing of active currency This patch avoid the explosion in the air when creating a new patron category and no active currency is defined. Test plan: Remove the currencies, create a new patron category Without this patch applied you will get Can't call method "p_sep_by_space" on an undefined value With this patch the form will be displayed correctly and you will be able to create the patron category Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset@hotmail.com --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Test only applied, kaboom. With patch, no kaboom. And code change eyeballs well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74740|0 |1 is obsolete| | Attachment #74741|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74774&action=edit Bug 20625: Add tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74775&action=edit Bug 20625: Handle non existing of active currency This patch avoid the explosion in the air when creating a new patron category and no active currency is defined. Test plan: Remove the currencies, create a new patron category Without this patch applied you will get Can't call method "p_sep_by_space" on an undefined value With this patch the form will be displayed correctly and you will be able to create the patron category Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20625 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org