[Bug 32910] New: Upgrade fontawesome icons to V6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Bug ID: 32910 Summary: Upgrade fontawesome icons to V6 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146396&action=edit Bug 32910: Adjust fontawesome icons ref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146396|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I had a quick try at upgrading to V6, but it needs more attention. Especially a better focus on those 2 pages: https://fontawesome.com/v5/docs/web/setup/upgrade-from-v4 https://fontawesome.com/docs/web/setup/upgrade/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I didn't manage to attach the patches here, see https://gitlab.com/joubu/Koha/-/commits/bug_32910 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I have made some follow-up changes: https://gitlab.com/koha-dev/koha-dev/-/tree/bug_32910 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff URL| |https://gitlab.com/koha-dev | |/koha-dev/-/tree/bug_32910 Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I tested Owens branch and couldn't find any obvious regressions, it's looking great and I can't wait to start using the new set. I'm going to mark the bug as signed off, please add my SO line to the relevant branch when appropriate :). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Jonathan we're already installing some Font Awesome assets via npm, correct? For ERM? I'm wondering if we shouldn't also get the FA SCSS from there and add it to the SCSS build. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #6)
Jonathan we're already installing some Font Awesome assets via npm, correct? For ERM? I'm wondering if we shouldn't also get the FA SCSS from there and add it to the SCSS build.
Yes, we are using some fontawesome vue modules, but not a lot, and not for all the icons we use in vue files. See the output of % git grep awesome koha-tmpl/intranet-tmpl/prog/js/vue # Vue module vs % git grep fa- koha-tmpl/intranet-tmpl/prog/js/vue # Not vue module At this point we should actually the vue module them from there. The problem is that we are using edit/show/delete icons in the "Actions" columns of the tables, and we cannot use them there. So, yes, we could install them differently, but not because we are doing it differently for Vue ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think it's a great idea to shift installation of these assets to the build process.. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Let push and see how it goes? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Signed-off-by lines and rebase at ttps://gitlab.com/joubu/Koha/-/commits/bug_32910 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/koha-dev |https://gitlab.com/joubu/Ko |/koha-dev/-/tree/bug_32910 |ha/-/commits/bug_32910 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Signed-off-by lines and rebase at https://gitlab.com/joubu/Koha/-/commits/bug_32910 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Patch doesn't apply --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Owen, can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Any chance for this one still? I'd like to pick a new icon for inventory from the newer version :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #9)
Let push and see how it goes?
This was more than 2 months ago, to have time to fix before the release. Now we are few weeks before the release. Why did we have wait so much time to push it? These patches are unnecessary painful to rebase! Are we part of a kind of masochist secret group? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Too many conflicts, I am giving up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- On top of the remote branch, I think there are some occurrences missing % git grep '\-o"' **/*.tt **/*.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #14)
(In reply to Jonathan Druart from comment #9)
Let push and see how it goes?
This was more than 2 months ago, to have time to fix before the release. Now we are few weeks before the release. Why did we have wait so much time to push it?
I was willing to push it once I noticed it existed, but it already needed a rebase. I guess we've been busy with other things... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- I've rebased this branch: https://gitlab.com/koha-dev/koha-dev/-/tree/bug_32910 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #18)
I've rebased this branch
Before seeing comment 16, so there are still a few missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Early push candidate for 23.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Thanks Owen! I think there is this one left: koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt: .fa-file-archive-o { Also, are you sure we need v4-shims? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> ---
koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt: .fa-file-archive-o {
Remote branch rebased again and updated to fix a couple more missing references and to remove unused assets from the staff interface and OPAC https://gitlab.com/koha-dev/koha-dev/-/tree/bug_32910 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33988 [Bug 33988] Font awesome fa-gears on staff main page look wrong after upgrade to FA6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33998 [Bug 33998] Installer and onboarding have incorrect Font Awesome asset links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_11_candidate | --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I pushed a follow-up to fix Asset.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152412&action=edit Bug 32910: Fix 'Agreements' icon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34042 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 [Bug 34042] Item search broken by FontAwesome upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112 [Bug 34112] Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 32018 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34129 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34129 [Bug 34129] Responsive table button icon broken after FontAwesome upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I would have loved to have seen this in 23.05.x, but for now, I can't justify this enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34320 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 [Bug 34320] Hold reordering arrows look broken after Font Awesome upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34322 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 [Bug 34322] Correct icon triggering more fund search options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34905 [Bug 34905] ILL - "Place request with partners" icon is gone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35013 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 [Bug 35013] Font Awesome icons broken in self checkout and self checkin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #29 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I think the screenshots will be updated as we document other things. Unless this changes something specific, I will make it resolved. Feel free to reopen with more details if I'm wrong... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org