https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73287&action=edit Bug 20455: Fix sort patrons by date expired We may need to apply this change for all other occurrences in our codebase. Test plan: - Make sure sample patron data is loaded and you have a patron without a date expired defined - Make an empty search for all patrons or another search that gives you a good amount of results - Try to sort on the date expired column => Without this patch you get Odd number of elements in anonymous hash at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189. output_pref is called with 'dateonly' (ref SCALAR), not a DateTime object -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- kohadevbox reset_all in mysql client update borrowers set dateexpiry=null where borrowernumber=1 in staff client click patrons in top menu bar in left pane, search for 'a' as 'Surname'. list comes up. sort on 'Expires on', results in processing hang and errors as described in comment #0. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73287|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73296&action=edit Bug 20455: Fix sort patrons by date expired We may need to apply this change for all other occurrences in our codebase. Test plan: - Make sure sample patron data is loaded and you have a patron without a date expired defined - Make an empty search for all patrons or another search that gives you a good amount of results - Try to sort on the date expired column => Without this patch you get Odd number of elements in anonymous hash at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189. output_pref is called with 'dateonly' (ref SCALAR), not a DateTime object Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73296|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73358&action=edit Bug 20455: Fix sort patrons by date expired We may need to apply this change for all other occurrences in our codebase. Test plan: - Make sure sample patron data is loaded and you have a patron without a date expired defined - Make an empty search for all patrons or another search that gives you a good amount of results - Try to sort on the date expired column => Without this patch you get Odd number of elements in anonymous hash at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189. output_pref is called with 'dateonly' (ref SCALAR), not a DateTime object Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145 [Bug 20145] borrowers.datexpiry eq '0000-00-00' means expired? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455 Niamh <niamh.walker-headon@it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.