[Bug 43220] New: Patron name and card number should not be clickable in headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 Bug ID: 43220 Summary: Patron name and card number should not be clickable in headings Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 29768 Target Milestone: --- Since Bug 29768 the patron name and card number in the sidebar of patron pages is linked to the patron detail page. On the checkout page the patron name in the main heading is also clickable. This change happened in Bug 29768, "hidepatronname hides guarantor name on borrower edit screen." I think this was unintended and should be considered a bug. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 [Bug 29768] hidepatronname hides guarantor name on borrower edit screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Bug 41343 seems to have corrected the problem in the sidebar. The circulation page still needs a fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 207420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207420&action=edit Bug 43220: Patron name and card number should not be clickable in headings This patch updates the circulation template so that the 'no_html' flag is passed to patron-title.inc so that the patron name in the page heading is not a clickable link. To test, apply the patch and check out to a patron. The "Checking out to [name]" heading above the barcode input field should be plain text. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41343 [Bug 41343] Overdue report is too intensive on systems with many overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207420|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 207423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207423&action=edit Bug 43220: Patron name and card number should not be clickable in headings This patch updates the circulation template so that the 'no_html' flag is passed to patron-title.inc so that the patron name in the page heading is not a clickable link. To test, apply the patch and check out to a patron. The "Checking out to [name]" heading above the barcode input field should be plain text. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207423|0 |1 is obsolete| | --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 207569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207569&action=edit Bug 43220: Patron name and card number should not be clickable in headings This patch updates the circulation template so that the 'no_html' flag is passed to patron-title.inc so that the patron name in the page heading is not a clickable link. To test, apply the patch and check out to a patron. The "Checking out to [name]" heading above the barcode input field should be plain text. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207569|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207985&action=edit Bug 43220: Patron name and card number should not be clickable in headings This patch updates the circulation template so that the 'no_html' flag is passed to patron-title.inc so that the patron name in the page heading is not a clickable link. To test, apply the patch and check out to a patron. The "Checking out to [name]" heading above the barcode input field should be plain text. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43866 Version(s)| |26.11.00 released in| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to main for 26.11 with consent from Pedro whilst he's on annual leave Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 [Bug 43866] Patron name and card number should not be clickable in remaining 'Checking out to' headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the "Checking release notes| |out to [patron name (patron | |number)]" message on the | |patron check out page to | |remove the link for the | |patron name and card | |number. | | | |(A follow-up bug, Bug 43866 | |- Patron name and card | |number should not be | |clickable in remaining | |'Checking out to' headings, | |removes the link from the | |check out page when a | |patron can't check out (for | |example, when they have | |restrictions) and the batch | |check out page.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.06 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.06 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org