[Bug 42810] New: New patron category form does not show self-renewal information message field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Bug ID: 42810 Summary: New patron category form does not show self-renewal information message field Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 26355 Target Milestone: --- The patron category template logic works in such a way that if you're creating a new patron category the "Self-renewal information message" field is not shown, but the hint for the field is shown. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 [Bug 26355] Allow patron account renewals through the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries Patch complexity|--- |Small patch Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 200184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200184&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. To test, apply the patch and go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. - When editing a category which has multiple self-renewal information messages, confirm that the "Information to be displayed..." hint is only displayed once, after the last instance. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #2 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 200185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200185&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. To test, apply the patch and go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. - When editing a category which has multiple self-renewal information messages, confirm that the "Information to be displayed..." hint is only displayed once, after the last instance. Sponsored-by: Athens County Public Libraries Signed-off-by: Gretchen Maxeiner <maxeinergl@gcc.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 [Bug 41841] Update some patron admin templates to use grid layout for forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxeinergl@gcc.edu Status|Needs Signoff |Signed Off --- Comment #3 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Works as advertised! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- I revisited this patch today while testing on related bug 41841, and I noticed some behavior that I don't think was intended. - In the process of adding self-renewal information messages (clicking the "new" button, both when creating a new category and editing a category) the new boxes appear BELOW the hint. After saving and viewing again via edit all message boxes sit above the hint as intended, but when actually adding new ones they seem to be in the wrong spot. - When you edit a category with multiple self-renewal information message boxes, as mentioned above they display above the hint. If you "clear" the last message box, you lose the hint entirely. Pre-patch the hint remained in this case. I'm going to reset this bug as failed because I think it's a problem to lose that hint while editing a patron category. You may still have active self-renewal information messages and a related self-renewal failure message on screen that the hint can assist on. (Note that it does return after saving and reopening the category via "edit"). Sorry I didn't notice these before! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203183&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. To test, apply the patch and go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the patron release notes| |category form. When | |creating a new patron | |category the "Self-renewal | |information message" field | |was not shown (but the hint | |was). (The field was shown | |when editing an existing | |patron category.) Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Failed QA as the label has a space before the colon: Self-renewal information message : Self-renewal information message 2 : (I couldn't figure out how to remove the extra space, otherwise I would have added a follow-up.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203406&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. To test, apply the patch and go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 203416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203416&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. To test, apply the patch and go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #9 from David Nind <david@davidnind.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- On the final step of the test plan, when I add a new message I gets the following ID: self_renewal_information_message_NaN Everything still works, and when I have a return to the page I it is correctly set as: self_renewal_information_message_2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203416|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203670&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. At the same time this patch updates the form to use CSS grids for layout. The markup change makes the field cloning JS much simpler. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. - At each step confirm that the form layout looks correct. - Check that the "Block expired patron OPAC actions" dropdown looks correct Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- I heavily revised the patch to include CSS grid updates since the self-renewal information message cloning would have to be completely re-written anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #6)
Failed QA as the label has a space before the colon:
Self-renewal information message : Self-renewal information message 2 :
(I couldn't figure out how to remove the extra space, otherwise I would have added a follow-up.)
This is ack with the updated patch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org