[Bug 42810] New: New patron category form does not show self-renewal information message field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Bug ID: 42810 Summary: New patron category form does not show self-renewal information message field Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 26355 Target Milestone: --- The patron category template logic works in such a way that if you're creating a new patron category the "Self-renewal information message" field is not shown, but the hint for the field is shown. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 [Bug 26355] Allow patron account renewals through the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries Patch complexity|--- |Small patch Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 200184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200184&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. To test, apply the patch and go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. - When editing a category which has multiple self-renewal information messages, confirm that the "Information to be displayed..." hint is only displayed once, after the last instance. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #2 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 200185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200185&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. To test, apply the patch and go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. - When editing a category which has multiple self-renewal information messages, confirm that the "Information to be displayed..." hint is only displayed once, after the last instance. Sponsored-by: Athens County Public Libraries Signed-off-by: Gretchen Maxeiner <maxeinergl@gcc.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 [Bug 41841] Update some patron admin templates to use grid layout for forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxeinergl@gcc.edu Status|Needs Signoff |Signed Off --- Comment #3 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Works as advertised! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- I revisited this patch today while testing on related bug 41841, and I noticed some behavior that I don't think was intended. - In the process of adding self-renewal information messages (clicking the "new" button, both when creating a new category and editing a category) the new boxes appear BELOW the hint. After saving and viewing again via edit all message boxes sit above the hint as intended, but when actually adding new ones they seem to be in the wrong spot. - When you edit a category with multiple self-renewal information message boxes, as mentioned above they display above the hint. If you "clear" the last message box, you lose the hint entirely. Pre-patch the hint remained in this case. I'm going to reset this bug as failed because I think it's a problem to lose that hint while editing a patron category. You may still have active self-renewal information messages and a related self-renewal failure message on screen that the hint can assist on. (Note that it does return after saving and reopening the category via "edit"). Sorry I didn't notice these before! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203183&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. To test, apply the patch and go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the patron release notes| |category form. When | |creating a new patron | |category the "Self-renewal | |information message" field | |was not shown (but the hint | |was). (The field was shown | |when editing an existing | |patron category.) Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Failed QA as the label has a space before the colon: Self-renewal information message : Self-renewal information message 2 : (I couldn't figure out how to remove the extra space, otherwise I would have added a follow-up.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203406&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. To test, apply the patch and go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 203416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203416&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. To test, apply the patch and go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #9 from David Nind <david@davidnind.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- On the final step of the test plan, when I add a new message I gets the following ID: self_renewal_information_message_NaN Everything still works, and when I have a return to the page I it is correctly set as: self_renewal_information_message_2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203416|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203670&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. At the same time this patch updates the form to use CSS grids for layout. The markup change makes the field cloning JS much simpler. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. - At each step confirm that the form layout looks correct. - Check that the "Block expired patron OPAC actions" dropdown looks correct Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- I heavily revised the patch to include CSS grid updates since the self-renewal information message cloning would have to be completely re-written anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #6)
Failed QA as the label has a space before the colon:
Self-renewal information message : Self-renewal information message 2 :
(I couldn't figure out how to remove the extra space, otherwise I would have added a follow-up.)
This is ack with the updated patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203670|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 206103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206103&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. At the same time this patch updates the form to use CSS grids for layout. The markup change makes the field cloning JS much simpler. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. - At each step confirm that the form layout looks correct. - Check that the "Block expired patron OPAC actions" dropdown looks correct Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 206189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206189&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. At the same time this patch updates the form to use CSS grids for layout. The markup change makes the field cloning JS much simpler. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. - At each step confirm that the form layout looks correct. - Check that the "Block expired patron OPAC actions" dropdown looks correct Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the patron |This fixes the patron release notes|category form. When |category form - when |creating a new patron |creating a new patron |category the "Self-renewal |category the "Self-renewal |information message" field |information message" field |was not shown (but the hint |is now shown (under the |was). (The field was shown |"Account expiry and |when editing an existing |self-renewal" section). |patron category.) | | |Before this: | |1. Only the field hint text | |was shown when creating a | |new patron category. | |2. The field was only shown | |when editing an existing | |patron category. | | | |It also updates the patron | |category form to use the | |new CSS grid layout | |approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206708&action=edit Bug 42810: New patron category form does not show self-renewal information message field This patch updates the patron category admin template so that the "Self-renewal information message" field is displayed when creating a new category. At the same time this patch updates the form to use CSS grids for layout. The markup change makes the field cloning JS much simpler. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Create a new category. - In the "Account expiry and self-renewal" section, confirm that the "Self-renewal information message" field is diplayed. - Fill out the form and confirm that the new category is saved correctly. - Edit the category and confirm that the form field is displayed correctly. - Click the "+ New" link and test that additional messages are saved and displayed correctly. - At each step confirm that the form layout looks correct. - Check that the "Block expired patron OPAC actions" dropdown looks correct Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #17 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 206804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206804&action=edit Bug 42810: [ALTERNATIVE] Show self-renewal information message field on new categories Pass [""] instead of [] for new categories so one empty field is rendered. Test plan (before applying this patch): 1. Go to Administration > Patron categories > New category: http://localhost:8081/cgi-bin/koha/admin/categories.pl?op=add_form 2. Scroll to 'Account expiry and self-renewal'. Note there is no 'Self-renewal information message' field 3. Apply patch, restart plack 4. Repeat 1 and 2. Confirm the field is now shown 5. Click 'New' once, fill in both messages and the other required fields, save 6. Edit the new category. Confirm both messages are shown Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k --- Comment #18 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- There is a regression here: 1) Before applying the patch, visit: http://localhost:8081/cgi-bin/koha/admin/categories.pl?op=add_form&categorycode=PT 2) Scroll to 'Account expiry and self-renewal' 3) Click 'New' next to 'Self-renewal information message' twice 4) Confirm there are 3 message fields and the hint 'Information to be displayed to the patron at the start of the renewal process...' is shown once 5) Apply Owen's patch, then hard refresh the page (or use a private window) 6) Repeat 2) and 3) 7) Confirm the hint is now repeated under every message field (3 times) It appears the patch is doing more than just fixing the issue, could we split this work? - This bug: just the fix. I've attached an alternative patch that changes the [] to [""] on line 55 of admin/categories.pl (the self_renewal_information_messages fallback for new categories), which should be enough. - A new bug, depending on this one: the grid conversion, the JS rework and the shared .fg CSS changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> ---
There is a regression here: ... 7) Confirm the hint is now repeated under every message field (3 times)
Personally I don't find this to be a problem. It's not doing any harm to repeat the hint, and the updated version ensures that the hint is visible under the first instance of the field which would be first-read if the user is going down through the form fields. I combined the grid work with this fix because the structure change in the grid work would require a complete rewrite of the JS which would need to be rewritten for just the bug fix. I know it's not standard procedure but this approach seemed to be the shortest path to both a fix and an updated form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #20 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- (In reply to Owen Leonard from comment #19)
There is a regression here: ... 7) Confirm the hint is now repeated under every message field (3 times)
Personally I don't find this to be a problem. It's not doing any harm to repeat the hint, and the updated version ensures that the hint is visible under the first instance of the field which would be first-read if the user is going down through the form fields.
I combined the grid work with this fix because the structure change in the grid work would require a complete rewrite of the JS which would need to be rewritten for just the bug fix. I know it's not standard procedure but this approach seemed to be the shortest path to both a fix and an updated form.
Thank you Owen, while I agree that repeating the hint is harmless, it is not clear to me that that behavior is intentional. Would you please give the alternative patch a try? I believe that fixes the issue here without requiring the grid work. Additionally, the grid work can fit nicely on top, and this specific fix remains easily backportable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Pedro Amorim (ammopt) from comment #20)
I believe that fixes the issue here without requiring the grid work. Additionally, the grid work can fit nicely on top, and this specific fix remains easily backportable.
Got it, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Sponsorship status|Sponsored |--- Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 206821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206821&action=edit Bug 42810: [ALTERNATIVE] Show self-renewal information message field on new categories Pass [""] instead of [] for new categories so one empty field is rendered. Test plan (before applying this patch): 1. Go to Administration > Patron categories > New category: http://localhost:8081/cgi-bin/koha/admin/categories.pl?op=add_form 2. Scroll to 'Account expiry and self-renewal'. Note there is no 'Self-renewal information message' field 3. Apply patch, restart plack 4. Repeat 1 and 2. Confirm the field is now shown 5. Click 'New' once, fill in both messages and the other required fields, save 6. Edit the new category. Confirm both messages are shown Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |This fixes the patron released in| |category form - when | |creating a new patron | |category the "Self-renewal | |information message" field | |is now shown (under the | |"Account expiry and | |self-renewal" section). | | | |Before this: | |1. Only the field hint text | |was shown when creating a | |new patron category. | |2. The field was only shown | |when editing an existing | |patron category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|This fixes the patron | released in|category form - when | |creating a new patron | |category the "Self-renewal | |information message" field | |is now shown (under the | |"Account expiry and | |self-renewal" section). | | | |Before this: | |1. Only the field hint text | |was shown when creating a | |new patron category. | |2. The field was only shown | |when editing an existing | |patron category. | Text to go in the|This fixes the patron |This fixes the patron release notes|category form - when |category form - when |creating a new patron |creating a new patron |category the "Self-renewal |category the "Self-renewal |information message" field |information message" field |is now shown (under the |is now shown (under the |"Account expiry and |"Account expiry and |self-renewal" section). |self-renewal" section). | | |Before this: |Before this: |1. Only the field hint text |1. Only the field hint text |was shown when creating a |was shown when creating a |new patron category. |new patron category. |2. The field was only shown |2. The field was only shown |when editing an existing |when editing an existing |patron category. |patron category. | | |It also updates the patron | |category form to use the | |new CSS grid layout | |approach. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206821|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207156&action=edit Bug 42810: [ALTERNATIVE] Show self-renewal information message field on new categories Pass [""] instead of [] for new categories so one empty field is rendered. Test plan (before applying this patch): 1. Go to Administration > Patron categories > New category: http://localhost:8081/cgi-bin/koha/admin/categories.pl?op=add_form 2. Scroll to 'Account expiry and self-renewal'. Note there is no 'Self-renewal information message' field 3. Apply patch, restart plack 4. Repeat 1 and 2. Confirm the field is now shown 5. Click 'New' once, fill in both messages and the other required fields, save 6. Edit the new category. Confirm both messages are shown Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207156|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207157&action=edit Bug 42810: [ALTERNATIVE] Show self-renewal information message field on new categories Pass [""] instead of [] for new categories so one empty field is rendered. Test plan (before applying this patch): 1. Go to Administration > Patron categories > New category: http://localhost:8081/cgi-bin/koha/admin/categories.pl?op=add_form 2. Scroll to 'Account expiry and self-renewal'. Note there is no 'Self-renewal information message' field 3. Apply patch, restart plack 4. Repeat 1 and 2. Confirm the field is now shown 5. Click 'New' once, fill in both messages and the other required fields, save 6. Edit the new category. Confirm both messages are shown Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810 --- Comment #25 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org