https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AUTO_RENEWALS should be a |AUTO_RENEWALS should be a |patron messaging |patron messaging preference |preferences | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karen@bywatersolutions.com --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 19736 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Catherine E. Ingram <catherine.ingram@cedarparktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catherine.ingram@cedarparkt | |exas.gov --- Comment #2 from Catherine E. Ingram <catherine.ingram@cedarparktexas.gov> --- Please please please make it so patrons can Digest the auto renew emails. When you get 30 or more emails in one day it is obnoxious. I get MANY patron complaints about this. Is there any development on this? We could maybe help out with that financially. Catherine Ingram Cedar Park Public Library, TX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Niamh <niamh.walker-headon@it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #6 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 95030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95030&action=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95030|0 |1 is obsolete| | Attachment #95031|0 |1 is obsolete| | --- Comment #10 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 95337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95337&action=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96049|0 |1 is obsolete| | --- Comment #15 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96050&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure renewals are allowed in circ rules 4. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row Signed-off-by: tgoat <tgoatley@gmail.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 davidm@ranchomiragelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |davidm@ranchomiragelibrary. | |org --- Comment #16 from davidm@ranchomiragelibrary.org --- We have recently started receiving complaints about the individual emails for auto-renewals. It would be great to see this development happen. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96050|0 |1 is obsolete| | --- Comment #18 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96487&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure renewals are allowed in circ rules 4. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row Signed-off-by: tgoat <tgoatley@gmail.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Marti Fuerst <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95337|0 |1 is obsolete| | --- Comment #19 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 96494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96494&action=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports Signed-off-by: tgoat <tgoatley@gmail.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Marti Fuerst <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #21 from Catherine E. Ingram <catherine.ingram@cedarparktexas.gov> --- We were playing around with it this morning and wondered about roll out. The way it looked in the sandbox was that it would default to all existing patrons getting NO notices (with both email and digest un-checked). Did anyone else encounter this? ~Catherine -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #23 from Catherine E. Ingram <catherine.ingram@cedarparktexas.gov> --- Did anyone have a chance to look at this? Did you have questions for me? --------------------------------- Catherine E. Ingram, MLS Assistant Library Director Cedar Park Public Library Office: 512-401-5640 Catherine.Ingram@cedarparktexas.gov 550 Discovery Boulevard Cedar Park, TX 78613 www.cedarparktexas.gov/library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #24 from Agustín Moyano <agustinmoyano@theke.io> --- Sorry, I was almost abducted by another (evil) bug. I'll remove those lines from atomicupdate ASAP, so this can move forward. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96494|0 |1 is obsolete| | Attachment #96495|0 |1 is obsolete| | --- Comment #25 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 98078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98078&action=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports Signed-off-by: tgoat <tgoatley@gmail.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Marti Fuerst <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Catherine E. Ingram <catherine.ingram@cedarparktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Catherine E. Ingram <catherine.ingram@cedarparktexas.gov> --- (In reply to Agustín Moyano from comment #27)

(In reply to Catherine E. Ingram from comment #21)

...

We were playing around with it this morning and wondered about roll out. The way it looked in the sandbox was that it would default to all existing patrons getting NO notices (with both email and digest un-checked). Did anyone else encounter this? ~Catherine

Hi Catherine, you were right.. I believed that if I didn't add that preference on patrons that already had preferences setted, Koha would break, but it didn't happen at the end.

Thanks for spotting that out.

Can you please try it out again?

Thanks.

Hi Agustín, We have tested the latest patch you have submitted. After applying the patch, we notice that all patrons will have Auto Renewals UNCHECKED for both Email and Digest. This means NO Auto Renewal communication after we apply the patch. This is a problem, because patrons will suddenly stop receiving all Auto Renewal communication unless they re-configure their preferences individually. Can we request that the patch updates ALL patrons to have both Email and Digest CHECKED for the Auto Renewal function? Thank you! Catherine -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #31 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I agree with Catherine that it would be preferable to have the patch update ALL patrons to have both Email and Digest CHECKED for the Auto Renewal function. If our patrons stop receiving any renewal notices it will cause a big customer service issue for us. During our preparation for Go Live, we had some default messaging preferences put in place. New patrons, whether created via self-registration or by staff, all get specific messaging options checked which they can later change if they want. Perhaps adding Email and Digest Auto Renewal default messaging preferences would make sure that existing patrons don't lose anything. Does this sound like it would work? Barbara -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98078|0 |1 is obsolete| | Attachment #98079|0 |1 is obsolete| | --- Comment #32 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 99193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99193&action=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports Signed-off-by: tgoat <tgoatley@gmail.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Marti Fuerst <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #34 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Barbara Johnson from comment #31)

I agree with Catherine that it would be preferable to have the patch update ALL patrons to have both Email and Digest CHECKED for the Auto Renewal function. If our patrons stop receiving any renewal notices it will cause a big customer service issue for us.

During our preparation for Go Live, we had some default messaging preferences put in place. New patrons, whether created via self-registration or by staff, all get specific messaging options checked which they can later change if they want. Perhaps adding Email and Digest Auto Renewal default messaging preferences would make sure that existing patrons don't lose anything.

Does this sound like it would work? Barbara

Hi Barbara and Catherine, Both of you were right.. Category messaging preferences didn't work as I expected.. I thought that it would be a default value when a patron didn't set his/hers own preference, but it was more like a template when you create a new patron. So, in the update script I set email and digest options to checked. Could you please test this again? Thanks. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #36 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Barbara Johnson from comment #35)

Hi Agustín,

Thanks for the new test plan. I'm new at testing bugs. I'm not sure what I'm supposed to do for step 10 (perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v) or 15 (add -d flag)

Thanks.

Hi Barbara, that step executes what a cronjob would do. You should copy that line and paste it in a console, un the root of Koha project. To get a console: * if you are using koha-testing-docker in your linux console you should: 1. docker exec -ti koha_koha_1 bash 2. cd koha 3. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v * If you use vagrant, in your linux console, in the root of your vagrant project execute: 1. vagrant ssh 2. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v * If you've got a testing server you should: 1. ssh youruser@kohatestingserver 2. cd /koha/project/path 3. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v I'm assuming in all cases that you are using any distribution of Linux to develop. If you're using windows I don't know. Hope it helps! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- We talked this one over this morning, we think the idea of setting preferences by default is problematic, we would propose a workaround: 1 - Add a new system preference "SendAutoRenewalNotices" 2 - This syspref would replace the 'send-notices' switch on the cron, and would be marked with deprecation 3 - It would allow libraries to review their messaging settings for auto-renewal 4 - It should default to 'off' with a warning in the DB upgrade and release notes and in the cron if set but the cron could enable the syspref if the option is passed - to highlight the chnage 5 - the --digest option in the cron should be removed as the control should rely on patron settings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 104881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104881&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure automatic renewals are allowed in circ rules, have a positive number of allowed renewals and a positive number for renewal period 4. go to patron categories in administration of staff interface and choose a category. CHECK => in "Default messaging preferences for this patron category" has a "Auto renewals" row and has email and digest options checked 5. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row with email and digest options checked 6. some settings and save 7. go to opac with that same patron to "your messaging" option CHECK => patron's messaging preferences has a "Auto renewals" row, and displays changes made in staff interface. 8. uncheck email and digest from "Auto renewals" row and save 9. check out an item for that patron, and set it as automatic renewal and set due date as your current yesterday 10. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v SUCCESS => item was renewed, and in message_queue table there is no new message for the patron 11. update patrons messaging preferences and set email option of "Auto renewals" row as checked 12. repeat steps 9 and 10 SUCCESS => item was renewed, but in message_queue table there is a new message of type AUTO_RENEWALS 13. update patrons messaging preferences and set email and digest options of "Auto renewals" row as checked 14. repeat steps 9 and 10 CHECK => item was not renewed 15. run step 10 again, but add -d flag, like this: perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v -d SUCCESS => item was renewed, and in message_queue table there is a new message of type AUTO_RENEWALS_DGST 16. Sign off Signed-off-by: tgoat <tgoatley@gmail.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Marti Fuerst <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 104883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104883&action=edit Bug 18532: (follow-up) UNTESTED add individual issues to digest notice This is how I think this works, I did not test this code -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104880|0 |1 is obsolete| | Attachment #104881|0 |1 is obsolete| | Attachment #104882|0 |1 is obsolete| | Attachment #104883|0 |1 is obsolete| | --- Comment #44 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 105500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105500&action=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports Signed-off-by: tgoat <tgoatley@gmail.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Marti Fuerst <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #46 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 105502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105502&action=edit Bug 18532: (follow-up) Remove digest switch and add preference -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #48 from Agustín Moyano <agustinmoyano@theke.io> --- Thak you Nick so much for your code, it was illuminating! :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #49)

2) System preference: The sentence doesn't quite work for the first and last choices, maybe one of the native speakers could help? Can you explain about the deprecation? It might appear as if the cronjob was deprecated, but I think what is meant is a specific option. I think being more clear here would be helpful. + - "Send automatic renewal notices " + - pref: AutoRenewalNotices + choices: + never: never + preferences: according to patron messaging preferences + cron: (Deprecated) according to cron switch

We would like to deprecate using the cron switch in favor of the preference. Unfortunately, we don't have a code path forward to set the patron preferences to a default that won't cause changes. The idea would be that libraries using the cron switch should set the patron messaging preferences to match their case, and then update the preference. The 'never' option should do what it says and disable auto-renewal notices. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #52 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Katrin Fischer from comment #51)

Nick, can you please help with a rephrase of the pref too? I think it needs some more information, like which of the cron options we refer to.

Hi Katrin, would it be clear if we set the values like this? - "Send automatic renewal notices " - pref: AutoRenewalNotices choices: never: never send notices preferences: according to patron messaging preferences cron: (Deprecated) according to --send-notices cron switch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, the first option doesn't work as a sentence: "Send automatic renewal notices " never send notices. Maybe: Send automatic renewal notices: never ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #55 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 114316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114316&action=edit Bug 18532: (follow-up) Fix notice message, add notice to all installer languages and fix preference message -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #57 from Martha Fuerst <mfuerst@hmcpl.org> --- (In reply to Sarah Cornell from comment #56)

My library may not adopt auto-renewals until there is a digest notice available, so I'm crossing my fingers that this makes it into 21.05. Does it just need of testing after the last follow-up? (I haven't tested a lot, please forgive me for not being able to tell from here.)

It's been signed off. If I recall correctly, it needs to go through Quality Assurance before it can be finalized. But I'm here to make noise on this too - we have implemented Auto-renewals, but in a weird way so that we can get around this bug. We would still very much like to see this make it's way into Koha. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #59 from David Cook <dcook@prosentient.com.au> --- (In reply to Barbara Johnson from comment #58)

We sponsored this bug, along with three other libraries, and are eagerly awaiting this functionality. What can we do to get this moving in the QA process?

I think making noise is a good way. I'm swamped at the moment, but I've been keen to see this functionality in Koha for a while, so I'll add it to my list. Hopefully someone else gets to it before me though. (Keep making noise :D.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #62 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Martin, what does it mean that the notice templates no longer apply? Is that an easy fix or are we back to square one? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105501|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #64 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 115799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115799&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. (Deprecated test plan. Please check the last patch) To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure automatic renewals are allowed in circ rules, have a positive number of allowed renewals and a positive number for renewal period 4. go to patron categories in administration of staff interface and choose a category. CHECK => in "Default messaging preferences for this patron category" has a "Auto renewals" row and has email and digest options checked 5. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row with email and digest options checked 6. some settings and save 7. go to opac with that same patron to "your messaging" option CHECK => patron's messaging preferences has a "Auto renewals" row, and displays changes made in staff interface. 8. uncheck email and digest from "Auto renewals" row and save 9. check out an item for that patron, and set it as automatic renewal and set due date as your current yesterday 10. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v SUCCESS => item was renewed, and in message_queue table there is no new message for the patron 11. update patrons messaging preferences and set email option of "Auto renewals" row as checked 12. repeat steps 9 and 10 SUCCESS => item was renewed, but in message_queue table there is a new message of type AUTO_RENEWALS 13. update patrons messaging preferences and set email and digest options of "Auto renewals" row as checked 14. repeat steps 9 and 10 CHECK => item was not renewed 15. run step 10 again, but add -d flag, like this: perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v -d SUCCESS => item was renewed, and in message_queue table there is a new message of type AUTO_RENEWALS_DGST 16. Sign off Signed-off-by: tgoat <tgoatley@gmail.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Marti Fuerst <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #66 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 115801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115801&action=edit Bug 18532: add individual issues to digest notice and hide auto_renewals messaging preference when not needed This patch enhances auto_renewals message, removes auto_renewals messaging preference when AutoRenewalNotices is not set to ‘preferences’ and uses that preference to send notices in automatic_renewals.pl script. To test: 1. Apply patches 2. updatedatabase 3. make sure automatic renewals are allowed in circ rules, have a positive number of allowed renewals and a positive number for renewal period 4. Check AutoRenewalNotices preference SUCCESS => AutoRenewalNotices has the value ‘cron’ (means that It keeps the usual behaviour) 5. Checkout two items for a patron, and set them as automatic renewal and set due date as your current yesterday 6. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql 7. Repeat step 5 8. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, and there is one message per item in message_queue table in mysql 9. Change AutoRenewalNotices to ‘never’ 10. Repeat step 5 11. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql, even with the -s switch 12. Check any patron’s category, and any detail page in staff or OPAC interface, and in any of them you should find Auto Renewals messaging preference 13. Change AutoRenewalNotices to ‘preferences’ 14. Repeat step 12, but this time all of them shows the Auto Renewals messaging preference. 15. Repeat step 5 with a patron that has no messaging preference setted 16. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql, because patron didn’t choose to receive messages 17. Grab a category and modify auto renewals messaging preferences, and save 18. Create a new patron from that category. SUCCESS => created patron has the same messaging preference for auto renewals 19. Grab that patron and change auto renewals messaging preference to email but not digest 20. Repeat step 5 for that last patron. 21. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => Items were renewed, and there is a message for each item in message_queue table in mysql. 22. Change auto renewals messaging preference from the same patron and set to email and digest. 23. Repeat step 5. 24. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => items where renewed, and now there is only one message in message_queue table with the details of both renewed items. 25. Check that any changes to a patron’s auto renewals messaging preference in staff is reflected in OPAC, and the other way arround too. 26. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115799|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115830&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. (Deprecated test plan. Please check the last patch) To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure automatic renewals are allowed in circ rules, have a positive number of allowed renewals and a positive number for renewal period 4. go to patron categories in administration of staff interface and choose a category. CHECK => in "Default messaging preferences for this patron category" has a "Auto renewals" row and has email and digest options checked 5. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row with email and digest options checked 6. some settings and save 7. go to opac with that same patron to "your messaging" option CHECK => patron's messaging preferences has a "Auto renewals" row, and displays changes made in staff interface. 8. uncheck email and digest from "Auto renewals" row and save 9. check out an item for that patron, and set it as automatic renewal and set due date as your current yesterday 10. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v SUCCESS => item was renewed, and in message_queue table there is no new message for the patron 11. update patrons messaging preferences and set email option of "Auto renewals" row as checked 12. repeat steps 9 and 10 SUCCESS => item was renewed, but in message_queue table there is a new message of type AUTO_RENEWALS 13. update patrons messaging preferences and set email and digest options of "Auto renewals" row as checked 14. repeat steps 9 and 10 CHECK => item was not renewed 15. run step 10 again, but add -d flag, like this: perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v -d SUCCESS => item was renewed, and in message_queue table there is a new message of type AUTO_RENEWALS_DGST 16. Sign off Signed-off-by: tgoat <tgoatley@gmail.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Marti Fuerst <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115832&action=edit Bug 18532: Add individual issues to digest notice and hide auto_renewals messaging preference when not needed This patch enhances auto_renewals message, removes auto_renewals messaging preference when AutoRenewalNotices is not set to ‘preferences’ and uses that preference to send notices in automatic_renewals.pl script. To test: 1. Apply patches 2. updatedatabase 3. make sure automatic renewals are allowed in circ rules, have a positive number of allowed renewals and a positive number for renewal period 4. Check AutoRenewalNotices preference SUCCESS => AutoRenewalNotices has the value ‘cron’ (means that It keeps the usual behaviour) 5. Checkout two items for a patron, and set them as automatic renewal and set due date as your current yesterday 6. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql 7. Repeat step 5 8. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, and there is one message per item in message_queue table in mysql 9. Change AutoRenewalNotices to ‘never’ 10. Repeat step 5 11. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql, even with the -s switch 12. Check any patron’s category, and any detail page in staff or OPAC interface, and in any of them you should find Auto Renewals messaging preference 13. Change AutoRenewalNotices to ‘preferences’ 14. Repeat step 12, but this time all of them shows the Auto Renewals messaging preference. 15. Repeat step 5 with a patron that has no messaging preference setted 16. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql, because patron didn’t choose to receive messages 17. Grab a category and modify auto renewals messaging preferences, and save 18. Create a new patron from that category. SUCCESS => created patron has the same messaging preference for auto renewals 19. Grab that patron and change auto renewals messaging preference to email but not digest 20. Repeat step 5 for that last patron. 21. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => Items were renewed, and there is a message for each item in message_queue table in mysql. 22. Change auto renewals messaging preference from the same patron and set to email and digest. 23. Repeat step 5. 24. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => items where renewed, and now there is only one message in message_queue table with the details of both renewed items. 25. Check that any changes to a patron’s auto renewals messaging preference in staff is reflected in OPAC, and the other way arround too. 26. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115801|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #75 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Yay! Thanks so much to Tomas and Martin for the final push. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #78 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Barbara Johnson from comment #77)

Just wanted to check on this bug. It passed QA on 1/26/21 but it’s now been set back to Failed QA. Can someone provide an update on the problem?

It is just missing a good description on the 'Text to go in the release notes' field here in Bugzilla! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Status|Failed QA |Passed QA Text to go in the| |This patchset adds release notes| |messaging preferences for | |controlling auto renewal | |notifications. This allows | |more fine-grained control | |on auto renewal | |notifications. | | | |A new | |letter is added to the | |existing AUTO_RENEWALS one, | |for digest notifications | |(AUTO_RENEWALS_DIGEST). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #80 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Barbara Johnson from comment #79)

Thanks for that info Tomas.

As a non-native speaker I welcome any idiomatic fixes. Feel free to jump in! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115833|0 |1 is obsolete| | --- Comment #82 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 118198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118198&action=edit Bug 18532: (follow-up) Fix notice message, add notice to all installer languages and fix preference message Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #84 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 118199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118199&action=edit Bug 18532: (QA follow-up) Atomicupdate syntax Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #86 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 118205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118205&action=edit Bug 18532: (follow-up) Fix rebasing issue When the ILL notices were added, a bad rebase got rid of the notice description in both messaging-preference-form.inc and opac-messaging.tt This patch restores that line: 1. Set AutoRenewalNotices to 'according to patron...' 2. Edit a patron category => FAIL: There's an 'Unknown' label for 'Auto renewal' 3. Look at a patron's messaging preferences => FAIL: There's an 'Unknown' label for 'Auto renewal' 4. Look at a patron's messaging preferences in OPAC => FAIL: There's an 'Unknown' label for 'Auto renewal' 5. Apply this patch 6. Repeat 2, 3, 4 => SUCCESS: 'Auto renewal' is displayed as expected Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #88 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 118318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118318&action=edit Bug 18532: (follow-up) Fix atomic update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #90 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- "was not renewed with error: [% checkout.auto_renew_error %]" This is not good, we are going to display the raw error code in the template :-/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #92 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- "There were 1 items that where renewed." where => were -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118318|0 |1 is obsolete| | --- Comment #94 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 118329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118329&action=edit Bug 18532: (follow-up) Fix atomic update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118330|0 |1 is obsolete| | --- Comment #96 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 118331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118331&action=edit Bug 18532: (follow-up) fix messages and bug in automatic_renewals script -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #98 from Cheryl <clackman@fargolibrary.org> --- You could say "N item(s) successfully renewed" so it works for one or more and doesn't have to deal with verb tenses. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #99 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #100 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118356&action=edit Bug 18532: Add missing notice template for it-IT Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #102 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29381 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 [Bug 29381] Auto-renewal digest messages are sent on every cron run -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 [Bug 29456] Notice overview on Patron Category -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30222 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 [Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them -- You are receiving this mail because: You are watching all bug changes.