[Bug 20656] New: Print summary for patron shows paid fines and formats payments badly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Bug ID: 20656 Summary: Print summary for patron shows paid fines and formats payments badly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1 - Add some fines to a patron 2 - pay them all 3 - print summary - nothing shows - good 4 - Add a new fine 5 - print summary 6 - All fines show 7 - Inspect the payment line - note lots of newlines and ugly characters -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74829&action=edit Bug 20656: Don't print lines that have no balance on print summary To test: 1 - Add at least two fines to a patron 2 - Pay off one of them 3 - Print summary - all 3 lines show 4 - Apply patch 5 - Print summary - only line with balance shows -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74830&action=edit Bug 20656: Better formatting for print summary This patch is a slightly edited c&p from boraccount.tt 1 - Manually add a credit with no notes to patron 2 - Print summary 3 - Inspect the line 4 - Note that td has extra newlines and no words 5 - Apply patch 6 - Print summary again 7 - Note better formatting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Depends on| |17100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100 [Bug 17100] On summary print, "Account fines and payments" is displayed even if there is nothing to pay -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- I'm not sure it won't be considered as a regression by some libraries. Before your patch, Print summary shows the fine and its payment. After your patch, the fine and payment info doesn't appear anymore. On Summary page, the table showing information is labelled Account fines and payments. So 'payments' seems to be expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I like the new display better. As it's supposed to be a summary displaying only open credits and fines makes sense to me, but the heading should then be changed to match the new display. Signing, but waiting for follow-up and maybe another opinion here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74829|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76775&action=edit Bug 20656: Don't print lines that have no balance on print summary To test: 1 - Add at least two fines to a patron 2 - Pay off one of them 3 - Print summary - all 3 lines show 4 - Apply patch 5 - Print summary - only line with balance shows Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74830|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76776&action=edit Bug 20656: Better formatting for print summary This patch is a slightly edited c&p from boraccount.tt 1 - Manually add a credit with no notes to patron 2 - Print summary 3 - Inspect the line 4 - Note that td has extra newlines and no words 5 - Apply patch 6 - Print summary again 7 - Note better formatting Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |black23@gmail.com --- Comment #7 from Michal Denar <black23@gmail.com> --- Please rebase on actual master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76775|0 |1 is obsolete| | Attachment #76776|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79002&action=edit Bug 20656: Don't print lines that have no balance on print summary To test: 1 - Add at least two fines to a patron 2 - Pay off one of them 3 - Print summary - all 3 lines show 4 - Apply patch 5 - Print summary - only line with balance shows Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79003&action=edit Bug 20656: Better formatting for print summary This patch is a slightly edited c&p from boraccount.tt 1 - Manually add a credit with no notes to patron 2 - Print summary 3 - Inspect the line 4 - Note that td has extra newlines and no words 5 - Apply patch 6 - Print summary again 7 - Note better formatting Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Condition is missing to display the biblio's title: account.accounttype != 'F' AND account.accounttype != 'FU' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79024&action=edit Bug 20656: (follow-up) Don't display title for F or FU fines (it is in description) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 79003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79003 Bug 20656: Better formatting for print summary Review of attachment 79003: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20656&attachment=79003) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt @@ +97,4 @@
<caption>Account fines and payments</caption> + <thead> + <tr> + <th class="title-string">Date</th>
Why are you adding the class here? It is usually used for sorting in datatables, which is not this case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79002|0 |1 is obsolete| | Attachment #79003|0 |1 is obsolete| | Attachment #79024|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79095&action=edit Bug 20656: Don't print lines that have no balance on print summary To test: 1 - Add at least two fines to a patron 2 - Pay off one of them 3 - Print summary - all 3 lines show 4 - Apply patch 5 - Print summary - only line with balance shows Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79096&action=edit Bug 20656: Better formatting for print summary This patch is a slightly edited c&p from boraccount.tt 1 - Manually add a credit with no notes to patron 2 - Print summary 3 - Inspect the line 4 - Note that td has extra newlines and no words 5 - Apply patch 6 - Print summary again 7 - Note better formatting Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79097&action=edit Bug 20656: (follow-up) Don't display title for F or FU fines (it is in description) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Josef Moravec from comment #12)
+ <tr> + <th class="title-string">Date</th>
Why are you adding the class here? It is usually used for sorting in datatables, which is not this case.
Bad copy/paste during rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79095|0 |1 is obsolete| | Attachment #79096|0 |1 is obsolete| | Attachment #79097|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79138&action=edit Bug 20656: Don't print lines that have no balance on print summary To test: 1 - Add at least two fines to a patron 2 - Pay off one of them 3 - Print summary - all 3 lines show 4 - Apply patch 5 - Print summary - only line with balance shows Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79139&action=edit Bug 20656: Better formatting for print summary This patch is a slightly edited c&p from boraccount.tt 1 - Manually add a credit with no notes to patron 2 - Print summary 3 - Inspect the line 4 - Note that td has extra newlines and no words 5 - Apply patch 6 - Print summary again 7 - Note better formatting Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79140&action=edit Bug 20656: (follow-up) Don't display title for F or FU fines (it is in description) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Nick Clemens from comment #16)
(In reply to Josef Moravec from comment #12)
+ <tr> + <th class="title-string">Date</th>
Why are you adding the class here? It is usually used for sorting in datatables, which is not this case.
Bad copy/paste during rebase
Thanks fir quick fix, passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79176&action=edit Bug 20656: (RM follow-up) Add missing filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4)
I think I like the new display better. As it's supposed to be a summary displaying only open credits and fines makes sense to me, but the heading should then be changed to match the new display.
Signing, but waiting for follow-up and maybe another opinion here.
I am happy to fix this on a follow-up bug, can you suggest a new title? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Print summary for patron release notes| |will now show only | |outstanding fines/payments. | |To print all fines/payments | |you can use the 'print' | |option for the table in the | |accounts page for the | |patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #25 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- 17.11.x is still using GetMemberAccountRecords instead of Koha::Account::Lines so patch does not applies. Is is relevant for 17.11.x ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org