[Bug 42722] New: Improve invalidPickupBranch error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Bug ID: 42722 Summary: Improve invalidPickupBranch error message Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com See Bug 41879 which fixes an issue where a hold can be moved to a bib owned by a branch that doesn't allow pickup at the original hold pickup location. The current error message reads: "Target item/record is an invalid pickup location". This is a bit awkward as it says the item/record _is_ a location. I'll brainstorm some other possibilities below. "Target item/record would have an invalid pickup location" "Hold is unable to be fulfilled using its original pickup location" Or something that tells you how to address the underlying issue? "Target item/record would have an invalid pickup location. Please move the hold to a different item/bib or change the pickup location of the hold to a valid one." I realize the last is the most verbose, but I do like the idea of providing solutions with the error message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41879 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41879 [Bug 41879] Holds that move to a new bib can be unfillable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31698 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ephetteplace@cca.edu |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 --- Comment #1 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 200904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200904&action=edit Bug 42722: improve invalidPickupBranch error message Ensure you have the patch from Bug 41879 and follow its test plan. You should see the message 'Target item or record has an invalid pickup location. Either move the hold onto a valid item type or select a valid pickup location.' when attempting an invalid hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 200932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200932&action=edit Bug 42722: Improve invalidPickupBranch error message Ensure you have the patch from Bug 41879 and follow its test plan. You should see the message 'Target item or record has an invalid pickup location. Either move the hold onto a valid item type or select a valid pickup location.' when attempting an invalid hold. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #200904|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Comment on attachment 200904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200904 Bug 42722: improve invalidPickupBranch error message Fixed bug title - start with capital letter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200932|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201549&action=edit Bug 42722: Improve invalidPickupBranch error message Ensure you have the patch from Bug 41879 and follow its test plan. You should see the message 'Target item or record has an invalid pickup location. Either move the hold onto a valid item type or select a valid pickup location.' when attempting an invalid hold. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 202131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202131&action=edit Add noItemsOnBib error message Patch from commit 8476ce8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201549|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 205106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205106&action=edit Bug 42722: Improve invalidPickupBranch error message Ensure you have the patch from Bug 41879 and follow its test plan. You should see the message 'Target item or record has an invalid pickup location. Either move the hold onto a valid item type or select a valid pickup location.' when attempting an invalid hold. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 205107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205107&action=edit Bug 42722: Add noItemsOnBib error message Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202131|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 --- Comment #8 from David Nind <david@davidnind.com> --- Fixed subject line for second patch (added bug number). Added sign-off after reviewing updated and messages in the patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205106|0 |1 is obsolete| | Attachment #205107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205111&action=edit Bug 42722: Improve invalidPickupBranch error message Ensure you have the patch from Bug 41879 and follow its test plan. You should see the message 'Target item or record has an invalid pickup location. Either move the hold onto a valid item type or select a valid pickup location.' when attempting an invalid hold. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205112&action=edit Bug 42722: Add noItemsOnBib error message Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 --- Comment #11 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 43286 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42722 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.06 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org