https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16301 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50456&action=edit Bug 16301 - Remove the use of "onclick" from SMS cellular providers template This patch refactors some of the JavaScript in the SMS cellular providers template so that event attributes are removed from the markup. This patch also updates the markup for the "Edit" and "Delete" buttons to make them consistent with similar buttons in Koha. To test you must have the SMSSendDriver system preference set to "Email." - Go to Administration -> SMS cellular providers. - If necessary, create a new SMS cellular provider. - Edit at least one patron to use an SMS cellular provider under "Patron messaging preferences." - In the table of SMS cellular providers: - Click the "Edit" button. The correct edit form should be displayed. - Click the "Delete" button next to a provider which is not used by any patrons. You should see an error message, "Are you sure you want to delete [provider name]." Test both cancel and confirm. - Click the "Delete" button next to a provider which is in use by one or more patrons. YOu should see an error message, "Are you sure you want to delete [provider name]? X patron(s) are using it!" Test both cancel and confirm. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16301 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50467|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50626&action=edit [PASSED QA] Bug 16301 - Remove the use of "onclick" from SMS cellular providers template This patch refactors some of the JavaScript in the SMS cellular providers template so that event attributes are removed from the markup. This patch also updates the markup for the "Edit" and "Delete" buttons to make them consistent with similar buttons in Koha. To test you must have the SMSSendDriver system preference set to "Email." - Go to Administration -> SMS cellular providers. - If necessary, create a new SMS cellular provider. - Edit at least one patron to use an SMS cellular provider under "Patron messaging preferences." - In the table of SMS cellular providers: - Click the "Edit" button. The correct edit form should be displayed. - Click the "Delete" button next to a provider which is not used by any patrons. You should see an error message, "Are you sure you want to delete [provider name]." Test both cancel and confirm. - Click the "Delete" button next to a provider which is in use by one or more patrons. YOu should see an error message, "Are you sure you want to delete [provider name]? X patron(s) are using it!" Test both cancel and confirm. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.