[Bug 20617] New: Add a link to 'Search Engine configuration' on the administration navigation list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Bug ID: 20617 Summary: Add a link to 'Search Engine configuration' on the administration navigation list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org Created attachment 74530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74530&action=edit Missing link for Search engine configuration On the #navmenulist of the different administration pages, link to 'Search engine configuration' menu is missing (should be under 'Item search fileds' link). It should be displayed only if the 'Searchengine' preference is set on 'ElasticSearch' (just like the menu on /admin/admin-home.pl). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com, | |nicolas.legrand@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a link to 'Search |Add 'Search Engine |Engine configuration' on |configuration' link to |the administration |administration menu |navigation list | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74658&action=edit Bug 20617: Add 'Search Engine configuration' link to administration menu This patch adds a link to the Elasticsearch configuration page in the administration sidebar menu when Elasticsearch is enabled. This patch also corrects the title of the Elasticsearch page to match the page heading. "Search engine configuration" instead of "Elasticsearch mappings." To test, apply the patch and set the SearchEngine system preference to "Elasticsearch." - View any page in the administration module which shows the left-hand sidebar menu. The link to search engine configuration should be there. - View the search engine configuration page and confirm that the page title is correct. - Set the SearchEngine system preferenc to "Zebra." - The search engine configuration link should no longer appear in the administration sidebar menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74658|0 |1 is obsolete| | --- Comment #2 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 74665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74665&action=edit Bug 20617: Add 'Search Engine configuration' link to administration menu This patch adds a link to the Elasticsearch configuration page in the administration sidebar menu when Elasticsearch is enabled. This patch also corrects the title of the Elasticsearch page to match the page heading. "Search engine configuration" instead of "Elasticsearch mappings." To test, apply the patch and set the SearchEngine system preference to "Elasticsearch." - View any page in the administration module which shows the left-hand sidebar menu. The link to search engine configuration should be there. - View the search engine configuration page and confirm that the page title is correct. - Set the SearchEngine system preferenc to "Zebra." - The search engine configuration link should no longer appear in the administration sidebar menu. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david.bourgault@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74665|0 |1 is obsolete| | --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74669&action=edit Bug 20617: Add 'Search Engine configuration' link to administration menu This patch adds a link to the Elasticsearch configuration page in the administration sidebar menu when Elasticsearch is enabled. This patch also corrects the title of the Elasticsearch page to match the page heading. "Search engine configuration" instead of "Elasticsearch mappings." To test, apply the patch and set the SearchEngine system preference to "Elasticsearch." - View any page in the administration module which shows the left-hand sidebar menu. The link to search engine configuration should be there. - View the search engine configuration page and confirm that the page title is correct. - Set the SearchEngine system preferenc to "Zebra." - The search engine configuration link should no longer appear in the administration sidebar menu. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Thanks Owen, it works as described ! Just a naive question left : (In reply to Owen Leonard from comment #1)
This patch also corrects the title of the Elasticsearch page to match the page heading. "Search engine configuration" instead of "Elasticsearch mappings."
That's a good idea, but as it only concerns Elasticsearch configuration, why do you prefer to keep "Search engine configuration" instead of "Elasticsearch configuration" ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Séverine Queune from comment #4)
That's a good idea, but as it only concerns Elasticsearch configuration, why do you prefer to keep "Search engine configuration" instead of "Elasticsearch configuration" ?
I wasn't sure which to go with for the same reason. I chose to match the existing page heading because I think "Search engine configuration" is a more user-friendly description. I assume that once Elasticsearch is enabled the librarian/administrator doesn't need to know they're configuring Elasticsearch. They only need to configure "the search engine." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74669|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74708&action=edit Bug 20617: Add 'Search Engine configuration' link to administration menu This patch adds a link to the Elasticsearch configuration page in the administration sidebar menu when Elasticsearch is enabled. This patch also corrects the title of the Elasticsearch page to match the page heading. "Search engine configuration" instead of "Elasticsearch mappings." To test, apply the patch and set the SearchEngine system preference to "Elasticsearch." - View any page in the administration module which shows the left-hand sidebar menu. The link to search engine configuration should be there. - View the search engine configuration page and confirm that the page title is correct. - Set the SearchEngine system preferenc to "Zebra." - The search engine configuration link should no longer appear in the administration sidebar menu. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 --- Comment #7 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Owen Leonard from comment #5)
(In reply to Séverine Queune from comment #4)
That's a good idea, but as it only concerns Elasticsearch configuration, why do you prefer to keep "Search engine configuration" instead of "Elasticsearch configuration" ?
I wasn't sure which to go with for the same reason. I chose to match the existing page heading because I think "Search engine configuration" is a more user-friendly description.
I assume that once Elasticsearch is enabled the librarian/administrator doesn't need to know they're configuring Elasticsearch. They only need to configure "the search engine."
Your logic makes sense, I'm ok with it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org