[Bug 15719] New: Silence warning in C4/Language.pm during web install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Bug ID: 15719 Summary: Silence warning in C4/Language.pm during web install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This problem was discovered the hard way: Drop DB Create DB Webinstaller run until the screen says: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. The error log file will contain an error about splitting an uninitialized value. Apply the patch Drop DB Create DB Webinstaller run until the screen says: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. The error log file will not contain that error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 47533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47533&action=edit Bug 15719: Silence warning in C4/Language.pm during web install Test empty database case. TEST PLAN --------- 1) prove -v t/Languages.t -- success (because test case is missing) 2) Apply this patch 3) prove -v t/Languages.t -- success, but warning printed. 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 47534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47534&action=edit Bug 15719: Silence warning in C4/Language.pm during web install This problem was discovered the hard way: - Drop DB - Create DB - Webinstaller run until the screen is: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. -- The error log file will end with an error about splitting an uninitialized value. TEST PLAN --------- 0) First patch already applied 1) prove -v t/Languages.t -- success, but warn prints 2) Apply this patch 3) prove -v t/Languages.t -- success without warning messages 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47533|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47744&action=edit [SIGNED-OFF]Bug 15719: Silence warning in C4/Language.pm during web install Test empty database case. TEST PLAN --------- 1) prove -v t/Languages.t -- success (because test case is missing) 2) Apply this patch 3) prove -v t/Languages.t -- success, but warning printed. 4) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. QA test tools rus OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47534|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47745&action=edit Bug 15719: Silence warning in C4/Language.pm during web install This problem was discovered the hard way: - Drop DB - Create DB - Webinstaller run until the screen is: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. -- The error log file will end with an error about splitting an uninitialized value. TEST PLAN --------- 0) First patch already applied 1) prove -v t/Languages.t -- success, but warn prints 2) Apply this patch 3) prove -v t/Languages.t -- success without warning messages 4) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. QA test tools run OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47744|0 |1 is obsolete| | Attachment #47745|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47806&action=edit Bug 15719: Silence warning in C4/Language.pm during web install - tests Test empty database case. TEST PLAN --------- 1) prove -v t/Languages.t -- success (because test case is missing) 2) Apply this patch 3) prove -v t/Languages.t -- success, but warning printed. 4) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. QA test tools rus OK Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47807&action=edit Bug 15719: Silence warning in C4/Language.pm during web install This problem was discovered the hard way: - Drop DB - Create DB - Webinstaller run until the screen is: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. -- The error log file will end with an error about splitting an uninitialized value. TEST PLAN --------- 0) First patch already applied 1) prove -v t/Languages.t -- success, but warn prints 2) Apply this patch 3) prove -v t/Languages.t -- success without warning messages 4) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. QA test tools run OK Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Much more readable (IMO) would have been my @languages = C4::Context->preference($preference_to_check) ? split /,/, C4::Context->preference($preference_to_check) : () -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #7)
Much more readable (IMO) would have been my @languages = C4::Context->preference($preference_to_check) ? split /,/, C4::Context->preference($preference_to_check) : ()
Perhaps, though double function/method calls are slower. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #9 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.10. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org