http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17370&action=edit Bug 10028: ModReceiveOrder unexpectedly works. In C4::Acquisition::ModReceiveOrder, a call to NewOrder is badly used. NewOrder returns ($basketno, $ordernumber) but in ModReceiveOrder the ordernumber is got with my $ordernumber = NewOrder( $args ); It works because: sub t{ return ("a", "b"); } my $a = t(); say $a; Will display 'b'. But it is not really clear. Test plan: Check that there is no regression for partial receives. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17370|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20211&action=edit Bug 10028: ModReceiveOrder unexpectedly works. In C4::Acquisition::ModReceiveOrder, a call to NewOrder is badly used. NewOrder returns ($basketno, $ordernumber) but in ModReceiveOrder the ordernumber is got with my $ordernumber = NewOrder( $args ); It works because: sub t{ return ("a", "b"); } my $a = t(); say $a; Will display 'b'. But it is not really clear. Test plan: Check that there is no regression for partial receives. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20211|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20405&action=edit Bug 10028: ModReceiveOrder unexpectedly works. In C4::Acquisition::ModReceiveOrder, a call to NewOrder is badly used. NewOrder returns ($basketno, $ordernumber) but in ModReceiveOrder the ordernumber is got with my $ordernumber = NewOrder( $args ); It works because: sub t{ return ("a", "b"); } my $a = t(); say $a; Will display 'b'. But it is not really clear. Test plan: Check that there is no regression for partial receives. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.