[Bug 36640] New: Upgrade DataTables from 1.13.6 to 2.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Bug ID: 36640 Summary: Upgrade DataTables from 1.13.6 to 2.x Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 34913 DataTables is now in 2.x releases, so we have more upgrading to do. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 [Bug 34913] Upgrade DataTables from 1.10.18 to 1.13.6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37800 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36291 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38113 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38113 [Bug 38113] Remove/replace deferLoading -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 [Bug 38185] DT - replace dom with layout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Status|NEW |ASSIGNED Blocks|38185 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 [Bug 38185] DT - replace dom with layout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 [Bug 38185] DT - replace dom with layout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33484 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Pushed a remote branch with the WIP work. It's built on top of bug 33484. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 [Bug 33484] Remember user's table state for all tables (Generalise table saveState for all tables) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- https://gitlab.com/joubu/Koha/-/commits/bug_36640 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Bug 36640 depends on bug 38113, which changed state. Bug 38113 Summary: Remove/replace deferLoading https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38113 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- For discussion Behaviour change: https://datatables.net/upgrade/2#Order-sequence """ When ordering columns by clicking on their header element, in v1 it would simply toggle between ascending and descending ordering for the columns (controllable with the columns.orderSequence option). DataTables 2 introduces a new option to this parameter, an empty string value which represents no ordering. The default has been updated to make use of this and the ordering sequence that is applied when clicking the header cell is now: Ascending Descending No order It will repeat that sequence indefinitely as the column header is clicked. As before, it can be controlled using the columns.orderSequence option, and if you wish to restore the default DataTables 1.x behaviour you can do so by setting the default: DataTable.defaults.column.orderSequence = ['asc', 'desc']; """ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 [Bug 38255] Do not use dataTable constructor directly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38259 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38259 [Bug 38259] Adjust DT's lengthMenu option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #3)
It will repeat that sequence indefinitely as the column header is clicked. As before, it can be controlled using the columns.orderSequence option, and if you wish to restore the default DataTables 1.x behaviour you can do so by setting the default:
DataTable.defaults.column.orderSequence = ['asc', 'desc'];
I reckon we keep the 1.x behaviour, yeah? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38295 [Bug 38295] Standardize "select all" behaviours -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38296 [Bug 38296] Investigate DataTables's extension StateRestore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25078 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37238 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 [Bug 37238] Add table settings to itemsearch results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13965, 33729 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13965 [Bug 13965] Add date last seen on item search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33729 [Bug 33729] Add a column for dateaccessioned to item search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #4)
(In reply to Jonathan Druart from comment #3)
It will repeat that sequence indefinitely as the column header is clicked. As before, it can be controlled using the columns.orderSequence option, and if you wish to restore the default DataTables 1.x behaviour you can do so by setting the default:
DataTable.defaults.column.orderSequence = ['asc', 'desc'];
I reckon we keep the 1.x behaviour, yeah?
Done in commit "Bug 36640: Restore previous order sequence behaviour" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- This is ready for testing. There is a "TODO" commit at the top of the branch with the known to be done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38310 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38310 [Bug 38310] DataTables - Use Select2 for column filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Style of the selects in the column filter has been reverted inadvertently on the item search. Trying to summarize the findings here: The selector is `#itemsearchform select, input[type="text"] {`, which is wrong. It is supposed to apply to the item search *form* only, but we apply to all the inputs. There is another class we have lost: .form-control This is what was used by the selects. Now we are using the filters added from datatables.js and the class no longer exist. There is a class already on the selects: "dt-select-filter", we should use this one, and add one to the inputs: "dt-input-filter". And add a style for them, that will be applied to ALL columns filters of all our tables using them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38311 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38311 [Bug 38311] DataTables - Simplify the building of the dropdown list filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26553 [Bug 26553] Datatables button code is duplicated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38388 [Bug 38388] Investigate DataTables's extension SearchBuilder -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #8 from Lisette Scheer <lisette@bywatersolutions.com> --- Testing in my devbox comparing to main on a bywatersandbox: -Sorting works correctly -Column toggle works correctly -Export works correctly -Copy sharable link works, (after I changed the base url setting) -Configure no longer jumps to the correct table on the configure page, just the section. (also on main) -The font size is 11.7px (computed) rather than 13px and the columns are less clearly delineated in the dropdown. Tables tested: -Issues (on checkouts and more members) -Patron search results -Filter search no longer works for typing library in the main filter box, the dropdown does work -Returns -Holds Queue -Bookings to collect -holds to pull (there was an error in both main and devbox when trying hold ratios) The biggest concern I have is the change in font size making it harder to read and than when you zoom the columns toggle moves off the screen after a couple zooms. That's an accessibility issue for sure. Otherwise everything I tested worked well except the filter search in library working in main and not this. Those could be a problem but I'm not sure if they're big enough to block it or if followups would be better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lisette Scheer from comment #8)
Testing in my devbox comparing to main on a bywatersandbox: -Sorting works correctly -Column toggle works correctly -Export works correctly -Copy sharable link works, (after I changed the base url setting) -Configure no longer jumps to the correct table on the configure page, just the section. (also on main) -The font size is 11.7px (computed) rather than 13px and the columns are less clearly delineated in the dropdown.
Tables tested: -Issues (on checkouts and more members) -Patron search results -Filter search no longer works for typing library in the main filter box, the dropdown does work -Returns -Holds Queue -Bookings to collect -holds to pull (there was an error in both main and devbox when trying hold ratios)
The biggest concern I have is the change in font size making it harder to read and than when you zoom the columns toggle moves off the screen after a couple zooms. That's an accessibility issue for sure. Otherwise everything I tested worked well except the filter search in library working in main and not this.
Those could be a problem but I'm not sure if they're big enough to block it or if followups would be better.
I think font-size would hopefully be an easy fix and we should file the problem with the configure link - I noticed it too on main. But it doesn't sound as we have a blocker here currently. Lisette, would you agree? Would you be OK signing off? and Thanks for all the testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@ptfs-europe.com --- Comment #10 from Jake Deery <jake.deery@ptfs-europe.com> --- See https://koha-hedgedoc.servers.llownd.net/s/Comments_on_the_DataTables_2.x_sw... I have yet to find an issue. If a patch were attached, I would gladly sign-off :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #11 from Jake Deery <jake.deery@ptfs-europe.com> --- See also https://chat.koha-community.org/koha-community/pl/151pyfpk13fnbdpyiqk495bida :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Found an issue: Acquisitions -> Invoices Checking the "Show only subscriptions" checkbox triggers an error in the console: Uncaught TypeError: $(...).dataTable().columns is not a function invoices.pl:1977:49 I don't know if it makes a difference that I don't have any invoices related to subscriptions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #13 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #9)
But it doesn't sound as we have a blocker here currently. Lisette, would you agree? Would you be OK signing off? and Thanks for all the testing!
Yes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- The "Clear filter" button isn't getting added in some situations... I've noticed it on the suggestions page and the Z39.50/SRU servers page.' I pushed a small fix for the alignment of the clear button here: https://gitlab.com/koha-dev/koha-dev/-/commits/bug_36640. It can be tested with libraries administration, cities, and SMTP servers just to name a few. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lisette Scheer from comment #8)
-Patron search results -Filter search no longer works for typing library in the main filter box, the dropdown does work
Because bug 38130 was not on the branch. Done now. (In reply to Owen Leonard from comment #14)
The "Clear filter" button isn't getting added in some situations... I've noticed it on the suggestions page and the Z39.50/SRU servers page.'
Fixed on "Bug 36640: (follow-up) Remove fnFilter - fix acqui/invoices"
I pushed a small fix for the alignment of the clear button here: https://gitlab.com/koha-dev/koha-dev/-/commits/bug_36640. It can be tested with libraries administration, cities, and SMTP servers just to name a few.
cherry-picked, thanks! Added Jake and Lisette's signed-off-by lines, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- The configure link behaviour will be fixed by the follow-up on bug 38069. Waiting for RM to pick it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> ---
(In reply to Owen Leonard from comment #14)
The "Clear filter" button isn't getting added in some situations... I've noticed it on the suggestions page and the Z39.50/SRU servers page.'
Fixed on "Bug 36640: (follow-up) Remove fnFilter - fix acqui/invoices"
That commit only touches acqui/invoices.tt. Are you thinking of a different fix? I still see the problem today after a fresh pull from your branch. It looks like table which use KohaTable() are affected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Where are we at here? Will you attach the patches to bugzilla or should I pick from remote? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Quotes editor fixed on "Bug 36640: Fix quotes editor" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lisette Scheer from comment #8)
-The font size is 11.7px (computed) rather than 13px and the columns are less clearly delineated in the dropdown.
In my test the font size is the same before and after the upgrade, so I suspect it's an optical illusion related to the fact that the new version doesn't have the same borders and padding. I left the dropdowns looking like the default in DataTables 2 rather than applying the custom style we had before. Perhaps that was a mistake? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #16)
The configure link behaviour will be fixed by the follow-up on bug 38069. Waiting for RM to pick it.
Picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Trying to correct a confusion. (In reply to Jonathan Druart from comment #15)
(In reply to Owen Leonard from comment #14)
The "Clear filter" button isn't getting added in some situations... I've noticed it on the suggestions page and the Z39.50/SRU servers page.'
Fixed on "Bug 36640: (follow-up) Remove fnFilter - fix acqui/invoices"
This patch was not for the "clear filter" I quoted, but for this comment: (In reply to Owen Leonard from comment #14)
The "Clear filter" button isn't getting added in some situations... I've noticed it on the suggestions page and the Z39.50/SRU servers page.'
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38440 [Bug 38440] dt_button_clear_filter handling outside of datatables.js not needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30113 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30113 [Bug 30113] kohaTable add_filters option should be renamed to show_filter_row -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- "Clear filter" should be fixed on "Bug 36640: Fix display of 'Clear filter'" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- New commit: "Bug 36640: Fix behaviour of 'Clear filter'" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #25 from Jake Deery <jake.deery@ptfs-europe.com> --- Just to update, I've tested Joubu's latest commits and they're now working. Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 [Bug 38436] Unable to hide a column in the holdings table in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174575&action=edit Bug 36640: Fix Asset.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38456 [Bug 38456] Custom properties no longer accepted by DataTables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 [Bug 38461] Table features needs to be covered by e2e tests - Cypress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38472 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 [Bug 38472] exportColumns hard-coded in patron categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174783&action=edit Bug 36640: (follow-up) Fix itemsearch We replaced 'columnFilter', and it's no longer there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38484 [Bug 38484] Filters on the "Holds to pull" page is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please switch status back to Passed QA when attaching a follow-up. It's hard to make sure I catch them all with the continuous big amount of bug email. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked "(follow-up) Fix itemsearch" for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38114 [Bug 38114] columns_settings.inc used when not needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30633, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27572 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38543 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38543 [Bug 38543] dataTables assets included but no longer exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 [Bug 38596] DataTable - Previous order sequence behaviour not restored at the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38958 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38958 [Bug 38958] Search history deletion broken in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38472 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 [Bug 38472] exportColumns hard-coded in patron categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38440 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38440 [Bug 38440] dt_button_clear_filter handling outside of datatables.js not needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39080 [Bug 39080] Holds to Pull table headers incorrect size on scroll -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 [Bug 39169] Acquisitions homepage no longer automatically hides "active" and "budget period" columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #31 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Internal architecture, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39775 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39775 [Bug 39775] Serials claims table filters aren't working -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 --- Comment #32 from David Cook <dcook@prosentient.com.au> --- *** Bug 37800 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 36291 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39814 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39814 [Bug 39814] Filters on serial arrays are broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40314 [Bug 40314] Table columns aren't showing/responding properly in opac course reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|carthur@slolibrary.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 [Bug 40816] Upgrade DataTables from 2.1.8 to >2.3.4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42912 [Bug 42912] Javascript error on opac-readingrecord when no Circulation history -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org