http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38161&action=edit Bug 14016: Restore correct date format on issue date (00:00 vs 23:59) Introduced by bug 13601, and same fix used in bug 10423 and bug 12847: the date_due retrieved from the DB is modified. There are some problems: 1/ There is confusion between the iso and sql formats in the codebase. 2/ Since bug 13601, dt_from_string does not manage the iso format (there are occurrences of 'iso' but it assumes that both formats are identical). To solve the issue, 2 solutions: 1/ Same as bug 10423 and bug 12847: try to get rid of the change done on date_due in C4::Members::GetPendingIssues, it should be kept as the sql value. 2/ Too many errors found and another fallback should be added to dt_from_string (if 'iso' is passed, try sql then iso). Test plan: Go on the checkout list at the OPAC and confirm that the due dates are correctly formatted. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38161|0 |1 is obsolete| | --- Comment #2 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 38198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38198&action=edit Bug 14016: Restore correct date format on issue date (00:00 vs 23:59) Introduced by bug 13601, and same fix used in bug 10423 and bug 12847: the date_due retrieved from the DB is modified. There are some problems: 1/ There is confusion between the iso and sql formats in the codebase. 2/ Since bug 13601, dt_from_string does not manage the iso format (there are occurrences of 'iso' but it assumes that both formats are identical). To solve the issue, 2 solutions: 1/ Same as bug 10423 and bug 12847: try to get rid of the change done on date_due in C4::Members::GetPendingIssues, it should be kept as the sql value. 2/ Too many errors found and another fallback should be added to dt_from_string (if 'iso' is passed, try sql then iso). Test plan: Go on the checkout list at the OPAC and confirm that the due dates are correctly formatted. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #3)

Going to pass this patch as it fixes the checkouts tab, but the problem is still visible on the overdues tab - repeat test plan, but check out an item with a due date in the past, so that you get an overdues tab in the patron account.

Yep, see last patch. It should be corrected in the same patchset. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38232|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38292&action=edit [PASSED QA] Bug 14016: (follow-up) Restore correct date format on issue date (00:00 vs 23:59) Same for the overdues. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.